kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Fix package script command deploy:kit #160

Merged
fsmanuel merged 1 commits from bugfix/packages-install-scripts into master 2019-08-04 17:42:43 +00:00
Conversation 8 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -16,7 +16,7 @@
"bootstrap": "npm run reset:hard && npm run seeds", "bootstrap": "npm run reset:hard && npm run seeds",
"reset": "npm run deploy:kit && npm run deploy:dao", "reset": "npm run deploy:kit && npm run deploy:dao",
"reset:hard": "npm run deploy:apps && npm run reset", "reset:hard": "npm run deploy:apps && npm run reset",
"deploy:kit": "npm run compile-contracts && aragon contracts exec scripts/deploy-kit.js", "deploy:kit": "aragon contracts exec scripts/deploy-kit.js",
"deploy:dao": "aragon contracts exec scripts/new-dao.js", "deploy:dao": "aragon contracts exec scripts/new-dao.js",
bumi commented 2019-08-05 07:44:59 +00:00 (Migrated from github.com)
Review
Copy Link

what was actually broken? are the contracts still compiled?

what was actually broken? are the contracts still compiled?
raucao commented 2019-08-05 08:54:44 +00:00 (Migrated from github.com)
Review
Copy Link
  • The command fails both on @fsmanuel's an my machine.
  • Compiling the contracts isn't the same as deploying something.
  • In the bootstrap, the contracts are compiled before this step.
* The command fails both on @fsmanuel's an my machine. * Compiling the contracts isn't the same as deploying something. * In the bootstrap, the contracts are compiled before this step.
bumi commented 2019-08-05 08:58:01 +00:00 (Migrated from github.com)
Review
Copy Link

ok, but then we need to fix the compile-contracts command?

at which step are the contracts compiled?

ok, but then we need to fix the `compile-contracts` command? at which step are the contracts compiled?
raucao commented 2019-08-05 09:28:18 +00:00 (Migrated from github.com)
Review
Copy Link

I guess so. Frankly, I don't know what is needed and what isn't, but this one was consistently failing and nobody fixed it. So this change is more of a hotfix to get the bootstrap to work, because most people don't change the kit contract or other such contracts.

I guess so. Frankly, I don't know what is needed and what isn't, but this one was consistently failing and nobody fixed it. So this change is more of a hotfix to get the bootstrap to work, because most people don't change the kit contract or other such contracts.
bumi commented 2019-08-05 09:42:19 +00:00 (Migrated from github.com)
Review
Copy Link

is there an issue for that? compile-contracts works fine for me (just tested it again)
even though people won't change the kit, I assumed the kit still needs to be compiled to run the deploy script.

is there an issue for that? `compile-contracts` works fine for me (just tested it again) even though people won't change the kit, I assumed the kit still needs to be compiled to run the deploy script.
bumi commented 2019-08-05 09:44:46 +00:00 (Migrated from github.com)
Review
Copy Link

if you have a fresh clone (without the build directory) you'll now get a:
Error: ENOENT: no such file or directory, scandir '[...]/build/contracts' error.
so contracts need to be deployed, it probably works for you now because you had deployed contracts in the build directory.

I can not reproduce any compile error here. :(

if you have a fresh clone (without the `build` directory) you'll now get a: `Error: ENOENT: no such file or directory, scandir '[...]/build/contracts'` error. so contracts need to be deployed, it probably works for you now because you had deployed contracts in the `build` directory. I can not reproduce any compile error here. :(
raucao commented 2019-08-05 10:49:43 +00:00 (Migrated from github.com)
Review
Copy Link

I can not reproduce any compile error here. :(

Then we need to add the complete install and bootstrap on Travis, because @fsmanuel and I both have the same compilation errors on two different operating systems with different environments.

> I can not reproduce any compile error here. :( Then we need to add the complete install and bootstrap on Travis, because @fsmanuel and I both have the same compilation errors on two different operating systems with different environments.
bumi commented 2019-08-05 13:28:36 +00:00 (Migrated from github.com)
Review
Copy Link

good idea. can you create an issue with the error you've seen? thanks

good idea. can you create an issue with the error you've seen? thanks
"deploy:apps": "./scripts/every-app.sh \"aragon apm publish major\"", "deploy:apps": "./scripts/every-app.sh \"aragon apm publish major\"",
"devchain": "aragon devchain --port 7545", "devchain": "aragon devchain --port 7545",