Remove Aragon CLI, document system deps #162

2019-08-09T16:06:30Z

raucao commented

2019-08-09 16:06:30 +00:00

(Migrated from github.com)

In order to prevent regular issues with the notoriously npm-issue-ridden Aragon CLI module, this removes it as a direct dependency and requires it to be installed as a system dependency.

Also adds Truffle as a system dependency to the docs (which was missing before).

The latest Aragon CLI asks has a lot of prompts for every contract deployment. I'll see if we can remove those by specifying more arguments upfront.

refs #158

In order to prevent regular issues with the notoriously npm-issue-ridden Aragon CLI module, this removes it as a direct dependency and requires it to be installed as a system dependency. Also adds Truffle as a system dependency to the docs (which was missing before). The latest Aragon CLI asks has a lot of prompts for every contract deployment. I'll see if we can remove those by specifying more arguments upfront. refs #158

bumi commented

2019-08-09 16:35:13 +00:00

(Migrated from github.com)

this is awesome! thanks for looking into it.
maybe we can add the used/tested aragon and truffle version to the readme?

and I think that's a kredits-2

this is awesome! thanks for looking into it. maybe we can add the used/tested aragon and truffle version to the readme? and I think that's a `kredits-2`

raucao commented

2019-08-09 16:38:09 +00:00

(Migrated from github.com)

maybe we can add the used/tested aragon and truffle version to the readme?

Then we have to update it like every two days. They release a lot over at Aragon. :)

and I think that's a kredits-2

Nah, 1 is perfectly fine. Didn't take long.

> maybe we can add the used/tested aragon and truffle version to the readme? Then we have to update it like every two days. They release *a lot* over at Aragon. :) > and I think that's a `kredits-2` Nah, 1 is perfectly fine. Didn't take long.

raucao commented

2019-08-09 16:38:36 +00:00

(Migrated from github.com)

Tests are also green after adding sys deps. Merging...

👍 1

bumi commented

2019-08-09 16:41:39 +00:00

(Migrated from github.com)

Then we have to update it like every two days. They release a lot over at Aragon. :)

yep, but also breaking changes. - at least we have to keep in mind which versions we are using/supporting

> Then we have to update it like every two days. They release _a lot_ over at Aragon. :) yep, but also breaking changes. - at least we have to keep in mind which versions we are using/supporting

raucao commented

2019-08-09 16:48:21 +00:00

(Migrated from github.com)

Whoever sees something breaking with the latest version on their system should open an issue imo.

We can then at least do a bootstrap on Travis, too, but testing every single truffle script on Travis e.g. would be quite the effort.

Whoever sees something breaking with the latest version on their system should open an issue imo. We can then at least do a bootstrap on Travis, too, but testing every single truffle script on Travis e.g. would be quite the effort.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#162