kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

WIP: KreditsKit tests #176

Closed
haythem96 wants to merge 1 commits from tests/contracts-kit into master
pull from: tests/contracts-kit
merge into: :master
Conversation 3 Commits 1 Files Changed 3
+106 -1
haythem96 commented 2019-09-23 00:18:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Had problem testing the Kit with the Vault app so decided to write tests for the current Kit... still have errors

Had problem testing the Kit with the Vault app so decided to write tests for the current Kit... still have errors
haythem96 commented 2019-09-23 00:20:52 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi I never understood why the function _installApp(Kernel _dao, bytes32 _appId) internal returns (AragonApp) why don't we just use:

dao.newAppInstance(
                appIds[0],
                latestVersionAppBase(appIds[0]),
                new bytes(0),
                true
            )
@bumi I never understood why the function `_installApp(Kernel _dao, bytes32 _appId) internal returns (AragonApp)` why don't we just use: ``` dao.newAppInstance( appIds[0], latestVersionAppBase(appIds[0]), new bytes(0), true ) ```
haythem96 commented 2019-09-23 00:21:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

For some reason the newInstance() revert in the test...

For some reason the `newInstance()` revert in the test...
raucao commented 2021-11-14 22:46:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing due to inactivity. Please feel free to re-open.

Closing due to inactivity. Please feel free to re-open.

Pull request closed

Please reopen this pull request to perform a merge.
This pull request is marked as a work in progress.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#176