Some required dependency updates #194

2020-04-15T18:46:28Z

bumi commented

2020-04-15 18:46:28 +00:00

(Migrated from github.com)

those are some dependency updates I had to add to run on the latest aragon version.

raucao commented

2020-05-01 08:02:05 +00:00

(Migrated from github.com)

Want to fix the linter error so we can merge this? Would be good to branch off from master with up-to-date dependencies...

raucao commented

2020-05-07 07:36:53 +00:00

(Migrated from github.com)

I just had another look at Travis, after fixing the linter issue, and it turns out the tests are being run before the devchain has finished starting up, due to it just being sent to background with &.

I just had another look at Travis, after fixing the linter issue, and it turns out the tests are being run before the devchain has finished starting up, due to it just being sent to background with `&`.

raucao commented

2020-05-07 08:00:54 +00:00

(Migrated from github.com)

After fixing the devchain startup issue, I found that the tests are failing both locally and on Travis, but with different errors.

Locally, there's an actual test failure in token, with an exception for a wrong argument. On Travis, the tests don't compile in the first place:

Error: Cannot find module '@aragon/test-helpers/assertThrow'

I commented the contract tests in the Travis config, so they can be fixed outside of this PR.

After fixing the devchain startup issue, I found that the tests are failing both locally and on Travis, but with different errors. Locally, there's an actual test failure in `token`, with an exception for a wrong argument. On Travis, the tests don't compile in the first place: > Error: Cannot find module '@aragon/test-helpers/assertThrow' I commented the contract tests in the Travis config, so they can be fixed outside of this PR.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#194