[WIP] Add function to batch votings #20

2018-04-08T13:06:42Z

bumi commented

2018-04-08 13:06:42 +00:00

(Migrated from github.com)

The batchVote function accepts an array of proposal ids and votes for
every one.
Normally arrays without fix length are problematic and gas usage can not be
estimated really well. So we need to see how that works or what other
pattern could be used.

The batchVote function accepts an array of proposal ids and votes for every one. Normally arrays without fix length are problematic and gas usage can not be estimated really well. So we need to see how that works or what other pattern could be used.

raucao commented

2018-04-08 13:09:41 +00:00

(Migrated from github.com)

lgtm 👍

lgtm :+1:

bumi commented

2018-04-09 08:42:05 +00:00

(Migrated from github.com)

generally we need to keep an eye on the fees as those will ne n times vote(). and maybe n proposals will be executed (also see #10 for discussion)

raucao commented

2018-04-09 09:11:09 +00:00

(Migrated from github.com)

generally we need to keep an eye on the fees as those will ne n times vote(). and maybe n proposals will be executed (also see #10 for discussion)

That would be an acceptable scenario, as one would have to pay the same fee for all seperate vote transactions in this case.

> generally we need to keep an eye on the fees as those will ne n times vote(). and maybe n proposals will be executed (also see #10 for discussion) That would be an acceptable scenario, as one would have to pay the same fee for all seperate vote transactions in this case.

👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

This pull request is marked as a work in progress.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#20