kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Add voterIds to proposals #22

Merged
bumi merged 1 commits from features/add-voterids-to-proposals into master 2018-04-10 12:01:24 +00:00
Conversation 1 Commits 1 Files Changed 1 +39 -27
bumi commented 2018-04-09 16:17:54 +00:00 (Migrated from github.com)
Copy Link

Adding a voterIds array to the proposal.
This allows us to check if a user already has voted on a proposal. As this is not directly supported by the default proposals accessor this also adds a getProposal function to get all proposal data.

IMPORTANT: this also changes how proposals are stored. it switches from an array to a mapping with uint keys. that means keys now start with 1 instead of 0.
Generally I have a feeling that mappings are better to store such data and make it easier to clean up in the future - maybe ...

Adding a voterIds array to the proposal. This allows us to check if a user already has voted on a proposal. As this is not directly supported by the default proposals accessor this also adds a getProposal function to get all proposal data. IMPORTANT: this also changes how proposals are stored. it switches from an array to a mapping with uint keys. that means keys now start with 1 instead of 0. Generally I have a feeling that mappings are better to store such data and make it easier to clean up in the future - maybe ...
fsmanuel (Migrated from github.com) approved these changes 2018-04-10 12:01:17 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link

👍

👍
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#22
No description provided.
Delete Branch "features/add-voterids-to-proposals"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?