Add voterIds to proposals #22

2018-04-09T16:17:54Z

bumi commented

2018-04-09 16:17:54 +00:00

(Migrated from github.com)

Adding a voterIds array to the proposal.
This allows us to check if a user already has voted on a proposal. As this is not directly supported by the default proposals accessor this also adds a getProposal function to get all proposal data.

IMPORTANT: this also changes how proposals are stored. it switches from an array to a mapping with uint keys. that means keys now start with 1 instead of 0.
Generally I have a feeling that mappings are better to store such data and make it easier to clean up in the future - maybe ...

Adding a voterIds array to the proposal. This allows us to check if a user already has voted on a proposal. As this is not directly supported by the default proposals accessor this also adds a getProposal function to get all proposal data. IMPORTANT: this also changes how proposals are stored. it switches from an array to a mapping with uint keys. that means keys now start with 1 instead of 0. Generally I have a feeling that mappings are better to store such data and make it easier to clean up in the future - maybe ...

fsmanuel (Migrated from github.com) approved these changes 2018-04-10 12:01:17 +00:00

fsmanuel (Migrated from github.com) left a comment

👍

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#22