kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Remove claims, add withdrawals #225

Merged
raucao merged 4 commits from feature/184-remove_kredits_claims into feature/export-import 2022-08-30 08:53:55 +00:00
Conversation 3 Commits 4 Files Changed 10
+129 -87
raucao commented 2022-08-25 09:46:59 +00:00
Owner
Copy Link
Copy Source

closes #184

closes #184
raucao added 2 commits 2022-08-25 09:46:59 +00:00
Add tests for Contributor#add()
continuous-integration/drone/push Build is failing
Details
dc2c8130f3
WIP Remove claims, add withdrawals
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2b3fd1241d
raucao requested review from bumi 2022-08-25 09:47:07 +00:00
raucao requested review from hueso 2022-08-25 09:47:07 +00:00
raucao marked the pull request as work in progress 2022-08-25 09:47:27 +00:00
raucao added 1 commit 2022-08-25 09:51:50 +00:00
Make test complete, add FIXME note
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
e99184b83f
raucao added 1 commit 2022-08-27 08:31:04 +00:00
Use uint32 for kreditsWithdrawn
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
5da710cc14 
Same as the properties and functions in the Contribution contract
raucao marked the pull request as ready for review 2022-08-27 08:31:16 +00:00
raucao commented 2022-08-27 08:35:11 +00:00
Author
Owner
Copy Link
Copy Source

@bumi, @hueso: I resolved the question about token number resolution. It has to be WEI for ERC20 and wallet display, but we use integers as uint32 for all other kredits amounts internally. Ready for review/merge!

@bumi, @hueso: I resolved the question about token number resolution. It has to be WEI for ERC20 and wallet display, but we use integers as `uint32` for all other kredits amounts internally. Ready for review/merge!
hueso approved these changes 2022-08-29 20:10:01 +00:00
raucao merged commit fd012d5359 into feature/export-import 2022-08-30 08:53:55 +00:00
raucao deleted branch feature/184-remove_kredits_claims 2022-08-30 08:53:55 +00:00
bumi reviewed 2022-08-30 10:10:12 +00:00
contracts/Contributor.sol
@@ -149,0 +164,4 @@
uint32 amountWithdrawable = confirmedKredits - c.kreditsWithdrawn;
require (amountWithdrawable > 0, "No kredits available");
c.kreditsWithdrawn += amountWithdrawable;
bumi commented 2022-08-30 10:10:12 +00:00
Owner
Copy Link
Copy Source

wondering if we should add an assert(c.kreditsWithdrawn <= confirmedKredits) ?

wondering if we should add an `assert(c.kreditsWithdrawn <= confirmedKredits)` ?
raucao commented 2022-08-30 11:25:36 +00:00
Author
Owner
Copy Link
Copy Source

That's just the same as the line above, where confirmedKredits - c.kreditsWithdrawn is required to be > 0, no?

That's just the same as the line above, where `confirmedKredits - c.kreditsWithdrawn` is required to be `> 0`, no?
Sign in to join this conversation.
Reviewers
No Reviewers
hueso
bumi
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#225