kredits/contracts
kredits
/
contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Make Kredits undivisible #227

Merged
raucao merged 1 commits from feature/undivisible into master 2022-09-02 07:49:23 +00:00
Conversation 0 Commits 1 Files Changed 1 +6 -3
hueso commented 2022-09-02 01:42:36 +00:00
Member
Copy Link

The default for ERC20 tokens is to have 18 decimals.
This patch sets it to 0 on KS token.
Note that we no longer need the conversion from Wei values, fortunately I have not found any other instances of Wei usage in kredits contracts.

The default for ERC20 tokens is to have 18 decimals. This patch sets it to 0 on KS token. Note that we no longer need the conversion from Wei values, fortunately I have not found any other instances of Wei usage in kredits contracts.
hueso added 1 commit 2022-09-02 01:42:36 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
1e4f7be5cf
make KS undivisible
hueso requested review from raucao 2022-09-02 01:46:25 +00:00
raucao approved these changes 2022-09-02 07:48:49 +00:00
raucao left a comment
Owner
Copy Link

LGTM! 👍

LGTM! 👍
raucao added the
kredits-1
 label 2022-09-02 07:49:15 +00:00
raucao merged commit f390b5dff5 into master 2022-09-02 07:49:23 +00:00
raucao deleted branch feature/undivisible 2022-09-02 07:49:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
raucao
Labels
Clear labels   
good first issue

Good for newcomers

  
ipfs

   
rsk

   
scaling
  
bug

Something is not working

  
dev environment

Config, builds, CI, deployment, etc.

  
docs

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

Improving existing functionality

  
feature

New functionality

  
idea

Something to consider

  
invalid

Not a bug

  
kredits-1

Small contribution

  
kredits-2

Medium contribution

  
kredits-3

Large contribution

  
question

Looking for an answer

  
release
major

  
release
minor

  
release
patch

  
security

All your base are belong to us

  
ui/ux

User interface, process design, etc.

  
wontfix

This won't be fixed

No Label
good first issue
ipfs
rsk
scaling
bug
dev environment
docs
duplicate
enhancement
feature
idea
invalid
kredits-1
kredits-2
kredits-3
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#227
No description provided.
Delete Branch "feature/undivisible"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?