kredits/contracts
kredits
/
contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Add RSK testnet deploy addresses #228

Closed
bumi wants to merge 3 commits from deploy/rsk-testnet into master
pull from: deploy/rsk-testnet
merge into: kredits:master
Conversation 4 Commits 3 Files Changed 3 +36 -1
bumi commented 2022-09-27 13:46:28 +00:00
Owner
Copy Link
No description provided.
bumi added 1 commit 2022-09-27 13:46:28 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
1e3a4aef2e Add RSK testnet deploy addresses
bumi commented 2022-09-27 13:59:51 +00:00
Author
Owner
Copy Link

I added a contributor and a contribution.

but in kredits-web I am getting:

Uncaught (in promise) TypeError: total.toNumber is not a function
    totalKreditsEarned kredits.js:135
    promise callback*_default<.totalKreditsEarned< kredits.js:135
I added a contributor and a contribution. but in kredits-web I am getting: ``` Uncaught (in promise) TypeError: total.toNumber is not a function totalKreditsEarned kredits.js:135 promise callback*_default<.totalKreditsEarned< kredits.js:135 ```
bumi added 1 commit 2022-09-27 14:01:24 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
f8f85630a2 Add RSK public network to hardhart config
bumi added 1 commit 2022-09-27 14:02:43 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
dbf7e85707 Update rks testent network name
raucao commented 2022-09-27 14:07:28 +00:00
Owner
Copy Link

Probably a side effect of 1e4f7be5cf ?

Probably a side effect of 1e4f7be5cf22a4607183ca2328fc587b8d54e8e2 ?
bumi commented 2022-09-27 17:11:13 +00:00
Author
Owner
Copy Link

looks like it. this one is no longer a bignumber I think: 1e240b6539/app/services/kredits.js (L156-L157)

so the toNumber can be removed there I think

looks like it. this one is no longer a bignumber I think: https://github.com/67P/kredits-web/blob/1e240b65393924f7b7064f9e7d64856e71f68691/app/services/kredits.js#L156-L157 so the toNumber can be removed there I think
raucao commented 2022-10-17 09:31:51 +00:00
Owner
Copy Link

Closing this one, since we're not using those addresses later.

Closing this one, since we're not using those addresses later.
raucao closed this pull request 2022-10-17 09:31:51 +00:00
raucao deleted branch deploy/rsk-testnet 2022-10-17 09:31:58 +00:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
good first issue

Good for newcomers

  
ipfs

   
rsk

   
scaling
  
bug

Something is not working

  
dev environment

Config, builds, CI, deployment, etc.

  
docs

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

Improving existing functionality

  
feature

New functionality

  
idea

Something to consider

  
invalid

Not a bug

  
kredits-1

Small contribution

  
kredits-2

Medium contribution

  
kredits-3

Large contribution

  
question

Looking for an answer

  
release
major

  
release
minor

  
release
patch

  
security

All your base are belong to us

  
ui/ux

User interface, process design, etc.

  
wontfix

This won't be fixed

No Label
good first issue
ipfs
rsk
scaling
bug
dev environment
docs
duplicate
enhancement
feature
idea
invalid
kredits-1
kredits-2
kredits-3
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#228
No description provided.
Delete Branch "deploy/rsk-testnet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?