kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Add batch voting for proposals #26

Merged
bumi merged 2 commits from features/batch-voting into master 2018-04-24 12:40:16 +00:00
Conversation 5 Commits 2 Files Changed 1 +7
bumi commented 2018-04-15 16:16:35 +00:00 (Migrated from github.com)
Copy Link

The batchVote function accepts an array of proposal ids and votes for
every one.
Normally arrays without fix length are problematic and gas usage can not be
estimated really well. So we need to see how that works or what other
pattern could be used.

The batchVote function accepts an array of proposal ids and votes for every one. Normally arrays without fix length are problematic and gas usage can not be estimated really well. So we need to see how that works or what other pattern could be used.
fsmanuel commented 2018-04-24 12:37:41 +00:00 (Migrated from github.com)
Copy Link

@bumi can you rebase? I'm working on kredits-web for this. Need to test if it works.

@bumi can you rebase? I'm working on `kredits-web` for this. Need to test if it works.
bumi commented 2018-04-24 12:39:29 +00:00 (Migrated from github.com)
Copy Link

done, conflict should be resolved.

done, conflict should be resolved.
fsmanuel (Migrated from github.com) approved these changes 2018-04-24 12:40:08 +00:00
fsmanuel commented 2018-04-24 12:40:57 +00:00 (Migrated from github.com)
Copy Link

I need to build the abis again, right?

I need to build the abis again, right?
bumi commented 2018-04-24 12:43:27 +00:00 (Migrated from github.com)
Copy Link

yes, otherwise the JS does not know about the new function.
npm run build-json should do the trick?

I am not sure if it is good to add the ABI changes in the PR it could easily cause conflicts - similar to a gemfile.lock or similar. - So I think it is better to build them in master? what do you think? how should we handle this in the future?

yes, otherwise the JS does not know about the new function. `npm run build-json` should do the trick? I am not sure if it is good to add the ABI changes in the PR it could easily cause conflicts - similar to a gemfile.lock or similar. - So I think it is better to build them in master? what do you think? how should we handle this in the future?
fsmanuel commented 2018-04-24 12:47:50 +00:00 (Migrated from github.com)
Copy Link

I was wondering the same. I guess if we rebase/merge master before we merge the PR we should commit the ABI changes in the PR.

I was wondering the same. I guess if we rebase/merge master before we merge the PR we should commit the ABI changes in the PR.
Sign in to join this conversation.
Reviewers
No reviewers
fsmanuel
Labels
Clear labels   
good first issue

Good for newcomers

  
ipfs

   
rsk

   
scaling
  
bug

Something is not working

  
dev environment

Config, builds, CI, deployment, etc.

  
docs

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

Improving existing functionality

  
feature

New functionality

  
idea

Something to consider

  
invalid

Not a bug

  
kredits-1

Small contribution

  
kredits-2

Medium contribution

  
kredits-3

Large contribution

  
question

Looking for an answer

  
release
major

  
release
minor

  
release
patch

  
security

All your base are belong to us

  
ui/ux

User interface, process design, etc.

  
wontfix

This won't be fixed

No Label
good first issue
ipfs
rsk
scaling
bug
dev environment
docs
duplicate
enhancement
feature
idea
invalid
kredits-1
kredits-2
kredits-3
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#26
No description provided.
Delete Branch "features/batch-voting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?