kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Rename healthcheck to PreflightChecker #49

Merged
bumi merged 2 commits from preflight-check into master 2018-06-07 14:39:08 +00:00
Conversation 2 Commits 2 Files Changed 2
+5 -5
bumi commented 2018-06-07 13:25:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

see related https://github.com/67P/kredits-web/pull/59

see related https://github.com/67P/kredits-web/pull/59
raucao (Migrated from github.com) reviewed 2018-06-07 14:00:12 +00:00
lib/kredits.js
raucao (Migrated from github.com) commented 2018-06-07 14:00:12 +00:00
Copy Link
Copy Source

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:38:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Noice!

Noice!
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#49