kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Rename healthcheck to PreflightChecker #49

Merged
bumi merged 2 commits from preflight-check into master 2018-06-07 14:39:08 +00:00
Conversation 2 Commits 2 Files Changed 2 +4 -4
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5215b60021 - Show all commits

4
lib/kredits.js
View File

@@ -1,7 +1,7 @@
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
const ethers = require('ethers');
const RSVP = require('rsvp');
const PreflightChecker = require('./utils/preflight_checker');
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
const Preflight = require('./utils/preflight');
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
const ABIS = {
Contributors: require('./abis/Contributors.json'),
@@ -98,7 +98,7 @@ class Kredits {
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
}
preflightChecks() {
return new PreflightChecker(this).check();
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
return new Preflight(this).check();
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
}
}
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.

4
lib/utils/preflight_checker.js → lib/utils/preflight.js
View File

@@ -1,4 +1,4 @@
class PreflightChecker {
class Preflight {
constructor(kredits) {
this.kredits = kredits;
}
@@ -25,4 +25,4 @@ class PreflightChecker {
}
}
module.exports = PreflightChecker;
module.exports = Preflight;