kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Rename healthcheck to PreflightChecker #49

Merged
bumi merged 2 commits from preflight-check into master 2018-06-07 14:39:08 +00:00
Conversation 2 Commits 2 Files Changed 2 +5 -5
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/kredits.js
View File

@ -1,7 +1,7 @@
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
const ethers = require('ethers'); const ethers = require('ethers');
const RSVP = require('rsvp'); const RSVP = require('rsvp');
const Healthcheck = require('./utils/healthcheck'); const Preflight = require('./utils/preflight');
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
const ABIS = { const ABIS = {
Contributors: require('./abis/Contributors.json'), Contributors: require('./abis/Contributors.json'),
@ -97,8 +97,8 @@ class Kredits {
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
return this.contracts[name]; return this.contracts[name];
} }
healthcheck() { preflightChecks() {
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
return new Healthcheck(this).check(); return new Preflight(this).check();
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
} }
} }

raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.
raucao commented 2018-06-07 14:00:12 +00:00 (Migrated from github.com)
Review
Copy Link

Why not just Preflight.check() if there's a checker method in that module anyway? I think it would read/look a bit nicer.

Why not just `Preflight.check()` if there's a checker method in that module anyway? I think it would read/look a bit nicer.

4
lib/utils/healthcheck.js → lib/utils/preflight.js
View File

@ -1,4 +1,4 @@
class Healthcheck { class Preflight {
constructor(kredits) { constructor(kredits) {
this.kredits = kredits; this.kredits = kredits;
} }
@ -25,4 +25,4 @@ class Healthcheck {
} }
} }
module.exports = Healthcheck; module.exports = Preflight;