kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Add balance when loading contributor #67

Merged
bumi merged 2 commits from feature/contributor-balance-1 into master 2019-04-03 18:22:51 +00:00
Conversation 5 Commits 2 Files Changed 3
+19 -4
bumi commented 2019-04-03 11:57:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This is a regression introduced by the latest contract updates.
Now we return the balance again when loading contributor data.

This is a regression introduced by the latest contract updates. Now we return the balance again when loading contributor data.
raucao commented 2019-04-03 12:35:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Which balance though? Kredits that have been withdrawn, or kredits that have been earned? (I'd prefer the latter.)

Which balance though? Kredits that have been withdrawn, or kredits that have been earned? (I'd prefer the latter.)
bumi commented 2019-04-03 12:39:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

this PR only brings back the functionality that we had before. It returns the ERC20 kredits balance of the user.

Though I am wondering if we should rather load the balances (kredits and contribution) in the client/kredits-web. Would keep the contract code also smaller and less coupled.

this PR only brings back the functionality that we had before. It returns the ERC20 kredits balance of the user. Though I am wondering if we should rather load the balances (kredits and contribution) in the client/kredits-web. Would keep the contract code also smaller and less coupled.
raucao commented 2019-04-03 12:42:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Though I am wondering if we should rather load the balances (kredits and contribution) in the client/kredits-web. Would keep the contract code also smaller and less coupled.

But it also increases the amount of HTTP requests for every loading of the app. Not sure which one is better.

> Though I am wondering if we should rather load the balances (kredits and contribution) in the client/kredits-web. Would keep the contract code also smaller and less coupled. But it also increases the amount of HTTP requests for every loading of the app. Not sure which one is better.
bumi commented 2019-04-03 12:48:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

yep, that's why I made this PR.

yep, that's why I made this PR.
raucao commented 2019-04-03 18:22:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

It werks! 🎉

It werks! :tada:
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
 ipfs
rsk
scaling
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#67