3.4.1

Fix warnings from express session

integrations/github.js

@@ -197,7 +197,12 @@ module.exports = async function(robot, kredits) {
       }
     };
 
-    robot.router.use(session({ secret: process.env.KREDITS_SESSION_SECRET || 'grant' }));
+    robot.router.use(session({
+      secret: process.env.KREDITS_SESSION_SECRET || 'grant',
+      resave: false,
+      saveUninitialized: false
+    }));
+
     robot.router.use('/kredits/signup', grant(grantConfig));
 
     robot.router.get('/kredits/signup/github', async (req, res) => {
@@ -214,8 +219,9 @@ module.exports = async function(robot, kredits) {
         res.status(400).json({});
         return;
       }
+      let githubResponse;
       try {
-        const githubResponse = await fetch('https://api.github.com/user', {
+        githubResponse = await fetch('https://api.github.com/user', {
           headers: {
             'Accept': 'application/vnd.github.v3+json',
             'Authorization': `token ${accessToken}`

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "hubot-kredits",
-  "version": "3.4.0",
+  "version": "3.4.1",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "hubot-kredits",
-  "version": "3.4.0",
+  "version": "3.4.1",
   "description": "Kosmos Kredits functionality for chat bots",
   "main": "index.js",
   "scripts": {