kredits/hubot-kredits
9
0
Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Create contributions instead of proposals #27

Merged
raucao merged 5 commits from feature/26-contributions into master 2019-04-08 13:01:08 +00:00
Conversation 8 Commits 5 Files Changed 4 +62 -44
raucao commented 2019-04-05 18:08:18 +00:00 (Migrated from github.com)
Copy Link

Also watch for contributions added and log them.

closes #26

Also watch for contributions added and log them. closes #26
bumi commented 2019-04-05 22:44:05 +00:00 (Migrated from github.com)
Copy Link

related to the potential noce issue: https://github.com/ethers-io/ethers.js/issues/319

related to the potential noce issue: https://github.com/ethers-io/ethers.js/issues/319
raucao commented 2019-04-06 10:01:00 +00:00 (Migrated from github.com)
Copy Link

I think this is ready to merge, so we can start using it with the new contracts.

I opened #28 for fixing the actual nonce issue.

I think this is ready to merge, so we can start using it with the new contracts. I opened #28 for fixing the actual nonce issue.
bumi commented 2019-04-06 11:36:35 +00:00 (Migrated from github.com)
Copy Link

but that "fix" does not block the http request?

but that "fix" does not block the http request?
raucao commented 2019-04-06 13:09:06 +00:00 (Migrated from github.com)
Copy Link

Nope, see the lines where I changed it to not wait for the promise to resolve.

Nope, see the lines where I changed it to not wait for the promise to resolve.
bumi commented 2019-04-06 13:27:41 +00:00 (Migrated from github.com)
Copy Link

was wondering because of the await before... all that JS magic... 💥

was wondering because of the await before... all that JS magic... :boom:
raucao commented 2019-04-06 13:30:42 +00:00 (Migrated from github.com)
Copy Link

There's no await for the handler function before returning the 200. That was wrapped in a .then function, which I removed. For example:

dcbce66796/integrations/github.js (L173-L174)

There's no `await` for the handler function before returning the 200. That was wrapped in a `.then` function, which I removed. For example: https://github.com/67P/hubot-kredits/blob/dcbce66796669c96d931a70f0f2e3ba52437af31/integrations/github.js#L173-L174
bumi (Migrated from github.com) approved these changes 2019-04-06 13:31:11 +00:00
bumi (Migrated from github.com) left a comment
Copy Link

the scheduler needs to go back, then let's merge it and work on #28

the scheduler needs to go back, then let's merge it and work on #28
integrations/mediawiki.js
bumi (Migrated from github.com) commented 2019-04-06 13:28:53 +00:00
Copy Link

I think you accidentally the cron.schedule

I think you accidentally the `cron.schedule`
raucao commented 2019-04-08 13:00:49 +00:00 (Migrated from github.com)
Copy Link

Oops, I missed that comment.

Oops, I missed that comment.
raucao added the
kredits-2
 label 2025-01-23 21:25:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/hubot-kredits#27
No description provided.
Delete Branch "feature/26-contributions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?