Add ENV var for custom DAO address #43

2019-08-27T10:19:52Z

raucao commented

2019-08-27 10:19:52 +00:00

(Migrated from github.com)

This makes it much easier to test hubot-kredits with local development chains.

bumi (Migrated from github.com) reviewed 2019-08-27 10:35:09 +00:00

index.js

bumi (Migrated from github.com) commented

2019-08-27 10:35:05 +00:00

we currently default already to open.aragonpm.eth https://github.com/67P/kredits-contracts/blob/master/lib/contracts/kernel.js#L9 (and: https://github.com/67P/kredits-contracts/blob/master/arapp.json#L37)

so we should not need to set this here.
With the new aragon CLI version we also should be able to default to open.aragonpm.eth in all environments and no longer need to set this manually.

I'd either make this also configurable through an env variable or just ignore it let kredits-contracts use the default.

we currently default already to `open.aragonpm.eth` https://github.com/67P/kredits-contracts/blob/master/lib/contracts/kernel.js#L9 (and: https://github.com/67P/kredits-contracts/blob/master/arapp.json#L37) so we should not need to set this here. With the new aragon CLI version we also should be able to default to `open.aragonpm.eth` in all environments and no longer need to set this manually. I'd either make this also configurable through an env variable or just ignore it let kredits-contracts use the default.

raucao (Migrated from github.com) reviewed 2019-08-27 10:38:33 +00:00

index.js

raucao (Migrated from github.com) commented

2019-08-27 10:38:32 +00:00

Thx.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/hubot-kredits#43