kredits/hubot-kredits
9
0
Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Propose kredits for PR reviews #71

Merged
raucao merged 5 commits from feature/review-kredits into master 2025-02-10 10:57:45 +00:00
Conversation 3 Commits 5 Files Changed 6 +277 -133
raucao commented 2025-01-23 21:36:55 +00:00
Owner
Copy Link

Continued from https://gitea.kosmos.org/kredits/kredits-reviews

This fixes, updates, and improves the manual script to propose kredits for PR reviews on GitHub and Gitea.

I tested it with my local dev setup, creating kredits on the local test chain. It's currently a bit tricky, due to the IPFS lib being EOL, so I don't expect anyone to test locally for reviews.

I ran the script in production for the missing 2021 kredits, so you can see a live example: https://kredits.kosmos.org

If everyone's happy with that, I'll run it for the other years since then, 1 per year.

refs #65

Continued from https://gitea.kosmos.org/kredits/kredits-reviews This fixes, updates, and improves the manual script to propose kredits for PR reviews on GitHub and Gitea. I tested it with my local dev setup, creating kredits on the local test chain. It's currently a bit tricky, due to the IPFS lib being EOL, so I don't expect anyone to test locally for reviews. I ran the script in production for the missing 2021 kredits, so you can see a live example: https://kredits.kosmos.org If everyone's happy with that, I'll run it for the other years since then, 1 per year. refs #65
raucao added 2 commits 2025-01-23 21:36:56 +00:00
raucao added 1 commit 2025-01-26 21:07:25 +00:00
raucao added 1 commit 2025-02-09 08:58:05 +00:00 
* Improve the description to include number of PRs and start/end date
* Set the contribution date to 00:00 on the day after the end date
* Add a sub-kind to the details property so it's easy to identify
  reviews
raucao changed title from WIP: Propose kredits for PR reviews to Propose kredits for PR reviews 2025-02-09 08:58:27 +00:00
raucao requested review from bumi 2025-02-09 08:59:56 +00:00
raucao requested review from galfert 2025-02-09 08:59:56 +00:00
raucao added the
kredits-2
 label 2025-02-09 09:00:00 +00:00
raucao requested review from slvrbckt 2025-02-09 09:02:10 +00:00
raucao added 1 commit 2025-02-09 09:19:14 +00:00
raucao requested review from greg 2025-02-09 09:21:25 +00:00
slvrbckt reviewed 2025-02-10 10:24:35 +00:00
package.json
@ -13,6 +13,7 @@
"dependencies": {
"@ethersproject/experimental": "5.7.0",
"@kredits/contracts": "^7.3.0",
"axios": "^1.7.9",
slvrbckt commented 2025-02-10 10:24:35 +00:00
Owner
Copy Link

Any particular reason for switching from the built in fetch to axios?

Any particular reason for switching from the built in fetch to axios?
raucao commented 2025-02-10 10:30:55 +00:00
Author
Owner
Copy Link

Just because that's what @galfert's code was using (at the time), and I didn't want to spend time on refactoring something that works. I'd rather move the whole thing away from hubot and npm modules eventually.

Just because that's what @galfert's code was using (at the time), and I didn't want to spend time on refactoring something that works. I'd rather move the whole thing away from hubot and npm modules eventually.
👍 1
slvrbckt marked this conversation as resolved
slvrbckt approved these changes 2025-02-10 10:25:04 +00:00
slvrbckt left a comment
Owner
Copy Link

Had one question about axios out of curiosity, but otherwise LGTM! \o/

Had one question about axios out of curiosity, but otherwise LGTM! \o/
raucao commented 2025-02-10 10:57:41 +00:00
Author
Owner
Copy Link

@slvrbckt Thanks! I have generated the rest of the kredits proposals now.

@slvrbckt Thanks! I have generated the rest of the kredits proposals now.
👍 1
raucao merged commit 174bc24421 into master 2025-02-10 10:57:45 +00:00
raucao deleted branch feature/review-kredits 2025-02-10 10:57:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
galfert
greg
slvrbckt
Labels
Clear labels
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/hubot-kredits#71
No description provided.
Delete Branch "feature/review-kredits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?