Propose kredits for PR reviews #71

2025-01-23T21:36:55Z

raucao commented

2025-01-23 21:36:55 +00:00

Continued from https://gitea.kosmos.org/kredits/kredits-reviews

This fixes, updates, and improves the manual script to propose kredits for PR reviews on GitHub and Gitea.

I tested it with my local dev setup, creating kredits on the local test chain. It's currently a bit tricky, due to the IPFS lib being EOL, so I don't expect anyone to test locally for reviews.

I ran the script in production for the missing 2021 kredits, so you can see a live example: https://kredits.kosmos.org

If everyone's happy with that, I'll run it for the other years since then, 1 per year.

refs #65

Continued from https://gitea.kosmos.org/kredits/kredits-reviews This fixes, updates, and improves the manual script to propose kredits for PR reviews on GitHub and Gitea. I tested it with my local dev setup, creating kredits on the local test chain. It's currently a bit tricky, due to the IPFS lib being EOL, so I don't expect anyone to test locally for reviews. I ran the script in production for the missing 2021 kredits, so you can see a live example: https://kredits.kosmos.org If everyone's happy with that, I'll run it for the other years since then, 1 per year. refs #65

raucao added 2 commits 2025-01-23 21:36:56 +00:00

Update repos 82fb429f44

WIP Merge galfert's changes from the new repo 94dd9b5ef7

raucao referenced this pull request from kredits/kredits-reviews

2025-01-23 21:37:16 +00:00

WIP: Create Kredits contributions for reviews #1

raucao added 1 commit 2025-01-26 21:07:25 +00:00

WIP Adapt script to latest RSK kredits code c93ddaebee

raucao added 1 commit 2025-02-09 08:58:05 +00:00

Create contributions for reviews 5fd7e50893

* Improve the description to include number of PRs and start/end date
* Set the contribution date to 00:00 on the day after the end date
* Add a sub-kind to the details property so it's easy to identify
  reviews

raucao marked the pull request as ready for review 2025-02-09 08:58:27 +00:00

raucao requested review from bumi 2025-02-09 08:59:56 +00:00

raucao requested review from galfert 2025-02-09 08:59:56 +00:00

raucao added the kredits-2 label 2025-02-09 09:00:00 +00:00

raucao requested review from slvrbckt 2025-02-09 09:02:10 +00:00

raucao added 1 commit 2025-02-09 09:19:14 +00:00

Formatting, explicit async bd781e1937

raucao requested review from greg 2025-02-09 09:21:25 +00:00

slvrbckt reviewed 2025-02-10 10:24:35 +00:00

package.json

						
				@@ -13,6 +13,7 @@

				  "dependencies": {

				    "@ethersproject/experimental": "5.7.0",

				    "@kredits/contracts": "^7.3.0",

				    "axios": "^1.7.9",

slvrbckt commented

2025-02-10 10:24:35 +00:00

Any particular reason for switching from the built in fetch to axios?

raucao commented

2025-02-10 10:30:55 +00:00

Just because that's what @galfert's code was using (at the time), and I didn't want to spend time on refactoring something that works. I'd rather move the whole thing away from hubot and npm modules eventually.

👍 1

slvrbckt marked this conversation as resolved

slvrbckt approved these changes 2025-02-10 10:25:04 +00:00

slvrbckt left a comment

Had one question about axios out of curiosity, but otherwise LGTM! \o/