kredits/ipfs-pinner
9
1
Fork 0
Code Issues 2 Pull Requests 1 Actions Releases 9 Activity

Connect to Kosmos IPFS node on startup #5

Manually merged
greg merged 1 commits from feature/connect_to_kosmos_ipfs_node into master 2019-08-13 09:02:35 +00:00
Conversation 6 Commits 1 Files Changed 1
+16 -1
raucao commented 2019-08-13 08:09:30 +00:00
Owner
Copy Link
Copy Source

This ensures that the local IPFS node is always connected to a known Kosmos node before attempting to fetch documents. Vastly improves performance.

closes #4

This ensures that the local IPFS node is always connected to a known Kosmos node before attempting to fetch documents. Vastly improves performance. closes #4
raucao changed title from Connect to Kosmos IPFS node on start to Connect to Kosmos IPFS node on startup 2019-08-13 08:09:37 +00:00
greg commented 2019-08-13 09:02:17 +00:00
Owner
Copy Link
Copy Source

This works perfectly, nice

This works perfectly, nice
greg closed this pull request 2019-08-13 09:02:34 +00:00
raucao deleted branch feature/connect_to_kosmos_ipfs_node 2019-08-13 09:09:21 +00:00
bumi reviewed 2019-08-13 09:34:31 +00:00
index.js
bumi commented 2019-08-13 09:34:31 +00:00
Owner
Copy Link
Copy Source

connect already returns a promise. why the need for the wrapper function?

debug(`Connecting to known IPFS node`);
await ipfsApi.swarm.connect('/ip4/46.4.18.160/tcp/4001/ipfs/QmZ4Lpzhz8bafbTYvEMMCmrbrMM4JfyHDR23WbCSAd9bo7');
`connect` already returns a promise. why the need for the wrapper function? ```js debug(`Connecting to known IPFS node`); await ipfsApi.swarm.connect('/ip4/46.4.18.160/tcp/4001/ipfs/QmZ4Lpzhz8bafbTYvEMMCmrbrMM4JfyHDR23WbCSAd9bo7'); ```
bumi commented 2019-08-13 09:34:44 +00:00
Owner
Copy Link
Copy Source

👍

:+1:
raucao reviewed 2019-08-13 10:37:28 +00:00
index.js
raucao commented 2019-08-13 10:37:28 +00:00
Author
Owner
Copy Link
Copy Source

I followed the API docs, and they say something different. Did you test this?

I followed the API docs, and they say something different. Did you test this?
bumi reviewed 2019-08-13 10:48:00 +00:00
index.js
bumi commented 2019-08-13 10:48:00 +00:00
Owner
Copy Link
Copy Source

yes,
we also use it in the kredits-contracts ipfs class

yes, we also use it in the kredits-contracts ipfs class
raucao reviewed 2019-08-13 11:24:35 +00:00
index.js
raucao commented 2019-08-13 11:24:35 +00:00
Author
Owner
Copy Link
Copy Source

Damn docs. Thanks. :(

Damn docs. Thanks. :(
raucao added the feature label 2023-04-26 14:01:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels feature
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/ipfs-pinner#5