kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Don't resolve promises after rejecting them

Browse Source
This commit was merged in pull request #7.
This commit is contained in:
galfert
2017-05-03 11:53:21 +02:00
parent 969ef8d1ed
commit 642015700e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/services/kredits.js
+3 -3
View File
@@ -54,7 +54,7 @@ export default Ember.Service.extend({
getValueFromContract(contractMethod, ...args) { getValueFromContract(contractMethod, ...args) {
return new Ember.RSVP.Promise((resolve, reject) => { return new Ember.RSVP.Promise((resolve, reject) => {
this.get('kreditsContract')[contractMethod](...args, (err, data) => { this.get('kreditsContract')[contractMethod](...args, (err, data) => {
if (err) { reject(err); } if (err) { reject(err); return; }
resolve(data); resolve(data);
}); });
}); });
@@ -132,7 +132,7 @@ export default Ember.Service.extend({
Ember.Logger.debug('[kredits] vote for', proposalId); Ember.Logger.debug('[kredits] vote for', proposalId);
return new Ember.RSVP.Promise((resolve, reject) => { return new Ember.RSVP.Promise((resolve, reject) => {
this.get('kreditsContract').vote(proposalId, (err, data) => { this.get('kreditsContract').vote(proposalId, (err, data) => {
if (err) { reject(err); } if (err) { reject(err); return; }
Ember.Logger.debug('[kredits] vote response', data); Ember.Logger.debug('[kredits] vote response', data);
resolve(data); resolve(data);
}); });
@@ -156,7 +156,7 @@ export default Ember.Service.extend({
contributor.set('ipfsHash', ipfsHash); contributor.set('ipfsHash', ipfsHash);
console.debug('ADD', address, name, ipfsHash, isCore, id); console.debug('ADD', address, name, ipfsHash, isCore, id);
this.get('kreditsContract').addContributor(address, name, ipfsHash, isCore, id, (err, data) => { this.get('kreditsContract').addContributor(address, name, ipfsHash, isCore, id, (err, data) => {
if (err) { reject(err); } if (err) { reject(err); return; }
Ember.Logger.debug('[kredits] add contributor response', data); Ember.Logger.debug('[kredits] add contributor response', data);
resolve(contributor); resolve(contributor);
}); });