kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Merge pull request #212 from 67P/bugfix/load_contributor

Browse Source 
Fix dashboard hanging when loading app from contributor URL
This commit was merged in pull request #212.
This commit is contained in:
Râu Cao
2023-01-20 17:29:05 +08:00
committed by GitHub
parent d069fa02ab fe3816501c
commit dad56a7b31
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/routes/dashboard/contributors/show.js
+7 -1
View File
@@ -8,7 +8,13 @@ export default Route.extend({
contributors: alias('kredits.contributors'),
model (params) {
return this.contributors.findBy('id', params.id);
const contributor = this.contributors.findBy('id', params.id);
if (contributor) {
return contributor;
} else {
return this.kredits.fetchContributor(params.id);
}
},
setupController (controller, model) {
app/services/kredits.js
+6
View File
@@ -274,6 +274,12 @@ export default Service.extend({
});
},
async fetchContributor (id) {
console.debug(`[kredits] Fetching contributor from the network`);
return this.kredits.Contributor.getById(id)
.then(data => this.loadContributorFromData(data))
},
fetchContributors () {
console.debug(`[kredits] Fetching all contributors from the network`);
return this.kredits.Contributor.all()