kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Fix some linter errors and warnings

Browse Source
This commit is contained in:
Râu Cao
2022-10-06 12:29:57 +02:00
parent 19553b9777
commit fb66bd4f0d
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/components/add-contribution/component.js
+1 -1
View File
@@ -1,6 +1,6 @@
import Component from '@ember/component'; import Component from '@ember/component';
import { computed } from '@ember/object'; import { computed } from '@ember/object';
import { alias, and, notEmpty } from '@ember/object/computed'; import { and, notEmpty } from '@ember/object/computed';
import { assign } from '@ember/polyfills'; import { assign } from '@ember/polyfills';
import moment from 'moment'; import moment from 'moment';
import { inject as service } from '@ember/service'; import { inject as service } from '@ember/service';
app/utils/group-by.js
+2 -3
View File
@@ -2,7 +2,6 @@
// Code from https://github.com/HeroicEric/ember-group-by (MIT licensed) // Code from https://github.com/HeroicEric/ember-group-by (MIT licensed)
// //
import { A } from '@ember/array'; import { A } from '@ember/array';
import { get } from '@ember/object';
import { isPresent } from '@ember/utils'; import { isPresent } from '@ember/utils';
export default function groupBy (collection, property) { export default function groupBy (collection, property) {
@@ -11,11 +10,11 @@ export default function groupBy (collection, property) {
if (items) { if (items) {
items.forEach(function(item) { items.forEach(function(item) {
let value = get(item, property); let value = item[property];
let group = groups.findBy('value', value); let group = groups.findBy('value', value);
if (isPresent(group)) { if (isPresent(group)) {
get(group, 'items').push(item); group.items.push(item);
} else { } else {
group = { property: property, value: value, items: [item] }; group = { property: property, value: value, items: [item] };
groups.push(group); groups.push(group);
tests/integration/components/contribution-list/component-test.js
-2
View File
@@ -19,8 +19,6 @@ module('Integration | Component | contribution-list', function(hooks) {
let kredits = this.owner.lookup('service:kredits'); let kredits = this.owner.lookup('service:kredits');
kredits.set('contributors', contributors); kredits.set('contributors', contributors);
debugger;
this.set('fixtures', contributions); this.set('fixtures', contributions);
await render(hbs`{{contribution-list contributions=fixtures showQuickFilter=true}}`); await render(hbs`{{contribution-list contributions=fixtures showQuickFilter=true}}`);