kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Improve account connect/loading, check network #154

Merged
raucao merged 4 commits from feature/sign_in into master 2019-09-10 14:48:56 +00:00
Conversation 6 Commits 4 Files Changed 7
+62 -32
raucao commented 2019-09-04 16:54:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source
  • Sign in button to connect account later
  • Only use user wallet on app startup if it's already open/connected
  • Check required network before using user provider

closes #82

* Sign in button to connect account later * Only use user wallet on app startup if it's already open/connected * Check required network before using user provider closes #82
galfert (Migrated from github.com) reviewed 2019-09-04 16:54:24 +00:00
fsmanuel (Migrated from github.com) reviewed 2019-09-04 16:54:24 +00:00
haythemsellami (Migrated from github.com) reviewed 2019-09-04 16:54:24 +00:00
bumi (Migrated from github.com) reviewed 2019-09-05 07:04:40 +00:00
app/services/kredits.js
@@ -126,3 +125,4 @@
} else {
instantiateWithoutAccount();
}
}
bumi (Migrated from github.com) commented 2019-09-05 07:04:18 +00:00
Copy Link
Copy Source

thinking out loud:
we set requireSupportedNetwork = false in environment.js:85 (if WEB3_PROVIDER_URL is set)
and if it is not false we check if the network is in this list: https://github.com/67P/kredits-contracts/blob/master/lib/kredits.js#L87

thinking out loud: we set `requireSupportedNetwork = false` in environment.js:85 (if WEB3_PROVIDER_URL is set) and if it is not false we check if the network is in this list: https://github.com/67P/kredits-contracts/blob/master/lib/kredits.js#L87
raucao (Migrated from github.com) reviewed 2019-09-05 08:00:24 +00:00
app/services/kredits.js
@@ -126,3 +125,4 @@
} else {
instantiateWithoutAccount();
}
}
raucao (Migrated from github.com) commented 2019-09-05 08:00:24 +00:00
Copy Link
Copy Source

Yes, happy to review a future PR with that change! This PR is only about requiring the only currently available network, so that the current web app does the right thing.

Edit: actually, it's mostly about signing in after having loaded the app. The network requirement is the smallest part of it.

Yes, happy to review a future PR with that change! This PR is only about requiring the only currently available network, so that the current web app does the right thing. Edit: actually, it's mostly about signing in after having loaded the app. The network requirement is the smallest part of it.
gregkare commented 2019-09-10 14:32:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Tried this locally, works as advertised, LGTM! 👍

Tried this locally, works as advertised, LGTM! 👍
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
fsmanuel
haythemsellami
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#154
Delete Branch "feature/sign_in"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?