Add support for Zoom display name in profiles #156

2019-09-18T07:37:14Z

raucao commented

2019-09-18 07:37:14 +00:00

(Migrated from github.com)

Currently depends on an unreleased version of kredits-contracts (which also fixes the broken profile updates).

Currently depends on an unreleased version of `kredits-contracts` (which also fixes the broken profile updates).

galfert (Migrated from github.com) reviewed 2019-09-18 09:07:01 +00:00

app/controllers/contributors/new.js

						
				@@ -13,3 +11,3 @@

				                 .then(() => this.transitionToRoute('index'))

				      return this.kredits.addContributor(contributor);

				    }

galfert (Migrated from github.com) commented

2019-09-18 09:07:01 +00:00

Does this stay on the form page now, or is the transition happening somewhere else when editing or creating a new contributor?

raucao (Migrated from github.com) reviewed 2019-09-18 09:16:48 +00:00

app/controllers/contributors/new.js

						
				@@ -13,3 +11,3 @@

				                 .then(() => this.transitionToRoute('index'))

				      return this.kredits.addContributor(contributor);

				    }

raucao (Migrated from github.com) commented

2019-09-18 09:16:48 +00:00

Yes, I moved it to the component:

https://github.com/67P/kredits-web/pull/156/files#diff-05b2a32d1311a3737ec444f68955ccedR81

Yes, I moved it to the component: https://github.com/67P/kredits-web/pull/156/files#diff-05b2a32d1311a3737ec444f68955ccedR81

bumi commented

2019-09-20 09:22:16 +00:00

(Migrated from github.com)

I've updated the package.json to use the released kredits-contracts v5.5.0
but if i do an npm install there are loads of changes in the package-lock file (some lodash changes, camelcase version change, etc.) which I did not want to push.
Could you push an updated package-lock?

I've updated the package.json to use the released kredits-contracts v5.5.0 but if i do an `npm install` there are loads of changes in the package-lock file (some lodash changes, camelcase version change, etc.) which I did not want to push. Could you push an updated package-lock?

raucao commented

2019-09-20 21:46:45 +00:00

(Migrated from github.com)

@bumi OK, cool. I just ran npm install and only got the kredits-contracts change.

@bumi OK, cool. I just ran `npm install` and only got the `kredits-contracts` change.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#156