kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Add support for Zoom display name in profiles #156

Merged
raucao merged 8 commits from feature/profile_zoom into master 2019-09-20 21:51:35 +00:00
Conversation 4 Commits 8 Files Changed 14
+174 -105
raucao commented 2019-09-18 07:37:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Currently depends on an unreleased version of kredits-contracts (which also fixes the broken profile updates).

Currently depends on an unreleased version of `kredits-contracts` (which also fixes the broken profile updates).
galfert (Migrated from github.com) reviewed 2019-09-18 09:07:01 +00:00
app/controllers/contributors/new.js
@@ -13,3 +11,3 @@
.then(() => this.transitionToRoute('index'))
return this.kredits.addContributor(contributor);
}
galfert (Migrated from github.com) commented 2019-09-18 09:07:01 +00:00
Copy Link
Copy Source

Does this stay on the form page now, or is the transition happening somewhere else when editing or creating a new contributor?

Does this stay on the form page now, or is the transition happening somewhere else when editing or creating a new contributor?
raucao (Migrated from github.com) reviewed 2019-09-18 09:16:48 +00:00
app/controllers/contributors/new.js
@@ -13,3 +11,3 @@
.then(() => this.transitionToRoute('index'))
return this.kredits.addContributor(contributor);
}
raucao (Migrated from github.com) commented 2019-09-18 09:16:48 +00:00
Copy Link
Copy Source

Yes, I moved it to the component:

https://github.com/67P/kredits-web/pull/156/files#diff-05b2a32d1311a3737ec444f68955ccedR81

Yes, I moved it to the component: https://github.com/67P/kredits-web/pull/156/files#diff-05b2a32d1311a3737ec444f68955ccedR81
bumi commented 2019-09-20 09:22:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I've updated the package.json to use the released kredits-contracts v5.5.0
but if i do an npm install there are loads of changes in the package-lock file (some lodash changes, camelcase version change, etc.) which I did not want to push.
Could you push an updated package-lock?

I've updated the package.json to use the released kredits-contracts v5.5.0 but if i do an `npm install` there are loads of changes in the package-lock file (some lodash changes, camelcase version change, etc.) which I did not want to push. Could you push an updated package-lock?
raucao commented 2019-09-20 21:46:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi OK, cool. I just ran npm install and only got the kredits-contracts change.

@bumi OK, cool. I just ran `npm install` and only got the `kredits-contracts` change.
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#156
Delete Branch "feature/profile_zoom"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?