kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Add confirmed-in component, show ETA for proposed reimbursements #210

Merged
raucao merged 11 commits from feature/confirmation-eta into master 2023-01-15 04:36:43 +00:00
Conversation 4 Commits 11 Files Changed 14
+211 -80
raucao commented 2023-01-11 06:21:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Adds a generic component for showing confirmation ETAs for any item, and adds the ETA to proposed reimbursements in the UI.

Also adds an event listener for new blocks, which updates the currentBlock number, so that all models, as well as the UI, can auto-update.

Screenshot from 2023-01-11 14-18-50

Adds a generic component for showing confirmation ETAs for any item, and adds the ETA to proposed reimbursements in the UI. Also adds an event listener for new blocks, which updates the `currentBlock` number, so that all models, as well as the UI, can auto-update. ![Screenshot from 2023-01-11 14-18-50](https://user-images.githubusercontent.com/842/211732255-44671f5d-7b67-4cc8-8e3e-d5dc7b42e677.png)
galfert (Migrated from github.com) reviewed 2023-01-11 06:21:58 +00:00
fsmanuel (Migrated from github.com) reviewed 2023-01-11 06:21:58 +00:00
bumi (Migrated from github.com) approved these changes 2023-01-13 20:34:42 +00:00
bumi (Migrated from github.com) left a comment
Copy Link
Copy Source

could not test it, but looks good.

could not test it, but looks good.
raucao commented 2023-01-14 04:16:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Cool, thanks.

What's the problem with testing? Should really just be npm start, without any wild dependencies (except for a local IPFS daemon/gateway running).

Btw, I opened #211 against this PR yesterday in order to avoid conflicts, so it would be good to merge that first.

Cool, thanks. What's the problem with testing? Should really just be `npm start`, without any wild dependencies (except for a local IPFS daemon/gateway running). Btw, I opened #211 against this PR yesterday in order to avoid conflicts, so it would be good to merge that first.
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
fsmanuel
bumi
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#210
Delete Branch "feature/confirmation-eta"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?