Expense list UI improvements #211

2023-01-13T07:44:18Z

raucao commented

2023-01-13 07:44:18 +00:00

(Migrated from github.com)

Add expense list component and DRY up the code
Add tags
Localize dates
Improve UI, esp. on small screens

Example of normal expense list (in reimbursement list):

Example of expense list in the reimbursement form:

* Add expense list component and DRY up the code * Add tags * Localize dates * Improve UI, esp. on small screens Example of normal expense list (in reimbursement list): ![Screenshot from 2023-01-13 15-41-38](https://user-images.githubusercontent.com/842/212265502-8cd4501b-1c52-4756-a7b8-107d8dac4996.png) Example of expense list in the reimbursement form: ![Screenshot from 2023-01-13 15-42-25](https://user-images.githubusercontent.com/842/212265581-07c657fd-42e6-4391-87f1-ef6aa076b29b.png)

fsmanuel (Migrated from github.com) approved these changes 2023-01-14 09:24:25 +00:00

app/components/add-reimbursement/template.hbs

				`@@ -44,26 +44,10 @@`

fsmanuel (Migrated from github.com) commented

2023-01-14 09:20:11 +00:00

Shouldn't it be

                  @deletable={{true}} />

Shouldn't it be ```suggestion @deletable={{true}} /> ```

raucao (Migrated from github.com) reviewed 2023-01-15 04:34:36 +00:00

app/components/add-reimbursement/template.hbs

				`@@ -44,26 +44,10 @@`

raucao (Migrated from github.com) commented

2023-01-15 04:34:35 +00:00

I figured it's truthy and looks nice. Weak opinion though. Let's go with your version!

bumi commented

2023-01-17 16:03:14 +00:00

(Migrated from github.com)

this is great! 💅

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#211