kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Expense list UI improvements #211

Merged
raucao merged 4 commits from feature/expense-list into feature/confirmation-eta 2023-01-15 04:35:17 +00:00
Conversation 3 Commits 4 Files Changed 9
+110 -68
raucao commented 2023-01-13 07:44:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source
  • Add expense list component and DRY up the code
  • Add tags
  • Localize dates
  • Improve UI, esp. on small screens

Example of normal expense list (in reimbursement list):

Screenshot from 2023-01-13 15-41-38

Example of expense list in the reimbursement form:

Screenshot from 2023-01-13 15-42-25

* Add expense list component and DRY up the code * Add tags * Localize dates * Improve UI, esp. on small screens Example of normal expense list (in reimbursement list): ![Screenshot from 2023-01-13 15-41-38](https://user-images.githubusercontent.com/842/212265502-8cd4501b-1c52-4756-a7b8-107d8dac4996.png) Example of expense list in the reimbursement form: ![Screenshot from 2023-01-13 15-42-25](https://user-images.githubusercontent.com/842/212265581-07c657fd-42e6-4391-87f1-ef6aa076b29b.png)
fsmanuel (Migrated from github.com) approved these changes 2023-01-14 09:24:25 +00:00
app/components/add-reimbursement/template.hbs
@@ -44,26 +44,10 @@
fsmanuel (Migrated from github.com) commented 2023-01-14 09:20:11 +00:00
Copy Link
Copy Source

Shouldn't it be

                  @deletable={{true}} />
Shouldn't it be ```suggestion @deletable={{true}} /> ```
raucao (Migrated from github.com) reviewed 2023-01-15 04:34:36 +00:00
app/components/add-reimbursement/template.hbs
@@ -44,26 +44,10 @@
raucao (Migrated from github.com) commented 2023-01-15 04:34:35 +00:00
Copy Link
Copy Source

I figured it's truthy and looks nice. Weak opinion though. Let's go with your version!

I figured it's truthy and looks nice. Weak opinion though. Let's go with your version!
bumi commented 2023-01-17 16:03:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

this is great! 💅

this is great! 💅
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#211
Delete Branch "feature/expense-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?