kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Wallet unlock check not working anymore #64

New Issue
Closed
opened 2018-05-07 12:00:38 +00:00 by raucao · 4 comments
raucao commented 2018-05-07 12:00:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

In master, checking for an unlocked metamask wallet is currently broken: when you have Metamask enabled, and are on Kovan, but it's still locked, the app will just break with an exception saying it can't find the Contributors contract address in the registry.

In master, checking for an unlocked metamask wallet is currently broken: when you have Metamask enabled, and are on Kovan, but it's still locked, the app will just break with an exception saying it can't find the Contributors contract address in the registry.
fsmanuel commented 2018-06-12 22:47:35 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I'll look into that tomorrow/the day after:

  • The page should load without any wallet/metamask
  • The page should load with locked wallet/metamask
  • Make sure Loading indicator works #60
I'll look into that tomorrow/the day after: - [x] The page should load without any wallet/metamask - [x] The page should load with locked wallet/metamask - [ ] Make sure Loading indicator works #60
🎉 2
bumi commented 2018-06-13 09:41:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

slightly related is #61

slightly related is #61
bumi commented 2018-06-14 13:05:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

have a look at #67 first! it seems it solves some problem there...

have a look at #67 first! it seems it solves some problem there...
fsmanuel commented 2018-06-14 15:55:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I'm closing this as it is fixed by #67

I'm closing this as it is fixed by #67
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#64
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?