kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Update contracts, Ethereum/IPFS configs #65

Merged
raucao merged 3 commits from feature/switch_to_infura into master 2018-06-07 14:37:18 +00:00
Conversation 7 Commits 3 Files Changed 4
+4271 -4228
raucao commented 2018-06-07 11:34:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source
  • Use our new IPFS node
  • Switch from our own Parity to Infura in prod
  • Use contracts from npm
* Use our new IPFS node * Switch from our own Parity to Infura in prod * Use contracts from npm
bumi commented 2018-06-07 13:45:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

looks good.
did you test it without metamask? I have #61 open which is kinda related.

but in anycase this looks good and I will merge it.

looks good. did you test it without metamask? I have #61 open which is kinda related. but in anycase this looks good and I will merge it.
bumi (Migrated from github.com) reviewed 2018-06-07 13:48:27 +00:00
config/environment.js
bumi (Migrated from github.com) commented 2018-06-07 13:48:27 +00:00
Copy Link
Copy Source

actually I am not sure about this one. by default we run the local ganache network as network ID 100.
This change requires to always provide that network ID for development with a local network.
maybe we can add some npm scripts for that?
npm run local npm run kovan or something similar?

actually I am not sure about this one. by default we run the local ganache network as network ID 100. This change requires to always provide that network ID for development with a local network. maybe we can add some npm scripts for that? `npm run local` `npm run kovan` or something similar?
raucao (Migrated from github.com) reviewed 2018-06-07 14:03:48 +00:00
config/environment.js
raucao (Migrated from github.com) commented 2018-06-07 14:03:47 +00:00
Copy Link
Copy Source

The reason for this is that the default is to not develop contracts, when developing the Web UI, so one shouldn't have to deal with ganache and have to use minimal seed data by default. Scripts would be nice, but I don't think it should be part of the same PR.

The reason for this is that the default is to not develop contracts, when developing the Web UI, so one shouldn't have to deal with ganache and have to use minimal seed data by default. Scripts would be nice, but I don't think it should be part of the same PR.
raucao commented 2018-06-07 14:05:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

did you test it without metamask? I have #61 open which is kinda related.

Things are quite broken for me in both master and this one, when not logged in to a metamask account. The init and loading stuff broke at some point since I last wrote any code for kredits-web. So it's also broken in this PR/branch.

Edit: meaning there's no loading indicator, And I often have a race condition, where I have to load the page twice, because the first load does literally nothing, with no console log whatsoever. And our alert about opening the wallet seems to be gone.

> did you test it without metamask? I have #61 open which is kinda related. Things are quite broken for me in both master and this one, when not logged in to a metamask account. The init and loading stuff broke at some point since I last wrote any code for kredits-web. So it's also broken in this PR/branch. Edit: meaning there's no loading indicator, And I often have a race condition, where I have to load the page twice, because the first load does literally nothing, with no console log whatsoever. And our alert about opening the wallet seems to be gone.
bumi commented 2018-06-07 14:56:04 +00:00 (Migrated from github.com)
Copy Link
Copy Source

actually it seems to work well for me with:
NETWORK_ID=100 WEB3_PROVIDER_URL=http://localhost:7545 ember s

running the app without metamask using my local network

actually it seems to work well for me with: `NETWORK_ID=100 WEB3_PROVIDER_URL=http://localhost:7545 ember s` running the app without metamask using my local network
raucao commented 2018-06-07 15:56:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

So it's broken when using a real node. Maybe that helps with debugging.

So it's broken when using a real node. Maybe that helps with debugging.
bumi commented 2018-06-08 10:17:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

you mean no metamask and default settings meaning kovan network and contract addresses from the kredits-contracts package?

you mean no metamask and default settings meaning kovan network and contract addresses from the kredits-contracts package?
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#65
Delete Branch "feature/switch_to_infura"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?