kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Submit contributions via form #119

Merged
raucao merged 13 commits from feature/118-contribution_form into master 2019-05-29 07:49:16 +00:00
Conversation 7 Commits 13 Files Changed 21
+381 -62
raucao commented 2019-05-23 10:20:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

closes #118, #74

closes #118, #74
raucao commented 2019-05-23 10:50:11 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@galfert @fsmanuel For some reason the contribution list component doesn't update to show the newly created contribution, which is pushed to the collection. I don't know why, because it looks to me as if all things are done correctly in regards to the computed properties. Maybe you have an idea?

(The item is definitely part of the kredits service's collection when going back to index.)

Edit: same thing happens when adding contributors and is already the case in master.

@galfert @fsmanuel For some reason the contribution list component doesn't update to show the newly created contribution, which is pushed to the collection. I don't know why, because it looks to me as if all things are done correctly in regards to the computed properties. Maybe you have an idea? (The item is definitely part of the kredits service's collection when going back to index.) Edit: same thing happens when adding contributors and is already the case in master.
raucao commented 2019-05-23 12:56:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Just FYI: this is good to go, and contains quite some style improvements besides the actual feature.

Just FYI: this is good to go, and contains quite some style improvements besides the actual feature.
galfert (Migrated from github.com) requested changes 2019-05-28 14:23:58 +00:00
galfert (Migrated from github.com) left a comment
Copy Link
Copy Source

For some reason the contribution list component doesn't update to show the newly created contribution, which is pushed to the collection. I don't know why, because it looks to me as if all things are done correctly in regards to the computed properties. Maybe you have an idea?

For me it actually showed the new contribution in the unconfirmed list right after i was redirected back to the index.

But when I wanted to veto the same contribution, I got this error:

Screenshot 2019-05-28 at 16 08 28

After reloading the page, I was able to veto the contribution just fine.

Edit: After adding a contribution and getting redirected to back to the index, the contribution is shown on the bottom of the "Latest contributions" list. After a reload, the contribution is shown at the top of the list.

> For some reason the contribution list component doesn't update to show the newly created contribution, which is pushed to the collection. I don't know why, because it looks to me as if all things are done correctly in regards to the computed properties. Maybe you have an idea? For me it actually showed the new contribution in the unconfirmed list right after i was redirected back to the index. But when I wanted to veto the same contribution, I got this error: ![Screenshot 2019-05-28 at 16 08 28](https://user-images.githubusercontent.com/843/58485710-d44c6580-8164-11e9-964e-06ec63d93ce8.png) After reloading the page, I was able to veto the contribution just fine. Edit: After adding a contribution and getting redirected to back to the index, the contribution is shown on the bottom of the "Latest contributions" list. After a reload, the contribution is shown at the top of the list.
app/components/add-contribution/component.js
@@ -0,0 +1,70 @@
import Component from '@ember/component';
galfert (Migrated from github.com) commented 2019-05-28 14:17:39 +00:00
Copy Link
Copy Source

I don't think the reset and scroll is necessary, because the save method itself transitions back to the index.

I don't think the reset and scroll is necessary, because the `save` method itself transitions back to the index.
app/components/add-contributor/component.js
@@ -61,14 +60,14 @@ export default Component.extend({
this.save(contributor).then(() => {
this.reset();
galfert (Migrated from github.com) commented 2019-05-28 14:19:36 +00:00
Copy Link
Copy Source

Same as above, the reset and scrolling is not necessary. I guess that's still from when the form was on the index page.

Same as above, the reset and scrolling is not necessary. I guess that's still from when the form was on the index page.
raucao commented 2019-05-28 14:30:17 +00:00 (Migrated from github.com)
Copy Link
Copy Source

But when I wanted to veto the same contribution, I got this error:

You cannot veto something that hasn't been created yet. As for me the contributions don't show up, I can't properly design the template for pending data at the moment. :/

> But when I wanted to veto the same contribution, I got this error: You cannot veto something that hasn't been created yet. As for me the contributions don't show up, I can't properly design the template for pending data at the moment. :/
galfert commented 2019-05-28 20:05:23 +00:00 (Migrated from github.com)
Copy Link
Copy Source

You cannot veto something that hasn't been created yet. As for me the contributions don't show up, I can't properly design the template for pending data at the moment. :/

Then lets create an issue for it at least.

> You cannot veto something that hasn't been created yet. As for me the contributions don't show up, I can't properly design the template for pending data at the moment. :/ Then lets create an issue for it at least.
galfert (Migrated from github.com) approved these changes 2019-05-28 20:05:32 +00:00
raucao commented 2019-05-29 07:48:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

https://github.com/67P/kredits-web/issues/120

https://github.com/67P/kredits-web/issues/120
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#119
Delete Branch "feature/118-contribution_form"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?