kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Update contributor profiles #123

Merged
raucao merged 2 commits from feature/122-edit_contributors into master 2019-06-01 23:56:17 +00:00
Conversation 6 Commits 2 Files Changed 11
+163 -68
raucao commented 2019-05-29 14:19:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source
  • Adds a new page for updating profiles
  • Refactors the add-contributor component to allow for updating existing contributors
  • Adds input labels to the contributor form and improves placeholders
  • Adds event handlers for all contract contributor changes and uses them for updating the UI

closes #122

Caveat: Updating the address is actually not possible with the update-profile contract method, so it will just ignore address changes for now. I think updating both address and profile at once is too risky anyway, so it should be a different form/view/action.

* Adds a new page for updating profiles * Refactors the add-contributor component to allow for updating existing contributors * Adds input labels to the contributor form and improves placeholders * Adds event handlers for all contract contributor changes and uses them for updating the UI closes #122 Caveat: Updating the address is actually not possible with the update-profile contract method, so it will just ignore address changes for now. I think updating both address and profile at once is too risky anyway, so it should be a different form/view/action.
galfert (Migrated from github.com) reviewed 2019-05-29 14:19:58 +00:00
fsmanuel (Migrated from github.com) reviewed 2019-05-29 14:19:58 +00:00
raucao commented 2019-05-31 13:58:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Would be nice if someone could have a quick look at this. Should be very easy to test.

Would be nice if someone could have a quick look at this. Should be very easy to test.
bumi (Migrated from github.com) approved these changes 2019-06-01 10:21:42 +00:00
bumi (Migrated from github.com) left a comment
Copy Link
Copy Source

utACK - looks good to me.

there seems to be currently a bug in the contracts wrapper. when updating accounts the old account data does not get deleted. profile data gets only merged.

utACK - looks good to me. there seems to be currently a bug in the contracts wrapper. when updating accounts the old account data does not get deleted. profile data gets only merged.
app/routes/contributors/edit.js
@@ -0,0 +22,4 @@
github_username: model.github_username,
github_uid: model.github_uid,
gitea_username: model.gitea_username,
wiki_username: model.wiki_username
bumi (Migrated from github.com) commented 2019-06-01 10:16:57 +00:00
Copy Link
Copy Source

do you think we can use the accounts array here already? with adding more services we at some point would want to directly add entries to the accounts array.

do you think we can use the `accounts` array here already? with adding more services we at some point would want to directly add entries to the accounts array.
raucao (Migrated from github.com) reviewed 2019-06-01 11:01:01 +00:00
app/routes/contributors/edit.js
@@ -0,0 +22,4 @@
github_username: model.github_username,
github_uid: model.github_uid,
gitea_username: model.gitea_username,
wiki_username: model.wiki_username
raucao (Migrated from github.com) commented 2019-06-01 11:01:01 +00:00
Copy Link
Copy Source

That should be a separate PR, as it requires quite some changes in the code.

That should be a separate PR, as it requires quite some changes in the code.
galfert commented 2019-06-01 20:54:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Code looks all good to me.

Code looks all good to me.
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
fsmanuel
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#123
Delete Branch "feature/122-edit_contributors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?