Add "give kredits" button to contributor profiles #180

2019-12-12T16:36:13Z

raucao commented

2019-12-12 16:36:13 +00:00

(Migrated from github.com)

Includes support for query params for submitting new contributions (contributor ID, kind, amount).

closes #172
refs #40

Includes support for query params for submitting new contributions (contributor ID, kind, amount). closes #172 refs #40

galfert (Migrated from github.com) approved these changes 2019-12-13 15:49:46 +00:00

galfert (Migrated from github.com) left a comment

Looks and works fine 👍

Just left a comment for a little improvement.

Looks and works fine 👍 Just left a comment for a little improvement.

app/components/add-contribution/component.js

						
				@@ -24,19 +24,17 @@ export default Component.extend({

				  init () {

galfert (Migrated from github.com) commented

2019-12-13 15:39:27 +00:00

Instead of merging attributes manually, you can use Ember's assign method to replace the whole if-else block.

import { assign } from '@ember/polyfills';
...
this.set('attributes', assign({}, this.defaultAttr, this.attributes));

Instead of merging attributes manually, you can use Ember's `assign` method to replace the whole `if-else` block. ```js import { assign } from '@ember/polyfills'; ... this.set('attributes', assign({}, this.defaultAttr, this.attributes)); ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#180

				`@@ -24,19 +24,17 @@ export default Component.extend({`
				`init () {`