Improve data sync #190

2020-05-31T10:39:36Z

raucao commented

2020-05-31 10:39:36 +00:00

(Migrated from github.com)

This introduces ember-concurrency for managing concurrent tasks, as well as task queues, etc.. The new changes improve the fetching of data in several ways:

If data has been loaded from cache, fetch new contributions and update unconfirmed ones (to see if they were vetoed e.g.)
Never fetch contributions again if they are confirmed and cached
After syncing new and unconfirmed contributions, fetch/cache all missing past contributions

After merging this one, we should soon improve the dashboard further by not showing all contributions in the list by default, and also asking the user before fetching the entire history. When we have UI for that, we can then also show sync progress somewhere.

This introduces [ember-concurrency](http://ember-concurrency.com/docs/introduction) for managing concurrent tasks, as well as task queues, etc.. The new changes improve the fetching of data in several ways: * If data has been loaded from cache, fetch new contributions and update unconfirmed ones (to see if they were vetoed e.g.) * Never fetch contributions again if they are confirmed and cached * After syncing new and unconfirmed contributions, fetch/cache all missing past contributions After merging this one, we should soon improve the dashboard further by not showing all contributions in the list by default, and also asking the user before fetching the entire history. When we have UI for that, we can then also show sync progress somewhere.

galfert (Migrated from github.com) approved these changes 2020-06-01 23:47:37 +00:00

galfert (Migrated from github.com) left a comment

Code looks good. Just had some super minor comment.
Tests worked also as promised.
Great work! 👍

Code looks good. Just had some super minor comment. Tests worked also as promised. Great work! 👍

app/components/contributor-list/component.js

						
				@@ -2,12 +2,10 @@ import Component from '@ember/component';

				import { inject as service } from '@ember/service';

				export default Component.extend({

				  tagName: '',

galfert (Migrated from github.com) commented

2020-06-01 22:29:54 +00:00

Since Octane, components don't have a tag like div by default anymore. So this is not necessary.

Since Octane, components don't have a tag like `div` by default anymore. So this is not necessary.

raucao (Migrated from github.com) reviewed 2020-06-02 08:54:57 +00:00

app/components/contributor-list/component.js

						
				@@ -2,12 +2,10 @@ import Component from '@ember/component';

				import { inject as service } from '@ember/service';

				export default Component.extend({

				  tagName: '',