kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Refactor contributor model #30

Merged
fsmanuel merged 4 commits from refactor/models into master 2018-04-07 17:22:34 +00:00
Conversation 5 Commits 4 Files Changed 13
+360 -264
fsmanuel commented 2018-04-06 12:14:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
bumi (Migrated from github.com) approved these changes 2018-04-07 12:39:47 +00:00
app/components/add-contributor/component.js
bumi (Migrated from github.com) commented 2018-04-07 12:33:36 +00:00
Copy Link
Copy Source

the contributor will not be visible in the list (as any balance will be 0).
What other feedback can we give the user to indicate that the contributor was added?

the contributor will not be visible in the list (as any balance will be 0). What other feedback can we give the user to indicate that the contributor was added?
raucao (Migrated from github.com) reviewed 2018-04-07 12:44:33 +00:00
app/components/add-contributor/component.js
raucao (Migrated from github.com) commented 2018-04-07 12:44:33 +00:00
Copy Link
Copy Source

Just a window.alert() would do for starters.

Just a `window.alert()` would do for starters.
fsmanuel (Migrated from github.com) reviewed 2018-04-07 13:31:56 +00:00
app/components/add-contributor/component.js
fsmanuel (Migrated from github.com) commented 2018-04-07 13:31:56 +00:00
Copy Link
Copy Source

Done.

Done.
fsmanuel commented 2018-04-08 13:00:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@skddc can you delete the branch? It says it is locked: https://github.com/67P/kredits-web/branches

@skddc can you delete the branch? It says it is locked: https://github.com/67P/kredits-web/branches
raucao commented 2018-04-08 13:15:02 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Sorry, that's from preventing force-pushes. Please just don't force-push in the future, when it's a branch of an open pull request, and it is not an emergency change. You, or the person merging, can squash or rebase the history before it lands in master. It's easy to just close a PR and ref it from a new one, with the changed history. Thanks.

Sorry, that's from preventing force-pushes. Please just don't force-push in the future, when it's a branch of an open pull request, and it is not an emergency change. You, or the person merging, can squash or rebase the history before it lands in `master`. It's easy to just close a PR and ref it from a new one, with the changed history. Thanks.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
raucao
fsmanuel
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#30
Delete Branch "refactor/models"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?