Fix for missing metamask/web3 calls #54

Closed
bumi wants to merge 4 commits from fix-with-missing-metamask into master
bumi commented 2018-04-16 20:49:07 +00:00 (Migrated from github.com)

If there is no web3 available then we do not have a signer, only read operations can be executed.

If there is no web3 available then we do not have a signer, only read operations can be executed.
bumi (Migrated from github.com) reviewed 2018-04-16 21:36:42 +00:00
@@ -8,1 +10,4 @@
} else {
return value;
}
},
bumi (Migrated from github.com) commented 2018-04-16 21:36:42 +00:00

I sneaked in this, which is actually not related. :(

I sneaked in this, which is actually not related. :(
raucao commented 2018-04-17 11:32:19 +00:00 (Migrated from github.com)

I get the following error in a browser without MetaMask:

Error initializing Kredits Error: Registry address not found; invalid network?
I get the following error in a browser without MetaMask: Error initializing Kredits Error: Registry address not found; invalid network?
bumi commented 2018-04-17 12:18:40 +00:00 (Migrated from github.com)

that's probably because in the config we use parity.kosmos.org as ethereum node and have network ID 42 configured as default. but our contracts are currently not deployed there.

that's probably because in the config we use parity.kosmos.org as ethereum node and have network ID 42 configured as default. but our contracts are currently not deployed there.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.