kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Batch voting #73

Closed
raucao wants to merge 5 commits from feature/batch-voting-2 into master
pull from: feature/batch-voting-2
merge into: kredits:master
Conversation 6 Commits 5 Files Changed 13
+914 -1478
raucao commented 2018-06-15 08:42:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Continuation of #62. Rebased branch on master, refactored form styles, updated deps.

Apparently the deployed contract on Kovan doesn't support batch voting yet, or has a bug related to it. I can do transactions for it, but they fail with a contract error.

Continuation of #62. Rebased branch on master, refactored form styles, updated deps. Apparently the deployed contract on Kovan doesn't support batch voting yet, or has a bug related to it. I can do transactions for it, but they fail with a contract error.
fsmanuel commented 2018-06-15 10:01:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

👍

👍
bumi commented 2018-06-22 13:02:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@fsmanuel as you worked on it, can you review the latest status and merge it.
The kovan contract will at some point support it, nothing (ok, maybe updating kredits-contracts) needs to change for that here.

@fsmanuel as you worked on it, can you review the latest status and merge it. The kovan contract will at some point support it, nothing (ok, maybe updating kredits-contracts) needs to change for that here.
raucao commented 2018-06-22 20:28:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Thing is, we're kind of close to not having any voting at all, and then single vetos will be much more common than batch ones. So I think this branch would need to revert using the +1 buttons as selectors and maybe add actual option fields for rows that one can select.

Thing is, we're kind of close to not having any voting at all, and then single vetos will be much more common than batch ones. So I think this branch would need to revert using the +1 buttons as selectors and maybe add actual option fields for rows that one can select.
fsmanuel commented 2018-06-25 17:13:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@skddc I'm not sure if I get what you say. Do you want real (ugly) checkboxes? We can change the appearance of the +1 buttons to whatever we want. We just need to talk about how they should look like.
Anyway let me know if I should rebase and continue working on it or how we proceed.

@skddc I'm not sure if I get what you say. Do you want real (ugly) checkboxes? We can change the appearance of the +1 buttons to whatever we want. We just need to talk about how they should look like. Anyway let me know if I should rebase and continue working on it or how we proceed.
raucao commented 2018-06-25 18:58:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

No, I want to be able to use the +1 buttons for a single veto/vote, instead of having to press one button, then scroll down, then press another button. The checkboxes can be unstyled and ugly (although I have already designed nice checkboxes; see adding a contributor e.g.).

It's an alpha app, and this is all going to change considerably rather soon anyway. I think we can live with some ugly checkboxes, when that doesn't impact UX negatively at the moment.

So, with that in mind, rebase or not depends on what's easier in terms of adapting code. Could be easier to just copy some bits to a new branch off of master.

No, I want to be able to use the +1 buttons for a single veto/vote, instead of having to press one button, then scroll down, then press another button. The checkboxes can be unstyled and ugly (although I have already designed nice checkboxes; see adding a contributor e.g.). It's an alpha app, and this is all going to change considerably rather soon anyway. I think we can live with some ugly checkboxes, when that doesn't impact UX negatively at the moment. So, with that in mind, rebase or not depends on what's easier in terms of adapting code. Could be easier to just copy some bits to a new branch off of master.
raucao commented 2019-03-27 11:45:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing this one for now, because we won't have voting on contributions in the beginning and the UI has to change for that everywhere.

Closing this one for now, because we won't have voting on contributions in the beginning and the UI has to change for that everywhere.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#73
Delete Branch "feature/batch-voting-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?