Compare commits
29 Commits
e7b3b72e2f
...
master
| Author | SHA1 | Date | |
|---|---|---|---|
|
20f63065ad
|
|||
|
39a7ec3595
|
|||
| 32dfa3a30f | |||
|
64ccc694d3
|
|||
|
87e2380ef6
|
|||
| 66c31b19f1 | |||
|
55aecbd699
|
|||
|
ccaa56b78f
|
|||
|
d30375707a
|
|||
|
53300b92f5
|
|||
|
c37f794eea
|
|||
|
4bc92bb7cc
|
|||
|
9f48d7b264
|
|||
| bbd3bf47c6 | |||
|
59e3d91071
|
|||
|
348b721876
|
|||
|
3d982a6a7c
|
|||
|
0af9d9f16d
|
|||
|
a0f132ec64
|
|||
|
925f26ae5d
|
|||
|
58bb8831f3
|
|||
|
585837cae7
|
|||
|
42c5282844
|
|||
|
8a0603c65e
|
|||
|
8e3187f38d
|
|||
|
a73e5cda6a
|
|||
|
0212fa359b
|
|||
|
8c58a76030
|
|||
|
a10f87290a
|
@@ -1,6 +1,6 @@
|
|||||||
# Project Status: Marco
|
# Project Status: Marco
|
||||||
|
|
||||||
**Last Updated:** Mon Jan 26 2026
|
**Last Updated:** Tue Jan 27 2026
|
||||||
|
|
||||||
## Project Context
|
## Project Context
|
||||||
|
|
||||||
@@ -15,7 +15,6 @@ We are building **Marco**, a decentralized maps application using **Ember.js** (
|
|||||||
- Implemented a hybrid click handler:
|
- Implemented a hybrid click handler:
|
||||||
- Detects clicks on visual vector tiles.
|
- Detects clicks on visual vector tiles.
|
||||||
- Falls back to fetching authoritative data from an **Overpass API** service.
|
- Falls back to fetching authoritative data from an **Overpass API** service.
|
||||||
- Uses a **heuristic** (distance + type matching) to link visual clicks to API results (handling data desynchronization).
|
|
||||||
- **Logic Upgrade:** Map intelligently detects if _any_ sidebar/pane is open and handles outside clicks to close them instead of initiating new searches.
|
- **Logic Upgrade:** Map intelligently detects if _any_ sidebar/pane is open and handles outside clicks to close them instead of initiating new searches.
|
||||||
- **Optimization:** Added **10px hit tolerance** for easier tapping on mobile devices.
|
- **Optimization:** Added **10px hit tolerance** for easier tapping on mobile devices.
|
||||||
- **Visuals:** Increased bookmark marker size (Radius 9px) and added a subtle drop shadow.
|
- **Visuals:** Increased bookmark marker size (Radius 9px) and added a subtle drop shadow.
|
||||||
@@ -58,6 +57,7 @@ We are building **Marco**, a decentralized maps application using **Ember.js** (
|
|||||||
- `osm.js`: Fetches nearby POIs from Overpass API.
|
- `osm.js`: Fetches nearby POIs from Overpass API.
|
||||||
- **Configurable:** Now supports dynamic API endpoints via `SettingsService`.
|
- **Configurable:** Now supports dynamic API endpoints via `SettingsService`.
|
||||||
- **Reliability:** Implemented `fetchWithRetry` to handle HTTP 504/502/503 timeouts and 429 rate limits, in addition to network errors.
|
- **Reliability:** Implemented `fetchWithRetry` to handle HTTP 504/502/503 timeouts and 429 rate limits, in addition to network errors.
|
||||||
|
- **Caching:** Implemented in-memory cache for repeated `getNearbyPois` requests (same lat/lon/radius) to enable instant "Back" navigation.
|
||||||
- `settings.js`: Manages user preferences (currently Overpass API provider) persisted to `localStorage`.
|
- `settings.js`: Manages user preferences (currently Overpass API provider) persisted to `localStorage`.
|
||||||
- **UI Components:**
|
- **UI Components:**
|
||||||
- `places-sidebar.gjs`: Displays a list of nearby POIs.
|
- `places-sidebar.gjs`: Displays a list of nearby POIs.
|
||||||
@@ -73,45 +73,62 @@ We are building **Marco**, a decentralized maps application using **Ember.js** (
|
|||||||
- **Geo Utils:**
|
- **Geo Utils:**
|
||||||
- `app/utils/geo.js`: Haversine distance calculations.
|
- `app/utils/geo.js`: Haversine distance calculations.
|
||||||
- `app/utils/geohash-coverage.js`: Logic to calculate required 4-char geohash prefixes for a given bounding box.
|
- `app/utils/geohash-coverage.js`: Logic to calculate required 4-char geohash prefixes for a given bounding box.
|
||||||
|
- **Format Utils:**
|
||||||
|
- `app/utils/format-text.js` & `humanize-osm-tag` helper: Standardized logic (Title Case, space replacement) for displaying OSM tags like `guest_house` -> "Guest House".
|
||||||
- **Build & DevOps:**
|
- **Build & DevOps:**
|
||||||
- **Icon Generation:** Added `build:icons` script using `magick` and `rsvg-convert` to automate PNG generation from SVG.
|
- **Icon Generation:** Added `build:icons` script using `magick` and `rsvg-convert` to automate PNG generation from SVG.
|
||||||
- **Dependencies:** Documented system requirements (ImageMagick, librsvg) in `README.md`.
|
- **Dependencies:** Documented system requirements (ImageMagick, librsvg) in `README.md`.
|
||||||
- **Ember CLI:** Added as dev dependency to support generator commands.
|
- **Ember CLI:** Added as dev dependency to support generator commands.
|
||||||
- **License:** Added AGPLv3 license.
|
- **License:** Added AGPLv3 license.
|
||||||
|
|
||||||
### 4. Routing & Data Optimization
|
### 4. Routing & Architecture (Refactored)
|
||||||
|
|
||||||
- **Explicit URLs:** Implemented routing support for specific OSM entities via `/place/osm:node:<id>` and `/place/osm:way:<id>`, distinguishing them from local bookmarks (ULIDs).
|
- **URL-Driven Architecture:** Moved from service-based state to proper route-based state management.
|
||||||
|
- `/search?lat=...&lon=...&q=...`: Displays search results list.
|
||||||
|
- `/place/:place_id`: Displays details for a specific place (OSM POI or Bookmark).
|
||||||
|
- **Heuristic Navigation:** The `search` route implements "visual click matching" logic. If a search yields a direct match (exact name or very close proximity), it automatically redirects to the `/place/` route, skipping the list view.
|
||||||
|
- **Back Button Support:** Browser history works correctly. Navigating "Back" from a place returns to the cached search results instantly without network requests.
|
||||||
|
- **Explicit URLs:** Routes support specific OSM entities via `/place/osm:node:<id>` and `/place/osm:way:<id>`, distinguishing them from local bookmarks (ULIDs).
|
||||||
- **Smart Linking:** The `showPlaces` action intercepts search results and automatically resolves them to existing **Bookmarks** if a match is found (via `storage.findPlaceById`). This ensures the app navigates to the persistent Bookmark URL (ULID) and correctly reflects the "Saved" status in the UI instead of treating it as a new generic OSM place.
|
- **Smart Linking:** The `showPlaces` action intercepts search results and automatically resolves them to existing **Bookmarks** if a match is found (via `storage.findPlaceById`). This ensures the app navigates to the persistent Bookmark URL (ULID) and correctly reflects the "Saved" status in the UI instead of treating it as a new generic OSM place.
|
||||||
- **Data Normalization:** Refactored `OsmService` to return normalized objects (`osmTags`, `osmType`) for all queries. This ensures consistent data structures between fresh Overpass results and saved bookmarks throughout the app.
|
- **Data Normalization:** Refactored `OsmService` to return normalized objects (`osmTags`, `osmType`) for all queries. This ensures consistent data structures between fresh Overpass results and saved bookmarks throughout the app.
|
||||||
- **Performance:** Optimized navigation to prevent redundant network requests. Clicking a map pin passes the existing data object to the route, skipping the `model` hook (no re-fetch) while maintaining correct deep-linkable URLs via a custom `serialize` hook in `PlaceRoute`.
|
|
||||||
|
### 5. Creation & Editing Workflow
|
||||||
|
|
||||||
|
- **Create Place:**
|
||||||
|
- Implemented `/place/new` route for creating new private places.
|
||||||
|
- **UX:** Map displays a central crosshair for precise location selection.
|
||||||
|
- **Mobile Optimization:**
|
||||||
|
- Disabled map inertia (`kinetic: false`) to ensure the map stops exactly where the finger releases.
|
||||||
|
- `PlaceEditForm` conditionally disables autofocus on mobile screens (`<= 768px`) to prevent the onscreen keyboard from obscuring the map view immediately.
|
||||||
|
- Responsive crosshair sizing (48px desktop / 24px mobile).
|
||||||
|
- **Persistence:** Form data (Title, Description) and Map coordinates are securely saved to RemoteStorage via `storage.storePlace`.
|
||||||
|
|
||||||
## Current State
|
## Current State
|
||||||
|
|
||||||
- **Repo:** The app runs via `pnpm start`.
|
- **Repo:** The app runs via `pnpm start`.
|
||||||
- **Workflow:**
|
- **Workflow:**
|
||||||
1. User pans map -> `moveend` triggers `storage.loadPlacesInBounds`.
|
1. User pans map -> `moveend` triggers `storage.loadPlacesInBounds`.
|
||||||
2. User clicks map -> "Pulse" animation -> hybrid hit detection (Visual Tile vs Overpass).
|
2. User clicks map -> Route transition to `/search` -> "Pulse" animation -> hybrid hit detection (Visual Tile vs Overpass).
|
||||||
3. **Navigation:** Selected place is checked against bookmarks; if found, it uses the Bookmark object. Otherwise, it uses the OSM object.
|
3. **Navigation:**
|
||||||
|
- If direct match: Redirect to `/place/:id`.
|
||||||
|
- If multiple results: Show `/search` list view.
|
||||||
4. Sidebar displays details via `<PlaceDetails>` component (Bottom sheet on mobile).
|
4. Sidebar displays details via `<PlaceDetails>` component (Bottom sheet on mobile).
|
||||||
5. User clicks "Save Bookmark" -> Stores JSON in RemoteStorage.
|
5. **Creation:** User clicks "Create Place" -> Enters creation mode (crosshair) -> Positions map -> Enters details -> Save.
|
||||||
6. RemoteStorage change event -> Debounced reload updates the map reactive-ly.
|
6. **Persistence:** RemoteStorage change event -> Debounced reload updates the map reactive-ly.
|
||||||
7. **Editing:** User can edit the Title and Description of saved bookmarks via an "Edit" button in the details view.
|
7. **Editing:** User can edit the Title and Description of saved bookmarks via an "Edit" button in the details view.
|
||||||
8. **Settings:** User can change the Overpass API provider via the new Settings menu.
|
8. **Settings:** User can change the Overpass API provider via the new Settings menu.
|
||||||
|
|
||||||
## Files Currently in Focus
|
## Files Currently in Focus
|
||||||
|
|
||||||
- `app/styles/app.css`: Mobile CSS fixes (font sizes, control positioning).
|
- `app/components/map.gjs`
|
||||||
- `package.json`: New scripts and dependencies.
|
- `app/components/place-edit-form.gjs`
|
||||||
- `README.md`: Updated documentation.
|
- `app/templates/place/new.gjs`
|
||||||
|
|
||||||
## Next Steps & Pending Tasks
|
## Next Steps & Pending Tasks
|
||||||
|
|
||||||
1. **Mobile Polish:** Verify "Locate Me" animation on iOS Safari.
|
1. **Linting & Code Quality:** Fix remaining CSS errors and address unused variables/runloop usage.
|
||||||
2. **Collections/Lists:** Implement ability to organize bookmarks into lists/collections.
|
2. **Testing:** Add automated tests for the geohash coverage, retry logic, and new editing features.
|
||||||
3. **Linting & Code Quality:** Fix remaining CSS errors, remove inline styles in `map.gjs`, and address unused variables/runloop usage.
|
3. **Performance:** Monitor performance with large datasets (thousands of bookmarks).
|
||||||
4. **Performance:** Monitor performance with large datasets (thousands of bookmarks).
|
|
||||||
5. **Testing:** Add automated tests for the geohash coverage, retry logic, and new editing features.
|
|
||||||
|
|
||||||
## Technical Constraints
|
## Technical Constraints
|
||||||
|
|
||||||
|
|||||||
@@ -24,7 +24,7 @@ export default class AppHeaderComponent extends Component {
|
|||||||
<header class="app-header">
|
<header class="app-header">
|
||||||
<div class="header-left">
|
<div class="header-left">
|
||||||
<button
|
<button
|
||||||
class="icon-btn"
|
class="menu-btn btn-press"
|
||||||
type="button"
|
type="button"
|
||||||
aria-label="Menu"
|
aria-label="Menu"
|
||||||
{{on "click" @onToggleMenu}}
|
{{on "click" @onToggleMenu}}
|
||||||
@@ -36,7 +36,7 @@ export default class AppHeaderComponent extends Component {
|
|||||||
<div class="header-right">
|
<div class="header-right">
|
||||||
<div class="user-menu-container">
|
<div class="user-menu-container">
|
||||||
<button
|
<button
|
||||||
class="user-btn"
|
class="user-btn btn-press"
|
||||||
type="button"
|
type="button"
|
||||||
aria-label="User Menu"
|
aria-label="User Menu"
|
||||||
{{on "click" this.toggleUserMenu}}
|
{{on "click" this.toggleUserMenu}}
|
||||||
|
|||||||
@@ -15,6 +15,7 @@ import mapPin from 'feather-icons/dist/icons/map-pin.svg?raw';
|
|||||||
import menu from 'feather-icons/dist/icons/menu.svg?raw';
|
import menu from 'feather-icons/dist/icons/menu.svg?raw';
|
||||||
import navigation from 'feather-icons/dist/icons/navigation.svg?raw';
|
import navigation from 'feather-icons/dist/icons/navigation.svg?raw';
|
||||||
import phone from 'feather-icons/dist/icons/phone.svg?raw';
|
import phone from 'feather-icons/dist/icons/phone.svg?raw';
|
||||||
|
import plus from 'feather-icons/dist/icons/plus.svg?raw';
|
||||||
import server from 'feather-icons/dist/icons/server.svg?raw';
|
import server from 'feather-icons/dist/icons/server.svg?raw';
|
||||||
import settings from 'feather-icons/dist/icons/settings.svg?raw';
|
import settings from 'feather-icons/dist/icons/settings.svg?raw';
|
||||||
import target from 'feather-icons/dist/icons/target.svg?raw';
|
import target from 'feather-icons/dist/icons/target.svg?raw';
|
||||||
@@ -37,6 +38,7 @@ const ICONS = {
|
|||||||
menu,
|
menu,
|
||||||
navigation,
|
navigation,
|
||||||
phone,
|
phone,
|
||||||
|
plus,
|
||||||
server,
|
server,
|
||||||
settings,
|
settings,
|
||||||
target,
|
target,
|
||||||
|
|||||||
@@ -4,6 +4,8 @@ import { modifier } from 'ember-modifier';
|
|||||||
import 'ol/ol.css';
|
import 'ol/ol.css';
|
||||||
import Map from 'ol/Map.js';
|
import Map from 'ol/Map.js';
|
||||||
import { defaults as defaultControls, Control } from 'ol/control.js';
|
import { defaults as defaultControls, Control } from 'ol/control.js';
|
||||||
|
import { defaults as defaultInteractions, DragPan } from 'ol/interaction.js';
|
||||||
|
import Kinetic from 'ol/Kinetic.js';
|
||||||
import View from 'ol/View.js';
|
import View from 'ol/View.js';
|
||||||
import { fromLonLat, toLonLat, getPointResolution } from 'ol/proj.js';
|
import { fromLonLat, toLonLat, getPointResolution } from 'ol/proj.js';
|
||||||
import Overlay from 'ol/Overlay.js';
|
import Overlay from 'ol/Overlay.js';
|
||||||
@@ -15,13 +17,13 @@ import Point from 'ol/geom/Point.js';
|
|||||||
import Geolocation from 'ol/Geolocation.js';
|
import Geolocation from 'ol/Geolocation.js';
|
||||||
import { Style, Circle, Fill, Stroke } from 'ol/style.js';
|
import { Style, Circle, Fill, Stroke } from 'ol/style.js';
|
||||||
import { apply } from 'ol-mapbox-style';
|
import { apply } from 'ol-mapbox-style';
|
||||||
import { getDistance } from '../utils/geo';
|
|
||||||
|
|
||||||
export default class MapComponent extends Component {
|
export default class MapComponent extends Component {
|
||||||
@service osm;
|
@service osm;
|
||||||
@service storage;
|
@service storage;
|
||||||
@service mapUi;
|
@service mapUi;
|
||||||
@service router;
|
@service router;
|
||||||
|
@service settings;
|
||||||
|
|
||||||
mapInstance;
|
mapInstance;
|
||||||
bookmarkSource;
|
bookmarkSource;
|
||||||
@@ -29,6 +31,8 @@ export default class MapComponent extends Component {
|
|||||||
searchOverlayElement;
|
searchOverlayElement;
|
||||||
selectedPinOverlay;
|
selectedPinOverlay;
|
||||||
selectedPinElement;
|
selectedPinElement;
|
||||||
|
crosshairElement;
|
||||||
|
crosshairOverlay;
|
||||||
|
|
||||||
setupMap = modifier((element) => {
|
setupMap = modifier((element) => {
|
||||||
if (this.mapInstance) return;
|
if (this.mapInstance) return;
|
||||||
@@ -64,6 +68,7 @@ export default class MapComponent extends Component {
|
|||||||
// Default view settings
|
// Default view settings
|
||||||
let center = [14.21683569, 27.060114248];
|
let center = [14.21683569, 27.060114248];
|
||||||
let zoom = 2.661;
|
let zoom = 2.661;
|
||||||
|
let restoredFromStorage = false;
|
||||||
|
|
||||||
// Try to restore from localStorage
|
// Try to restore from localStorage
|
||||||
try {
|
try {
|
||||||
@@ -78,6 +83,7 @@ export default class MapComponent extends Component {
|
|||||||
) {
|
) {
|
||||||
center = parsed.center;
|
center = parsed.center;
|
||||||
zoom = parsed.zoom;
|
zoom = parsed.zoom;
|
||||||
|
restoredFromStorage = true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
@@ -95,10 +101,13 @@ export default class MapComponent extends Component {
|
|||||||
layers: [openfreemap, bookmarkLayer],
|
layers: [openfreemap, bookmarkLayer],
|
||||||
view: view,
|
view: view,
|
||||||
controls: defaultControls({
|
controls: defaultControls({
|
||||||
zoom: false,
|
zoom: true,
|
||||||
rotate: true,
|
rotate: true,
|
||||||
attribution: true,
|
attribution: true,
|
||||||
}),
|
}),
|
||||||
|
interactions: defaultInteractions({
|
||||||
|
dragPan: false, // Disable default DragPan to add a custom one
|
||||||
|
}),
|
||||||
});
|
});
|
||||||
|
|
||||||
apply(this.mapInstance, 'https://tiles.openfreemap.org/styles/liberty');
|
apply(this.mapInstance, 'https://tiles.openfreemap.org/styles/liberty');
|
||||||
@@ -113,18 +122,13 @@ export default class MapComponent extends Component {
|
|||||||
this.mapInstance.addOverlay(this.searchOverlay);
|
this.mapInstance.addOverlay(this.searchOverlay);
|
||||||
|
|
||||||
// Selected Pin Overlay (Red Marker)
|
// Selected Pin Overlay (Red Marker)
|
||||||
// We create the element in the template (or JS) and attach it.
|
|
||||||
// Using JS creation to ensure it's cleanly managed by OpenLayers
|
|
||||||
this.selectedPinElement = document.createElement('div');
|
this.selectedPinElement = document.createElement('div');
|
||||||
this.selectedPinElement.className = 'selected-pin-container';
|
this.selectedPinElement.className = 'selected-pin-container';
|
||||||
|
|
||||||
// Create the icon structure inside
|
// Create the icon structure inside
|
||||||
const pinIcon = document.createElement('div');
|
const pinIcon = document.createElement('div');
|
||||||
pinIcon.className = 'selected-pin';
|
pinIcon.className = 'selected-pin';
|
||||||
// We can't use the Glimmer <Icon> component easily inside a raw DOM element created here.
|
// Simple SVG for Map Pin
|
||||||
// So we'll inject the SVG string directly or mount it.
|
|
||||||
// Feather icons are globally available if we used the script, but we are using the module approach.
|
|
||||||
// Simple SVG for Map Pin:
|
|
||||||
pinIcon.innerHTML = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="currentColor" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M21 10c0 7-9 13-9 13s-9-6-9-13a9 9 0 0 1 18 0z"></path><circle cx="12" cy="10" r="3" style="fill: #b31412; stroke: none;"></circle></svg>`;
|
pinIcon.innerHTML = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="currentColor" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M21 10c0 7-9 13-9 13s-9-6-9-13a9 9 0 0 1 18 0z"></path><circle cx="12" cy="10" r="3" style="fill: #b31412; stroke: none;"></circle></svg>`;
|
||||||
|
|
||||||
const pinShadow = document.createElement('div');
|
const pinShadow = document.createElement('div');
|
||||||
@@ -135,11 +139,25 @@ export default class MapComponent extends Component {
|
|||||||
|
|
||||||
this.selectedPinOverlay = new Overlay({
|
this.selectedPinOverlay = new Overlay({
|
||||||
element: this.selectedPinElement,
|
element: this.selectedPinElement,
|
||||||
positioning: 'bottom-center', // Important: Pin tip is at the bottom
|
positioning: 'bottom-center', // Pin tip is at the bottom
|
||||||
stopEvent: false, // Let clicks pass through
|
stopEvent: false, // Let clicks pass through
|
||||||
});
|
});
|
||||||
this.mapInstance.addOverlay(this.selectedPinOverlay);
|
this.mapInstance.addOverlay(this.selectedPinOverlay);
|
||||||
|
|
||||||
|
// Crosshair Overlay (for Creating New Place)
|
||||||
|
this.crosshairElement = document.createElement('div');
|
||||||
|
this.crosshairElement.className = 'map-crosshair';
|
||||||
|
this.crosshairElement.innerHTML = `
|
||||||
|
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
|
||||||
|
<line x1="12" y1="5" x2="12" y2="19"></line>
|
||||||
|
<line x1="5" y1="12" x2="19" y2="12"></line>
|
||||||
|
</svg>
|
||||||
|
`;
|
||||||
|
element.appendChild(this.crosshairElement);
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
// Geolocation Pulse Overlay
|
// Geolocation Pulse Overlay
|
||||||
this.locationOverlayElement = document.createElement('div');
|
this.locationOverlayElement = document.createElement('div');
|
||||||
this.locationOverlayElement.className = 'search-pulse blue';
|
this.locationOverlayElement.className = 'search-pulse blue';
|
||||||
@@ -227,6 +245,7 @@ export default class MapComponent extends Component {
|
|||||||
const coordinates = geolocation.getPosition();
|
const coordinates = geolocation.getPosition();
|
||||||
const accuracyGeometry = geolocation.getAccuracyGeometry();
|
const accuracyGeometry = geolocation.getAccuracyGeometry();
|
||||||
const accuracy = geolocation.getAccuracy();
|
const accuracy = geolocation.getAccuracy();
|
||||||
|
console.debug('Geolocation change:', { coordinates, accuracy });
|
||||||
|
|
||||||
if (!coordinates) return;
|
if (!coordinates) return;
|
||||||
|
|
||||||
@@ -282,7 +301,7 @@ export default class MapComponent extends Component {
|
|||||||
};
|
};
|
||||||
|
|
||||||
if (targetResolution) {
|
if (targetResolution) {
|
||||||
const maxResolution = view.getResolutionForZoom(17); // Use 17 as safe max zoom for accuracy < 20m
|
const maxResolution = view.getResolutionForZoom(17);
|
||||||
viewOptions.resolution = Math.max(targetResolution, maxResolution);
|
viewOptions.resolution = Math.max(targetResolution, maxResolution);
|
||||||
} else {
|
} else {
|
||||||
viewOptions.zoom = 16;
|
viewOptions.zoom = 16;
|
||||||
@@ -291,7 +310,8 @@ export default class MapComponent extends Component {
|
|||||||
this.mapInstance.getView().animate(viewOptions);
|
this.mapInstance.getView().animate(viewOptions);
|
||||||
};
|
};
|
||||||
|
|
||||||
locateBtn.addEventListener('click', () => {
|
const startLocating = () => {
|
||||||
|
console.debug('Getting current geolocation...')
|
||||||
// 1. Clear any previous session
|
// 1. Clear any previous session
|
||||||
stopLocating();
|
stopLocating();
|
||||||
|
|
||||||
@@ -315,7 +335,9 @@ export default class MapComponent extends Component {
|
|||||||
locateTimeout = setTimeout(() => {
|
locateTimeout = setTimeout(() => {
|
||||||
stopLocating();
|
stopLocating();
|
||||||
}, 10000);
|
}, 10000);
|
||||||
});
|
};
|
||||||
|
|
||||||
|
locateBtn.addEventListener('click', startLocating);
|
||||||
|
|
||||||
const locateControl = new Control({
|
const locateControl = new Control({
|
||||||
element: locateElement,
|
element: locateElement,
|
||||||
@@ -324,6 +346,11 @@ export default class MapComponent extends Component {
|
|||||||
this.mapInstance.addLayer(geolocationLayer);
|
this.mapInstance.addLayer(geolocationLayer);
|
||||||
this.mapInstance.addControl(locateControl);
|
this.mapInstance.addControl(locateControl);
|
||||||
|
|
||||||
|
// Auto-locate on first visit (if not restored from storage and on home page)
|
||||||
|
if (!restoredFromStorage && this.router.currentRouteName === 'index') {
|
||||||
|
startLocating();
|
||||||
|
}
|
||||||
|
|
||||||
this.mapInstance.on('singleclick', this.handleMapClick);
|
this.mapInstance.on('singleclick', this.handleMapClick);
|
||||||
|
|
||||||
// Load places when map moves
|
// Load places when map moves
|
||||||
@@ -338,16 +365,41 @@ export default class MapComponent extends Component {
|
|||||||
this.mapInstance.getTarget().style.cursor = hit ? 'pointer' : '';
|
this.mapInstance.getTarget().style.cursor = hit ? 'pointer' : '';
|
||||||
});
|
});
|
||||||
|
|
||||||
// Load initial bookmarks
|
|
||||||
this.storage.rs.on('ready', () => {
|
this.storage.rs.on('ready', () => {
|
||||||
// Initial load based on current view
|
|
||||||
this.handleMapMove();
|
this.handleMapMove();
|
||||||
});
|
});
|
||||||
|
});
|
||||||
|
|
||||||
// Listen for remote storage changes
|
updateInteractions = modifier(() => {
|
||||||
// this.storage.rs.on('connected', () => {
|
if (!this.mapInstance) return;
|
||||||
// this.loadBookmarks();
|
|
||||||
// });
|
// Remove existing DragPan interactions
|
||||||
|
this.mapInstance.getInteractions().getArray().slice().forEach((interaction) => {
|
||||||
|
if (interaction instanceof DragPan) {
|
||||||
|
this.mapInstance.removeInteraction(interaction);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
// Add new DragPan with current setting
|
||||||
|
const kinetic = this.settings.mapKinetic
|
||||||
|
? new Kinetic(-0.005, 0.05, 100)
|
||||||
|
: false;
|
||||||
|
|
||||||
|
// Fix for "sticky" touches on mobile:
|
||||||
|
// If we're on mobile (width <= 768) AND using kinetic,
|
||||||
|
// we increase the minimum velocity required to trigger kinetic panning.
|
||||||
|
// This prevents slow drags from being interpreted as a "throw"
|
||||||
|
if (this.settings.mapKinetic && window.innerWidth <= 768) {
|
||||||
|
// Default minVelocity is 0.05. We bump it up significantly.
|
||||||
|
// This means the user has to really "flick" the map to get inertia.
|
||||||
|
kinetic.minVelocity_ = 0.25;
|
||||||
|
}
|
||||||
|
|
||||||
|
this.mapInstance.addInteraction(
|
||||||
|
new DragPan({
|
||||||
|
kinetic: kinetic,
|
||||||
|
})
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Track the selected place from the UI Service (Router -> Map)
|
// Track the selected place from the UI Service (Router -> Map)
|
||||||
@@ -416,12 +468,9 @@ export default class MapComponent extends Component {
|
|||||||
const offsetPixels = height * 0.25; // Distance from desired pin pos to map center
|
const offsetPixels = height * 0.25; // Distance from desired pin pos to map center
|
||||||
const offsetMapUnits = offsetPixels * resolution;
|
const offsetMapUnits = offsetPixels * resolution;
|
||||||
|
|
||||||
// Shift center SOUTH (decrease Y)
|
// Shift center SOUTH (decrease Y).
|
||||||
// Note: In Web Mercator (EPSG:3857), Y increases North.
|
// Note: In Web Mercator (EPSG:3857), Y increases North.
|
||||||
// So to look "lower", we decrease Y? No wait.
|
// To move the camera South (Lower Y), we subtract.
|
||||||
// If we move the camera South (decrease Y), the features move North (Up) on screen.
|
|
||||||
// We want the Pin (fixed lat/lon) to be Higher up on screen.
|
|
||||||
// So we must move the Camera South (Lower Y).
|
|
||||||
targetCenter = [coords[0], coords[1] - offsetMapUnits];
|
targetCenter = [coords[0], coords[1] - offsetMapUnits];
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -469,7 +518,6 @@ export default class MapComponent extends Component {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Re-fetch bookmarks when the version changes (triggered by parent action or service)
|
|
||||||
updateBookmarks = modifier(() => {
|
updateBookmarks = modifier(() => {
|
||||||
// Depend on the tracked storage.placesInView to automatically update when they change
|
// Depend on the tracked storage.placesInView to automatically update when they change
|
||||||
const places = this.storage.placesInView;
|
const places = this.storage.placesInView;
|
||||||
@@ -481,15 +529,10 @@ export default class MapComponent extends Component {
|
|||||||
if (!this.bookmarkSource) return;
|
if (!this.bookmarkSource) return;
|
||||||
|
|
||||||
if (!places || places.length === 0) {
|
if (!places || places.length === 0) {
|
||||||
// Fallback or explicit check if we have tracked property usage?
|
|
||||||
// The service updates 'placesInView'. We should probably use that if we want reactiveness.
|
|
||||||
places = this.storage.placesInView;
|
places = this.storage.placesInView;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Previously: const places = await this.storage.places.getPlaces();
|
|
||||||
// We no longer want to fetch everything blindly.
|
|
||||||
// We rely on 'placesInView' being updated by handleMapMove calling storage.loadPlacesInBounds.
|
// We rely on 'placesInView' being updated by handleMapMove calling storage.loadPlacesInBounds.
|
||||||
|
|
||||||
this.bookmarkSource.clear();
|
this.bookmarkSource.clear();
|
||||||
|
|
||||||
if (places && Array.isArray(places)) {
|
if (places && Array.isArray(places)) {
|
||||||
@@ -522,9 +565,109 @@ export default class MapComponent extends Component {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Sync the creation mode (Crosshair)
|
||||||
|
syncCreationMode = modifier(() => {
|
||||||
|
if (!this.crosshairElement || !this.mapInstance) return;
|
||||||
|
|
||||||
|
if (this.mapUi.isCreating) {
|
||||||
|
this.crosshairElement.classList.add('visible');
|
||||||
|
|
||||||
|
// If we have initial coordinates from the route (e.g. reload or link),
|
||||||
|
// we need to pan the map so those coordinates are UNDER the crosshair.
|
||||||
|
const coords = this.mapUi.creationCoordinates;
|
||||||
|
if (coords && coords.lat && coords.lon) {
|
||||||
|
// We only animate if the map center isn't already "roughly" correct.
|
||||||
|
const targetCoords = fromLonLat([coords.lon, coords.lat]);
|
||||||
|
this.animateToCrosshair(targetCoords);
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
this.crosshairElement.classList.remove('visible');
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
animateToCrosshair(targetCoords) {
|
||||||
|
if (!this.mapInstance || !this.crosshairElement) return;
|
||||||
|
|
||||||
|
// 1. Get current visual position of the crosshair
|
||||||
|
const mapRect = this.mapInstance.getTargetElement().getBoundingClientRect();
|
||||||
|
const crosshairRect = this.crosshairElement.getBoundingClientRect();
|
||||||
|
|
||||||
|
const crosshairPixelX =
|
||||||
|
crosshairRect.left + crosshairRect.width / 2 - mapRect.left;
|
||||||
|
const crosshairPixelY =
|
||||||
|
crosshairRect.top + crosshairRect.height / 2 - mapRect.top;
|
||||||
|
|
||||||
|
// 2. Get the center pixel of the map viewport
|
||||||
|
const size = this.mapInstance.getSize();
|
||||||
|
const mapCenterX = size[0] / 2;
|
||||||
|
const mapCenterY = size[1] / 2;
|
||||||
|
|
||||||
|
// 3. Calculate the offset (how far the crosshair is from the geometric center)
|
||||||
|
const offsetX = crosshairPixelX - mapCenterX;
|
||||||
|
const offsetY = crosshairPixelY - mapCenterY;
|
||||||
|
|
||||||
|
// 4. Calculate the new map center
|
||||||
|
// We want 'targetCoords' to be at [crosshairPixelX, crosshairPixelY].
|
||||||
|
// If we center the map on 'targetCoords', it will be at [mapCenterX, mapCenterY].
|
||||||
|
// So we need to shift the map center by the OPPOSITE of the offset.
|
||||||
|
const view = this.mapInstance.getView();
|
||||||
|
const resolution = view.getResolution();
|
||||||
|
|
||||||
|
const offsetMapUnitsX = offsetX * resolution;
|
||||||
|
const offsetMapUnitsY = -offsetY * resolution; // Y is inverted in pixel vs map coords
|
||||||
|
|
||||||
|
const targetX = targetCoords[0];
|
||||||
|
const targetY = targetCoords[1];
|
||||||
|
|
||||||
|
const newCenterX = targetX - offsetMapUnitsX;
|
||||||
|
const newCenterY = targetY - offsetMapUnitsY;
|
||||||
|
|
||||||
|
// Only animate if the difference is significant (avoid micro-jitters/loops)
|
||||||
|
const currentCenter = view.getCenter();
|
||||||
|
const dist = Math.sqrt(
|
||||||
|
Math.pow(currentCenter[0] - newCenterX, 2) +
|
||||||
|
Math.pow(currentCenter[1] - newCenterY, 2)
|
||||||
|
);
|
||||||
|
|
||||||
|
// 1 meter is approx 1 unit in Mercator near equator, varies by latitude.
|
||||||
|
// Resolution at zoom 18 is approx 0.6m/pixel.
|
||||||
|
// Let's use a small pixel threshold.
|
||||||
|
if (dist > resolution * 5) {
|
||||||
|
view.animate({
|
||||||
|
center: [newCenterX, newCenterY],
|
||||||
|
duration: 800,
|
||||||
|
easing: (t) => t * (2 - t), // Ease-out
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
handleMapMove = async () => {
|
handleMapMove = async () => {
|
||||||
if (!this.mapInstance) return;
|
if (!this.mapInstance) return;
|
||||||
|
|
||||||
|
// If in creation mode, update the coordinates in the service AND the URL
|
||||||
|
if (this.mapUi.isCreating) {
|
||||||
|
// Calculate coordinates under the crosshair element
|
||||||
|
// We need the pixel position of the crosshair relative to the map viewport
|
||||||
|
// The crosshair is positioned via CSS, so we can use getBoundingClientRect
|
||||||
|
const mapRect = this.mapInstance.getTargetElement().getBoundingClientRect();
|
||||||
|
const crosshairRect = this.crosshairElement.getBoundingClientRect();
|
||||||
|
|
||||||
|
const centerX = crosshairRect.left + crosshairRect.width / 2 - mapRect.left;
|
||||||
|
const centerY = crosshairRect.top + crosshairRect.height / 2 - mapRect.top;
|
||||||
|
|
||||||
|
const coordinate = this.mapInstance.getCoordinateFromPixel([centerX, centerY]);
|
||||||
|
const center = toLonLat(coordinate);
|
||||||
|
|
||||||
|
const lat = parseFloat(center[1].toFixed(6));
|
||||||
|
const lon = parseFloat(center[0].toFixed(6));
|
||||||
|
|
||||||
|
this.mapUi.updateCreationCoordinates(lat, lon);
|
||||||
|
|
||||||
|
// Update URL without triggering a full refresh
|
||||||
|
// We use replaceWith to avoid cluttering history
|
||||||
|
this.router.replaceWith('place.new', { queryParams: { lat, lon } });
|
||||||
|
}
|
||||||
|
|
||||||
const size = this.mapInstance.getSize();
|
const size = this.mapInstance.getSize();
|
||||||
const extent = this.mapInstance.getView().calculateExtent(size);
|
const extent = this.mapInstance.getView().calculateExtent(size);
|
||||||
const [minLon, minLat] = toLonLat([extent[0], extent[1]]);
|
const [minLon, minLat] = toLonLat([extent[0], extent[1]]);
|
||||||
@@ -579,7 +722,7 @@ export default class MapComponent extends Component {
|
|||||||
if (this.args.isSidebarOpen) {
|
if (this.args.isSidebarOpen) {
|
||||||
// If it's a bookmark, we allow "switching" to it even if sidebar is open
|
// If it's a bookmark, we allow "switching" to it even if sidebar is open
|
||||||
if (clickedBookmark) {
|
if (clickedBookmark) {
|
||||||
console.log(
|
console.debug(
|
||||||
'Clicked bookmark while sidebar open (switching):',
|
'Clicked bookmark while sidebar open (switching):',
|
||||||
clickedBookmark
|
clickedBookmark
|
||||||
);
|
);
|
||||||
@@ -596,11 +739,18 @@ export default class MapComponent extends Component {
|
|||||||
|
|
||||||
// Normal behavior (sidebar is closed)
|
// Normal behavior (sidebar is closed)
|
||||||
if (clickedBookmark) {
|
if (clickedBookmark) {
|
||||||
console.log('Clicked bookmark:', clickedBookmark);
|
console.debug('Clicked bookmark:', clickedBookmark);
|
||||||
this.router.transitionTo('place', clickedBookmark);
|
this.router.transitionTo('place', clickedBookmark);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Require Zoom >= 17 for generic map searches
|
||||||
|
// This prevents accidental searches when interacting with the map at a high level
|
||||||
|
const currentZoom = this.mapInstance.getView().getZoom();
|
||||||
|
if (currentZoom < 16) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
const coords = toLonLat(event.coordinate);
|
const coords = toLonLat(event.coordinate);
|
||||||
const [lon, lat] = coords;
|
const [lon, lat] = coords;
|
||||||
|
|
||||||
@@ -640,11 +790,13 @@ export default class MapComponent extends Component {
|
|||||||
|
|
||||||
<template>
|
<template>
|
||||||
<div
|
<div
|
||||||
class="map-container"
|
class="map-container {{if @isSidebarOpen 'sidebar-open'}}"
|
||||||
{{this.setupMap}}
|
{{this.setupMap}}
|
||||||
|
{{this.updateInteractions}}
|
||||||
{{this.updateBookmarks}}
|
{{this.updateBookmarks}}
|
||||||
{{this.updateSelectedPin}}
|
{{this.updateSelectedPin}}
|
||||||
{{this.syncPulse}}
|
{{this.syncPulse}}
|
||||||
|
{{this.syncCreationMode}}
|
||||||
></div>
|
></div>
|
||||||
</template>
|
</template>
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,20 +2,15 @@ import Component from '@glimmer/component';
|
|||||||
import { fn } from '@ember/helper';
|
import { fn } from '@ember/helper';
|
||||||
import { on } from '@ember/modifier';
|
import { on } from '@ember/modifier';
|
||||||
import { humanizeOsmTag } from '../utils/format-text';
|
import { humanizeOsmTag } from '../utils/format-text';
|
||||||
|
import { getLocalizedName } from '../utils/osm';
|
||||||
import Icon from '../components/icon';
|
import Icon from '../components/icon';
|
||||||
|
import PlaceEditForm from './place-edit-form';
|
||||||
|
|
||||||
import { tracked } from '@glimmer/tracking';
|
import { tracked } from '@glimmer/tracking';
|
||||||
import { action } from '@ember/object';
|
import { action } from '@ember/object';
|
||||||
|
|
||||||
export default class PlaceDetails extends Component {
|
export default class PlaceDetails extends Component {
|
||||||
@tracked isEditing = false;
|
@tracked isEditing = false;
|
||||||
@tracked editTitle = '';
|
|
||||||
@tracked editDescription = '';
|
|
||||||
|
|
||||||
constructor() {
|
|
||||||
super(...arguments);
|
|
||||||
this.resetEditFields();
|
|
||||||
}
|
|
||||||
|
|
||||||
get place() {
|
get place() {
|
||||||
return this.args.place || {};
|
return this.args.place || {};
|
||||||
@@ -28,22 +23,14 @@ export default class PlaceDetails extends Component {
|
|||||||
get name() {
|
get name() {
|
||||||
return (
|
return (
|
||||||
this.place.title ||
|
this.place.title ||
|
||||||
this.tags.name ||
|
getLocalizedName(this.tags) ||
|
||||||
this.tags['name:en'] ||
|
|
||||||
'Unnamed Place'
|
'Unnamed Place'
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@action
|
|
||||||
resetEditFields() {
|
|
||||||
this.editTitle = this.name;
|
|
||||||
this.editDescription = this.place.description || '';
|
|
||||||
}
|
|
||||||
|
|
||||||
@action
|
@action
|
||||||
startEditing() {
|
startEditing() {
|
||||||
if (!this.place.createdAt) return; // Only allow editing saved places
|
if (!this.place.createdAt) return; // Only allow editing saved places
|
||||||
this.resetEditFields();
|
|
||||||
this.isEditing = true;
|
this.isEditing = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -53,28 +40,16 @@ export default class PlaceDetails extends Component {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@action
|
@action
|
||||||
async saveChanges(event) {
|
async saveChanges(changes) {
|
||||||
event.preventDefault();
|
|
||||||
if (this.args.onSave) {
|
if (this.args.onSave) {
|
||||||
await this.args.onSave({
|
await this.args.onSave({
|
||||||
...this.place,
|
...this.place,
|
||||||
title: this.editTitle,
|
...changes,
|
||||||
description: this.editDescription,
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
this.isEditing = false;
|
this.isEditing = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
@action
|
|
||||||
updateTitle(e) {
|
|
||||||
this.editTitle = e.target.value;
|
|
||||||
}
|
|
||||||
|
|
||||||
@action
|
|
||||||
updateDescription(e) {
|
|
||||||
this.editDescription = e.target.value;
|
|
||||||
}
|
|
||||||
|
|
||||||
get type() {
|
get type() {
|
||||||
const rawType =
|
const rawType =
|
||||||
this.tags.amenity ||
|
this.tags.amenity ||
|
||||||
@@ -165,38 +140,19 @@ export default class PlaceDetails extends Component {
|
|||||||
}
|
}
|
||||||
|
|
||||||
get gmapsUrl() {
|
get gmapsUrl() {
|
||||||
|
const id = this.place.gmapsId || this.place.osmId;
|
||||||
|
if (!id) return null;
|
||||||
return `https://www.google.com/maps/search/?api=1&query=${this.name}&query=${this.place.lat},${this.place.lon}`;
|
return `https://www.google.com/maps/search/?api=1&query=${this.name}&query=${this.place.lat},${this.place.lon}`;
|
||||||
}
|
}
|
||||||
|
|
||||||
<template>
|
<template>
|
||||||
<div class="place-details">
|
<div class="place-details">
|
||||||
{{#if this.isEditing}}
|
{{#if this.isEditing}}
|
||||||
<form class="edit-form" {{on "submit" this.saveChanges}}>
|
<PlaceEditForm
|
||||||
<div class="form-group">
|
@place={{this.place}}
|
||||||
<label for="edit-title">Title</label>
|
@onSave={{this.saveChanges}}
|
||||||
<input
|
@onCancel={{this.cancelEditing}}
|
||||||
id="edit-title"
|
|
||||||
type="text"
|
|
||||||
value={{this.editTitle}}
|
|
||||||
{{on "input" this.updateTitle}}
|
|
||||||
class="form-control"
|
|
||||||
/>
|
/>
|
||||||
</div>
|
|
||||||
<div class="form-group">
|
|
||||||
<label for="edit-desc">Description</label>
|
|
||||||
<textarea
|
|
||||||
id="edit-desc"
|
|
||||||
value={{this.editDescription}}
|
|
||||||
{{on "input" this.updateDescription}}
|
|
||||||
class="form-control"
|
|
||||||
rows="3"
|
|
||||||
></textarea>
|
|
||||||
</div>
|
|
||||||
<div class="edit-actions">
|
|
||||||
<button type="submit" class="btn btn-blue">Save</button>
|
|
||||||
<button type="button" class="btn btn-outline" {{on "click" this.cancelEditing}}>Cancel</button>
|
|
||||||
</div>
|
|
||||||
</form>
|
|
||||||
{{else}}
|
{{else}}
|
||||||
<h3>{{this.name}}</h3>
|
<h3>{{this.name}}</h3>
|
||||||
<p class="place-type">
|
<p class="place-type">
|
||||||
@@ -305,7 +261,7 @@ export default class PlaceDetails extends Component {
|
|||||||
|
|
||||||
{{#if this.osmUrl}}
|
{{#if this.osmUrl}}
|
||||||
<p class="content-with-icon">
|
<p class="content-with-icon">
|
||||||
<Icon @name="map" @title="OSM ID" />
|
<Icon @name="map" />
|
||||||
<span>
|
<span>
|
||||||
<a href={{this.osmUrl}} target="_blank" rel="noopener noreferrer">
|
<a href={{this.osmUrl}} target="_blank" rel="noopener noreferrer">
|
||||||
OpenStreetMap
|
OpenStreetMap
|
||||||
@@ -314,14 +270,16 @@ export default class PlaceDetails extends Component {
|
|||||||
</p>
|
</p>
|
||||||
{{/if}}
|
{{/if}}
|
||||||
|
|
||||||
|
{{#if this.gmapsUrl}}
|
||||||
<p class="content-with-icon">
|
<p class="content-with-icon">
|
||||||
<Icon @name="map" @title="OSM ID" />
|
<Icon @name="map" />
|
||||||
<span>
|
<span>
|
||||||
<a href={{this.gmapsUrl}} target="_blank" rel="noopener noreferrer">
|
<a href={{this.gmapsUrl}} target="_blank" rel="noopener noreferrer">
|
||||||
Google Maps
|
Google Maps
|
||||||
</a>
|
</a>
|
||||||
</span>
|
</span>
|
||||||
</p>
|
</p>
|
||||||
|
{{/if}}
|
||||||
|
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
79
app/components/place-edit-form.gjs
Normal file
79
app/components/place-edit-form.gjs
Normal file
@@ -0,0 +1,79 @@
|
|||||||
|
import Component from '@glimmer/component';
|
||||||
|
import { on } from '@ember/modifier';
|
||||||
|
import { tracked } from '@glimmer/tracking';
|
||||||
|
import { action } from '@ember/object';
|
||||||
|
|
||||||
|
export default class PlaceEditForm extends Component {
|
||||||
|
@tracked title = '';
|
||||||
|
@tracked description = '';
|
||||||
|
|
||||||
|
constructor() {
|
||||||
|
super(...arguments);
|
||||||
|
this.title = this.args.place?.title || '';
|
||||||
|
this.description = this.args.place?.description || '';
|
||||||
|
}
|
||||||
|
|
||||||
|
get shouldAutofocus() {
|
||||||
|
if (typeof window !== 'undefined') {
|
||||||
|
return window.innerWidth > 768;
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
handleSubmit(event) {
|
||||||
|
event.preventDefault();
|
||||||
|
if (this.args.onSave) {
|
||||||
|
this.args.onSave({
|
||||||
|
title: this.title,
|
||||||
|
description: this.description,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
updateTitle(e) {
|
||||||
|
this.title = e.target.value;
|
||||||
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
updateDescription(e) {
|
||||||
|
this.description = e.target.value;
|
||||||
|
}
|
||||||
|
|
||||||
|
<template>
|
||||||
|
<form class="edit-form" {{on "submit" this.handleSubmit}}>
|
||||||
|
<div class="form-group">
|
||||||
|
<label for="edit-title">Title</label>
|
||||||
|
<input
|
||||||
|
id="edit-title"
|
||||||
|
type="text"
|
||||||
|
value={{this.title}}
|
||||||
|
{{on "input" this.updateTitle}}
|
||||||
|
class="form-control"
|
||||||
|
placeholder="Name of the place"
|
||||||
|
autofocus={{this.shouldAutofocus}}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
<div class="form-group">
|
||||||
|
<label for="edit-desc">Description</label>
|
||||||
|
<textarea
|
||||||
|
id="edit-desc"
|
||||||
|
value={{this.description}}
|
||||||
|
{{on "input" this.updateDescription}}
|
||||||
|
class="form-control"
|
||||||
|
rows="3"
|
||||||
|
placeholder="Add some details..."
|
||||||
|
></textarea>
|
||||||
|
</div>
|
||||||
|
<div class="edit-actions">
|
||||||
|
<button type="submit" class="btn btn-blue">Save</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
class="btn btn-outline"
|
||||||
|
{{on "click" @onCancel}}
|
||||||
|
>Cancel</button>
|
||||||
|
</div>
|
||||||
|
</form>
|
||||||
|
</template>
|
||||||
|
}
|
||||||
@@ -7,9 +7,26 @@ import or from 'ember-truth-helpers/helpers/or';
|
|||||||
import PlaceDetails from './place-details';
|
import PlaceDetails from './place-details';
|
||||||
import Icon from './icon';
|
import Icon from './icon';
|
||||||
import humanizeOsmTag from '../helpers/humanize-osm-tag';
|
import humanizeOsmTag from '../helpers/humanize-osm-tag';
|
||||||
|
import { getLocalizedName } from '../utils/osm';
|
||||||
|
|
||||||
export default class PlacesSidebar extends Component {
|
export default class PlacesSidebar extends Component {
|
||||||
@service storage;
|
@service storage;
|
||||||
|
@service router;
|
||||||
|
@service mapUi;
|
||||||
|
|
||||||
|
@action
|
||||||
|
createNewPlace() {
|
||||||
|
const qp = this.router.currentRoute.queryParams;
|
||||||
|
const lat = qp.lat;
|
||||||
|
const lon = qp.lon;
|
||||||
|
|
||||||
|
if (lat && lon) {
|
||||||
|
this.router.transitionTo('place.new', { queryParams: { lat, lon } });
|
||||||
|
} else {
|
||||||
|
// Fallback (shouldn't happen in search context)
|
||||||
|
this.router.transitionTo('place.new', { queryParams: { lat: 0, lon: 0 } });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
@action
|
@action
|
||||||
selectPlace(place) {
|
selectPlace(place) {
|
||||||
@@ -34,19 +51,14 @@ export default class PlacesSidebar extends Component {
|
|||||||
if (confirm(`Delete "${place.title}"?`)) {
|
if (confirm(`Delete "${place.title}"?`)) {
|
||||||
try {
|
try {
|
||||||
await this.storage.removePlace(place);
|
await this.storage.removePlace(place);
|
||||||
console.log('Place deleted:', place.title);
|
console.debug('Place deleted:', place.title);
|
||||||
|
|
||||||
// Notify parent to refresh map bookmarks
|
// Notify parent to refresh map bookmarks
|
||||||
if (this.args.onBookmarkChange) {
|
if (this.args.onBookmarkChange) {
|
||||||
this.args.onBookmarkChange();
|
this.args.onBookmarkChange();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Update selection to the new saved place object
|
|
||||||
// This updates the local UI state immediately without a route refresh
|
|
||||||
if (this.args.onUpdate) {
|
if (this.args.onUpdate) {
|
||||||
// When deleting, we revert to a "fresh" object or just close.
|
|
||||||
// Since we close the sidebar below, we might not strictly need to update local state,
|
|
||||||
// but it's good practice.
|
|
||||||
// Reconstruct the "original" place without ID/Geohash/CreatedAt
|
// Reconstruct the "original" place without ID/Geohash/CreatedAt
|
||||||
const freshPlace = {
|
const freshPlace = {
|
||||||
...place,
|
...place,
|
||||||
@@ -59,7 +71,6 @@ export default class PlacesSidebar extends Component {
|
|||||||
|
|
||||||
// Also fire onSelect if it exists (for list view)
|
// Also fire onSelect if it exists (for list view)
|
||||||
if (this.args.onSelect) {
|
if (this.args.onSelect) {
|
||||||
// Similar logic for select if needed, but we usually close.
|
|
||||||
this.args.onSelect(null);
|
this.args.onSelect(null);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -75,8 +86,7 @@ export default class PlacesSidebar extends Component {
|
|||||||
} else {
|
} else {
|
||||||
// It's a fresh POI -> Save it
|
// It's a fresh POI -> Save it
|
||||||
const placeData = {
|
const placeData = {
|
||||||
title:
|
title: getLocalizedName(place.osmTags, 'Untitled Place'),
|
||||||
place.osmTags.name || place.osmTags['name:en'] || 'Untitled Place',
|
|
||||||
lat: place.lat,
|
lat: place.lat,
|
||||||
lon: place.lon,
|
lon: place.lon,
|
||||||
tags: [],
|
tags: [],
|
||||||
@@ -88,7 +98,7 @@ export default class PlacesSidebar extends Component {
|
|||||||
|
|
||||||
try {
|
try {
|
||||||
const savedPlace = await this.storage.storePlace(placeData);
|
const savedPlace = await this.storage.storePlace(placeData);
|
||||||
console.log('Place saved:', placeData.title);
|
console.debug('Place saved:', placeData.title);
|
||||||
|
|
||||||
// Notify parent to refresh map bookmarks
|
// Notify parent to refresh map bookmarks
|
||||||
if (this.args.onBookmarkChange) {
|
if (this.args.onBookmarkChange) {
|
||||||
@@ -115,7 +125,7 @@ export default class PlacesSidebar extends Component {
|
|||||||
async updateBookmark(updatedPlace) {
|
async updateBookmark(updatedPlace) {
|
||||||
try {
|
try {
|
||||||
const savedPlace = await this.storage.updatePlace(updatedPlace);
|
const savedPlace = await this.storage.updatePlace(updatedPlace);
|
||||||
console.log('Place updated:', savedPlace.title);
|
console.debug('Place updated:', savedPlace.title);
|
||||||
|
|
||||||
// Notify parent to refresh map/lists
|
// Notify parent to refresh map/lists
|
||||||
if (this.args.onBookmarkChange) {
|
if (this.args.onBookmarkChange) {
|
||||||
@@ -180,6 +190,7 @@ export default class PlacesSidebar extends Component {
|
|||||||
place.osmTags.tourism
|
place.osmTags.tourism
|
||||||
place.osmTags.leisure
|
place.osmTags.leisure
|
||||||
place.osmTags.historic
|
place.osmTags.historic
|
||||||
|
"Point of Interest"
|
||||||
)}}</div>
|
)}}</div>
|
||||||
</button>
|
</button>
|
||||||
</li>
|
</li>
|
||||||
@@ -188,6 +199,15 @@ export default class PlacesSidebar extends Component {
|
|||||||
{{else}}
|
{{else}}
|
||||||
<p class="empty-state">No places found nearby.</p>
|
<p class="empty-state">No places found nearby.</p>
|
||||||
{{/if}}
|
{{/if}}
|
||||||
|
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
class="btn btn-outline create-place"
|
||||||
|
{{on "click" this.createNewPlace}}
|
||||||
|
>
|
||||||
|
<Icon @name="plus" @size={{18}} @color="#007bff" />
|
||||||
|
Create new place
|
||||||
|
</button>
|
||||||
{{/if}}
|
{{/if}}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import { service } from '@ember/service';
|
|||||||
import { action } from '@ember/object';
|
import { action } from '@ember/object';
|
||||||
import Icon from '#components/icon';
|
import Icon from '#components/icon';
|
||||||
import eq from 'ember-truth-helpers/helpers/eq';
|
import eq from 'ember-truth-helpers/helpers/eq';
|
||||||
|
import not from 'ember-truth-helpers/helpers/not';
|
||||||
|
|
||||||
export default class SettingsPane extends Component {
|
export default class SettingsPane extends Component {
|
||||||
@service settings;
|
@service settings;
|
||||||
@@ -13,6 +14,11 @@ export default class SettingsPane extends Component {
|
|||||||
this.settings.updateOverpassApi(event.target.value);
|
this.settings.updateOverpassApi(event.target.value);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
toggleKinetic(event) {
|
||||||
|
this.settings.updateMapKinetic(event.target.value === 'true');
|
||||||
|
}
|
||||||
|
|
||||||
<template>
|
<template>
|
||||||
<div class="sidebar settings-pane">
|
<div class="sidebar settings-pane">
|
||||||
<div class="sidebar-header">
|
<div class="sidebar-header">
|
||||||
@@ -25,6 +31,27 @@ export default class SettingsPane extends Component {
|
|||||||
<div class="sidebar-content">
|
<div class="sidebar-content">
|
||||||
<section class="settings-section">
|
<section class="settings-section">
|
||||||
<h3>Settings</h3>
|
<h3>Settings</h3>
|
||||||
|
<div class="form-group">
|
||||||
|
<label for="map-kinetic">Map Inertia (Kinetic Panning)</label>
|
||||||
|
<select
|
||||||
|
id="map-kinetic"
|
||||||
|
class="form-control"
|
||||||
|
{{on "change" this.toggleKinetic}}
|
||||||
|
>
|
||||||
|
<option
|
||||||
|
value="true"
|
||||||
|
selected={{if this.settings.mapKinetic "selected"}}
|
||||||
|
>
|
||||||
|
On
|
||||||
|
</option>
|
||||||
|
<option
|
||||||
|
value="false"
|
||||||
|
selected={{unless this.settings.mapKinetic "selected"}}
|
||||||
|
>
|
||||||
|
Off
|
||||||
|
</option>
|
||||||
|
</select>
|
||||||
|
</div>
|
||||||
<div class="form-group">
|
<div class="form-group">
|
||||||
<label for="overpass-api">Overpass API Provider</label>
|
<label for="overpass-api">Overpass API Provider</label>
|
||||||
<select
|
<select
|
||||||
|
|||||||
@@ -8,5 +8,6 @@ export default class Router extends EmberRouter {
|
|||||||
|
|
||||||
Router.map(function () {
|
Router.map(function () {
|
||||||
this.route('place', { path: '/place/:place_id' });
|
this.route('place', { path: '/place/:place_id' });
|
||||||
|
this.route('place.new', { path: '/place/new' });
|
||||||
this.route('search');
|
this.route('search');
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ export default class PlaceRoute extends Route {
|
|||||||
|
|
||||||
if (id.startsWith('osm:node:') || id.startsWith('osm:way:')) {
|
if (id.startsWith('osm:node:') || id.startsWith('osm:way:')) {
|
||||||
const [, type, osmId] = id.split(':');
|
const [, type, osmId] = id.split(':');
|
||||||
console.log(`Fetching explicit OSM ${type}:`, osmId);
|
console.debug(`Fetching explicit OSM ${type}:`, osmId);
|
||||||
return this.loadOsmPlace(osmId, type);
|
return this.loadOsmPlace(osmId, type);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -20,7 +20,7 @@ export default class PlaceRoute extends Route {
|
|||||||
let bookmark = this.storage.findPlaceById(id);
|
let bookmark = this.storage.findPlaceById(id);
|
||||||
|
|
||||||
if (bookmark) {
|
if (bookmark) {
|
||||||
console.log('Found in bookmarks:', bookmark.title);
|
console.debug('Found in bookmarks:', bookmark.title);
|
||||||
return bookmark;
|
return bookmark;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -31,7 +31,7 @@ export default class PlaceRoute extends Route {
|
|||||||
async waitForSync() {
|
async waitForSync() {
|
||||||
if (this.storage.initialSyncDone) return;
|
if (this.storage.initialSyncDone) return;
|
||||||
|
|
||||||
console.log('Waiting for initial storage sync...');
|
console.debug('Waiting for initial storage sync...');
|
||||||
const timeout = 5000;
|
const timeout = 5000;
|
||||||
const start = Date.now();
|
const start = Date.now();
|
||||||
|
|
||||||
@@ -56,6 +56,8 @@ export default class PlaceRoute extends Route {
|
|||||||
deactivate() {
|
deactivate() {
|
||||||
// Clear the pin when leaving the route
|
// Clear the pin when leaving the route
|
||||||
this.mapUi.clearSelection();
|
this.mapUi.clearSelection();
|
||||||
|
// Reset the "return to search" flag so it doesn't persist to subsequent navigations
|
||||||
|
this.mapUi.returnToSearch = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
async loadOsmPlace(id, type = null) {
|
async loadOsmPlace(id, type = null) {
|
||||||
|
|||||||
30
app/routes/place/new.js
Normal file
30
app/routes/place/new.js
Normal file
@@ -0,0 +1,30 @@
|
|||||||
|
import Route from '@ember/routing/route';
|
||||||
|
import { service } from '@ember/service';
|
||||||
|
|
||||||
|
export default class PlaceNewRoute extends Route {
|
||||||
|
@service mapUi;
|
||||||
|
|
||||||
|
queryParams = {
|
||||||
|
lat: { refreshModel: true },
|
||||||
|
lon: { refreshModel: true },
|
||||||
|
};
|
||||||
|
|
||||||
|
model(params) {
|
||||||
|
return {
|
||||||
|
lat: parseFloat(params.lat),
|
||||||
|
lon: parseFloat(params.lon),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
setupController(controller, model) {
|
||||||
|
super.setupController(controller, model);
|
||||||
|
if (model.lat && model.lon) {
|
||||||
|
this.mapUi.updateCreationCoordinates(model.lat, model.lon);
|
||||||
|
}
|
||||||
|
this.mapUi.startCreating();
|
||||||
|
}
|
||||||
|
|
||||||
|
deactivate() {
|
||||||
|
this.mapUi.stopCreating();
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -28,6 +28,26 @@ export default class SearchRoute extends Route {
|
|||||||
// Fetch POIs
|
// Fetch POIs
|
||||||
let pois = await this.osm.getNearbyPois(lat, lon, searchRadius);
|
let pois = await this.osm.getNearbyPois(lat, lon, searchRadius);
|
||||||
|
|
||||||
|
// Get cached/saved places in search radius
|
||||||
|
const localMatches = this.storage.savedPlaces.filter((p) => {
|
||||||
|
const dist = getDistance(lat, lon, p.lat, p.lon);
|
||||||
|
return dist <= searchRadius;
|
||||||
|
});
|
||||||
|
|
||||||
|
// Add local matches to the list if they aren't already there
|
||||||
|
// We use osmId to deduplicate if possible
|
||||||
|
localMatches.forEach((local) => {
|
||||||
|
const exists = pois.find(
|
||||||
|
(poi) =>
|
||||||
|
(local.osmId && poi.osmId === local.osmId) ||
|
||||||
|
(poi.id && poi.id === local.id)
|
||||||
|
);
|
||||||
|
|
||||||
|
if (!exists) {
|
||||||
|
pois.push(local);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
// Sort by distance from click
|
// Sort by distance from click
|
||||||
pois = pois
|
pois = pois
|
||||||
.map((p) => {
|
.map((p) => {
|
||||||
|
|||||||
@@ -4,6 +4,9 @@ import { tracked } from '@glimmer/tracking';
|
|||||||
export default class MapUiService extends Service {
|
export default class MapUiService extends Service {
|
||||||
@tracked selectedPlace = null;
|
@tracked selectedPlace = null;
|
||||||
@tracked isSearching = false;
|
@tracked isSearching = false;
|
||||||
|
@tracked isCreating = false;
|
||||||
|
@tracked creationCoordinates = null;
|
||||||
|
@tracked returnToSearch = false;
|
||||||
|
|
||||||
selectPlace(place) {
|
selectPlace(place) {
|
||||||
this.selectedPlace = place;
|
this.selectedPlace = place;
|
||||||
@@ -15,9 +18,24 @@ export default class MapUiService extends Service {
|
|||||||
|
|
||||||
startSearch() {
|
startSearch() {
|
||||||
this.isSearching = true;
|
this.isSearching = true;
|
||||||
|
this.isCreating = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
stopSearch() {
|
stopSearch() {
|
||||||
this.isSearching = false;
|
this.isSearching = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
startCreating() {
|
||||||
|
this.isCreating = true;
|
||||||
|
this.isSearching = false;
|
||||||
|
}
|
||||||
|
|
||||||
|
stopCreating() {
|
||||||
|
this.isCreating = false;
|
||||||
|
this.creationCoordinates = null;
|
||||||
|
}
|
||||||
|
|
||||||
|
updateCreationCoordinates(lat, lon) {
|
||||||
|
this.creationCoordinates = { lat, lon };
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import Service, { service } from '@ember/service';
|
import Service, { service } from '@ember/service';
|
||||||
|
import { getLocalizedName } from '../utils/osm';
|
||||||
|
|
||||||
export default class OsmService extends Service {
|
export default class OsmService extends Service {
|
||||||
@service settings;
|
@service settings;
|
||||||
@@ -12,7 +13,7 @@ export default class OsmService extends Service {
|
|||||||
|
|
||||||
// Return cached results if the query is identical to the last one
|
// Return cached results if the query is identical to the last one
|
||||||
if (this.lastQueryKey === queryKey && this.cachedResults) {
|
if (this.lastQueryKey === queryKey && this.cachedResults) {
|
||||||
console.log('Returning cached Overpass results for:', queryKey);
|
console.debug('Returning cached Overpass results for:', queryKey);
|
||||||
return this.cachedResults;
|
return this.cachedResults;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -52,7 +53,7 @@ out center;
|
|||||||
return results;
|
return results;
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
if (e.name === 'AbortError') {
|
if (e.name === 'AbortError') {
|
||||||
console.log('Overpass request aborted');
|
console.debug('Overpass request aborted');
|
||||||
return [];
|
return [];
|
||||||
}
|
}
|
||||||
throw e;
|
throw e;
|
||||||
@@ -61,7 +62,7 @@ out center;
|
|||||||
|
|
||||||
normalizePoi(poi) {
|
normalizePoi(poi) {
|
||||||
return {
|
return {
|
||||||
title: poi.tags?.name || poi.tags?.['name:en'] || 'Untitled Place',
|
title: getLocalizedName(poi.tags),
|
||||||
lat: poi.lat || poi.center?.lat,
|
lat: poi.lat || poi.center?.lat,
|
||||||
lon: poi.lon || poi.center?.lon,
|
lon: poi.lon || poi.center?.lon,
|
||||||
url: poi.tags?.website,
|
url: poi.tags?.website,
|
||||||
@@ -78,7 +79,7 @@ out center;
|
|||||||
const res = await fetch(url, options);
|
const res = await fetch(url, options);
|
||||||
|
|
||||||
if (!res.ok && retries > 0 && [502, 503, 504, 429].includes(res.status)) {
|
if (!res.ok && retries > 0 && [502, 503, 504, 429].includes(res.status)) {
|
||||||
console.log(
|
console.warn(
|
||||||
`Overpass request failed with ${res.status}. Retrying... (${retries} left)`
|
`Overpass request failed with ${res.status}. Retrying... (${retries} left)`
|
||||||
);
|
);
|
||||||
await new Promise((r) => setTimeout(r, 1000));
|
await new Promise((r) => setTimeout(r, 1000));
|
||||||
@@ -88,7 +89,7 @@ out center;
|
|||||||
return res;
|
return res;
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
if (retries > 0 && e.name !== 'AbortError') {
|
if (retries > 0 && e.name !== 'AbortError') {
|
||||||
console.log(`Retrying Overpass request... (${retries} left)`);
|
console.debug(`Retrying Overpass request... (${retries} left)`);
|
||||||
await new Promise((r) => setTimeout(r, 1000));
|
await new Promise((r) => setTimeout(r, 1000));
|
||||||
return this.fetchWithRetry(url, options, retries - 1);
|
return this.fetchWithRetry(url, options, retries - 1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ import { tracked } from '@glimmer/tracking';
|
|||||||
|
|
||||||
export default class SettingsService extends Service {
|
export default class SettingsService extends Service {
|
||||||
@tracked overpassApi = 'https://overpass.bke.ro/api/interpreter';
|
@tracked overpassApi = 'https://overpass.bke.ro/api/interpreter';
|
||||||
|
@tracked mapKinetic = true;
|
||||||
|
|
||||||
overpassApis = [
|
overpassApis = [
|
||||||
{ name: 'bke.ro', url: 'https://overpass.bke.ro/api/interpreter' },
|
{ name: 'bke.ro', url: 'https://overpass.bke.ro/api/interpreter' },
|
||||||
@@ -19,14 +20,25 @@ export default class SettingsService extends Service {
|
|||||||
}
|
}
|
||||||
|
|
||||||
loadSettings() {
|
loadSettings() {
|
||||||
const savedApi = localStorage.getItem('marco-overpass-api');
|
const savedApi = localStorage.getItem('marco:overpass-api');
|
||||||
if (savedApi) {
|
if (savedApi) {
|
||||||
this.overpassApi = savedApi;
|
this.overpassApi = savedApi;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const savedKinetic = localStorage.getItem('marco:map-kinetic');
|
||||||
|
if (savedKinetic !== null) {
|
||||||
|
this.mapKinetic = savedKinetic === 'true';
|
||||||
|
}
|
||||||
|
// Default is true (initialized in class field)
|
||||||
}
|
}
|
||||||
|
|
||||||
updateOverpassApi(url) {
|
updateOverpassApi(url) {
|
||||||
this.overpassApi = url;
|
this.overpassApi = url;
|
||||||
localStorage.setItem('marco-overpass-api', url);
|
localStorage.setItem('marco:overpass-api', url);
|
||||||
|
}
|
||||||
|
|
||||||
|
updateMapKinetic(enabled) {
|
||||||
|
this.mapKinetic = enabled;
|
||||||
|
localStorage.setItem('marco:map-kinetic', String(enabled));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -23,7 +23,6 @@ export default class StorageService extends Service {
|
|||||||
|
|
||||||
constructor() {
|
constructor() {
|
||||||
super(...arguments);
|
super(...arguments);
|
||||||
console.log('ohai');
|
|
||||||
|
|
||||||
this.rs = new RemoteStorage({
|
this.rs = new RemoteStorage({
|
||||||
modules: [Places],
|
modules: [Places],
|
||||||
@@ -45,13 +44,11 @@ export default class StorageService extends Service {
|
|||||||
});
|
});
|
||||||
|
|
||||||
this.rs.on('connected', () => {
|
this.rs.on('connected', () => {
|
||||||
console.debug('Remote storage connected');
|
|
||||||
this.connected = true;
|
this.connected = true;
|
||||||
this.userAddress = this.rs.remote.userAddress;
|
this.userAddress = this.rs.remote.userAddress;
|
||||||
});
|
});
|
||||||
|
|
||||||
this.rs.on('disconnected', () => {
|
this.rs.on('disconnected', () => {
|
||||||
console.debug('Remote storage disconnected');
|
|
||||||
this.connected = false;
|
this.connected = false;
|
||||||
this.userAddress = null;
|
this.userAddress = null;
|
||||||
this.placesInView = [];
|
this.placesInView = [];
|
||||||
@@ -77,18 +74,7 @@ export default class StorageService extends Service {
|
|||||||
handlePlaceChange(event) {
|
handlePlaceChange(event) {
|
||||||
const { newValue, relativePath } = event;
|
const { newValue, relativePath } = event;
|
||||||
|
|
||||||
// Remove old entry if exists
|
// Extract ID from path (structure: <2-char>/<2-char>/<id>)
|
||||||
// The relativePath is like "geohash/geohash/ULID" or just "ULID" depending on structure.
|
|
||||||
// Our structure is <2-char>/<2-char>/<id>.
|
|
||||||
// But let's rely on the ID inside the object if possible, or extract from path.
|
|
||||||
|
|
||||||
// We can't easily identify the ID from just relativePath without parsing logic if it's nested.
|
|
||||||
// However, for deletions (newValue is undefined), we might need the ID.
|
|
||||||
// Fortunately, our objects (newValue) contain the ID.
|
|
||||||
|
|
||||||
// If it's a deletion, we need to find the object in our array to remove it.
|
|
||||||
// Since we don't have the ID in newValue (it's null), we rely on `relativePath`.
|
|
||||||
// Let's assume the filename is the ID.
|
|
||||||
const pathParts = relativePath.split('/');
|
const pathParts = relativePath.split('/');
|
||||||
const id = pathParts[pathParts.length - 1];
|
const id = pathParts[pathParts.length - 1];
|
||||||
|
|
||||||
@@ -128,7 +114,7 @@ export default class StorageService extends Service {
|
|||||||
|
|
||||||
// Recalculate prefixes for the current view
|
// Recalculate prefixes for the current view
|
||||||
const required = getGeohashPrefixesInBbox(this.currentBbox);
|
const required = getGeohashPrefixesInBbox(this.currentBbox);
|
||||||
console.log('Reloading view due to changes, prefixes:', required);
|
console.debug('Reloading view due to changes, prefixes:', required);
|
||||||
|
|
||||||
// Force load these prefixes (bypassing the 'already loaded' check in loadPlacesInBounds)
|
// Force load these prefixes (bypassing the 'already loaded' check in loadPlacesInBounds)
|
||||||
this.loadAllPlaces(required);
|
this.loadAllPlaces(required);
|
||||||
@@ -144,20 +130,15 @@ export default class StorageService extends Service {
|
|||||||
);
|
);
|
||||||
|
|
||||||
if (missingPrefixes.length === 0) {
|
if (missingPrefixes.length === 0) {
|
||||||
// console.log('All prefixes already loaded for this view');
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
console.log('Loading new prefixes:', missingPrefixes);
|
console.debug('Loading new prefixes:', missingPrefixes);
|
||||||
|
|
||||||
// 3. Load places for only the new prefixes
|
// 3. Load places for only the new prefixes
|
||||||
await this.loadAllPlaces(missingPrefixes);
|
await this.loadAllPlaces(missingPrefixes);
|
||||||
|
|
||||||
// 4. Update our tracked list of loaded prefixes
|
// 4. Update our tracked list of loaded prefixes
|
||||||
// Using assignment to trigger reactivity if needed, though simple push/mutation might suffice
|
|
||||||
// depending on usage. Tracked arrays need reassignment or specific Ember array methods
|
|
||||||
// if we want to observe the array itself, but here we just check inclusion.
|
|
||||||
// Let's do a reassignment to be safe and clean.
|
|
||||||
this.loadedPrefixes = [...this.loadedPrefixes, ...missingPrefixes];
|
this.loadedPrefixes = [...this.loadedPrefixes, ...missingPrefixes];
|
||||||
this.currentBbox = bbox;
|
this.currentBbox = bbox;
|
||||||
}
|
}
|
||||||
@@ -195,7 +176,7 @@ export default class StorageService extends Service {
|
|||||||
} else {
|
} else {
|
||||||
if (!prefixes) this.placesInView = [];
|
if (!prefixes) this.placesInView = [];
|
||||||
}
|
}
|
||||||
console.log('Loaded saved places:', this.placesInView.length);
|
console.debug('Loaded saved places:', this.placesInView.length);
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
console.error('Failed to load places:', e);
|
console.error('Failed to load places:', e);
|
||||||
}
|
}
|
||||||
@@ -216,29 +197,56 @@ export default class StorageService extends Service {
|
|||||||
|
|
||||||
async storePlace(placeData) {
|
async storePlace(placeData) {
|
||||||
const savedPlace = await this.places.store(placeData);
|
const savedPlace = await this.places.store(placeData);
|
||||||
// Only append if not already there (handlePlaceChange might also fire)
|
|
||||||
|
// Optimistic Update: Global List
|
||||||
if (!this.savedPlaces.some((p) => p.id === savedPlace.id)) {
|
if (!this.savedPlaces.some((p) => p.id === savedPlace.id)) {
|
||||||
this.savedPlaces = [...this.savedPlaces, savedPlace];
|
this.savedPlaces = [...this.savedPlaces, savedPlace];
|
||||||
|
} else {
|
||||||
|
// Update if exists
|
||||||
|
this.savedPlaces = this.savedPlaces.map((p) =>
|
||||||
|
p.id === savedPlace.id ? savedPlace : p
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Optimistic Update: Map View (same logic as Global List)
|
||||||
|
if (!this.placesInView.some((p) => p.id === savedPlace.id)) {
|
||||||
|
this.placesInView = [...this.placesInView, savedPlace];
|
||||||
|
} else {
|
||||||
|
this.placesInView = this.placesInView.map((p) =>
|
||||||
|
p.id === savedPlace.id ? savedPlace : p
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
return savedPlace;
|
return savedPlace;
|
||||||
}
|
}
|
||||||
|
|
||||||
async updatePlace(placeData) {
|
async updatePlace(placeData) {
|
||||||
const savedPlace = await this.places.store(placeData);
|
const savedPlace = await this.places.store(placeData);
|
||||||
|
|
||||||
// Update local list
|
// Optimistic Update: Global List
|
||||||
const index = this.savedPlaces.findIndex((p) => p.id === savedPlace.id);
|
const index = this.savedPlaces.findIndex((p) => p.id === savedPlace.id);
|
||||||
if (index !== -1) {
|
if (index !== -1) {
|
||||||
const newPlaces = [...this.savedPlaces];
|
const newPlaces = [...this.savedPlaces];
|
||||||
newPlaces[index] = savedPlace;
|
newPlaces[index] = savedPlace;
|
||||||
this.savedPlaces = newPlaces;
|
this.savedPlaces = newPlaces;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Update Map View
|
||||||
|
this.placesInView = this.placesInView.map((p) =>
|
||||||
|
p.id === savedPlace.id ? savedPlace : p
|
||||||
|
);
|
||||||
|
|
||||||
return savedPlace;
|
return savedPlace;
|
||||||
}
|
}
|
||||||
|
|
||||||
async removePlace(place) {
|
async removePlace(place) {
|
||||||
await this.places.remove(place.id, place.geohash);
|
await this.places.remove(place.id, place.geohash);
|
||||||
|
|
||||||
|
// Update both lists
|
||||||
this.savedPlaces = this.savedPlaces.filter((p) => p.id !== place.id);
|
this.savedPlaces = this.savedPlaces.filter((p) => p.id !== place.id);
|
||||||
|
if (this.placesInView.length > 0) {
|
||||||
|
this.placesInView = this.placesInView.filter((p) => p.id !== place.id);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@action
|
@action
|
||||||
|
|||||||
@@ -5,6 +5,11 @@ body {
|
|||||||
height: 100%;
|
height: 100%;
|
||||||
overscroll-behavior: none; /* Prevent pull-to-refresh on mobile */
|
overscroll-behavior: none; /* Prevent pull-to-refresh on mobile */
|
||||||
-webkit-text-size-adjust: 100%;
|
-webkit-text-size-adjust: 100%;
|
||||||
|
-webkit-tap-highlight-color: transparent;
|
||||||
|
}
|
||||||
|
|
||||||
|
button {
|
||||||
|
-webkit-tap-highlight-color: transparent;
|
||||||
}
|
}
|
||||||
|
|
||||||
body {
|
body {
|
||||||
@@ -69,7 +74,15 @@ body {
|
|||||||
pointer-events: auto; /* Re-enable clicks for buttons */
|
pointer-events: auto; /* Re-enable clicks for buttons */
|
||||||
}
|
}
|
||||||
|
|
||||||
.icon-btn {
|
.btn-press {
|
||||||
|
transition: transform 0.1s;
|
||||||
|
}
|
||||||
|
|
||||||
|
.btn-press:active {
|
||||||
|
transform: scale(0.95);
|
||||||
|
}
|
||||||
|
|
||||||
|
.menu-btn {
|
||||||
background: white;
|
background: white;
|
||||||
border: none;
|
border: none;
|
||||||
border-radius: 50%;
|
border-radius: 50%;
|
||||||
@@ -80,11 +93,6 @@ body {
|
|||||||
justify-content: center;
|
justify-content: center;
|
||||||
box-shadow: 0 2px 5px rgb(0 0 0 / 20%);
|
box-shadow: 0 2px 5px rgb(0 0 0 / 20%);
|
||||||
cursor: pointer;
|
cursor: pointer;
|
||||||
transition: transform 0.1s;
|
|
||||||
}
|
|
||||||
|
|
||||||
.icon-btn:active {
|
|
||||||
transform: scale(0.95);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.user-btn {
|
.user-btn {
|
||||||
@@ -539,22 +547,40 @@ body {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Locate Control */
|
/* Zoom Control - Moved to bottom right above attribution */
|
||||||
|
.ol-zoom {
|
||||||
|
top: auto !important;
|
||||||
|
left: auto !important;
|
||||||
|
bottom: 2.5em;
|
||||||
|
right: 0.5em;
|
||||||
|
}
|
||||||
|
|
||||||
|
.ol-touch .ol-zoom {
|
||||||
|
bottom: 3.5em;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Locate Control - Above Zoom */
|
||||||
.ol-control.ol-locate {
|
.ol-control.ol-locate {
|
||||||
inset: auto 0.5em 2.5em auto;
|
top: auto !important;
|
||||||
|
left: auto !important;
|
||||||
|
bottom: 6.5em;
|
||||||
|
right: 0.5em;
|
||||||
}
|
}
|
||||||
|
|
||||||
.ol-touch .ol-control.ol-locate {
|
.ol-touch .ol-control.ol-locate {
|
||||||
inset: auto 0.5em 3.5em auto;
|
bottom: 8.5em;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Rotate Control */
|
/* Rotate Control - Above Locate */
|
||||||
.ol-rotate {
|
.ol-rotate {
|
||||||
inset: auto 0.5em 5em auto;
|
top: auto !important;
|
||||||
|
left: auto !important;
|
||||||
|
bottom: 9em;
|
||||||
|
right: 0.5em;
|
||||||
}
|
}
|
||||||
|
|
||||||
.ol-touch .ol-rotate {
|
.ol-touch .ol-rotate {
|
||||||
inset: auto 0.5em 6em auto;
|
bottom: 11.5em;
|
||||||
}
|
}
|
||||||
|
|
||||||
span.icon {
|
span.icon {
|
||||||
@@ -649,6 +675,63 @@ span.icon {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Map Crosshair for "Create Place" mode */
|
||||||
|
.map-crosshair {
|
||||||
|
position: absolute;
|
||||||
|
/* Default Center */
|
||||||
|
top: 50%;
|
||||||
|
left: 50%;
|
||||||
|
width: 24px;
|
||||||
|
height: 24px;
|
||||||
|
transform: translate(-50%, -50%);
|
||||||
|
color: #333;
|
||||||
|
pointer-events: none;
|
||||||
|
z-index: 2000;
|
||||||
|
display: none;
|
||||||
|
transition:
|
||||||
|
top 0.3s ease,
|
||||||
|
left 0.3s ease;
|
||||||
|
}
|
||||||
|
|
||||||
|
.map-crosshair.visible {
|
||||||
|
display: block;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Sidebar is open (Desktop: Left 300px) */
|
||||||
|
/* We want to center in the remaining space (width - 300px) */
|
||||||
|
/* Center X = 300 + (width - 300) / 2 = 300 + width/2 - 150 = width/2 + 150 */
|
||||||
|
/* So shift left by 150px from center */
|
||||||
|
.map-container.sidebar-open .map-crosshair {
|
||||||
|
left: calc(50% + 150px);
|
||||||
|
}
|
||||||
|
|
||||||
|
@media (width <= 768px) {
|
||||||
|
/* Sidebar/Bottom Sheet is open (Mobile: Bottom 50%) */
|
||||||
|
/* Center Y = (height/2) / 2 = height/4 = 25% */
|
||||||
|
.map-container.sidebar-open .map-crosshair {
|
||||||
|
left: 50%; /* Reset desktop shift */
|
||||||
|
top: 25%;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
.helper-text {
|
||||||
|
background: #eef4fc;
|
||||||
|
color: #1a5c9b;
|
||||||
|
padding: 0.75rem;
|
||||||
|
border-radius: 4px;
|
||||||
|
font-size: 0.9rem;
|
||||||
|
margin-top: 0;
|
||||||
|
margin-bottom: 1rem;
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
button.create-place {
|
||||||
|
width: 100%;
|
||||||
|
margin: 1.5rem auto;
|
||||||
|
}
|
||||||
|
|
||||||
@media (width <= 768px) {
|
@media (width <= 768px) {
|
||||||
.sidebar {
|
.sidebar {
|
||||||
width: 100%;
|
width: 100%;
|
||||||
|
|||||||
@@ -21,13 +21,14 @@ export default class ApplicationComponent extends Component {
|
|||||||
// This helps the map know if it should shift the center or adjust view.
|
// This helps the map know if it should shift the center or adjust view.
|
||||||
return (
|
return (
|
||||||
this.router.currentRouteName === 'place' ||
|
this.router.currentRouteName === 'place' ||
|
||||||
|
this.router.currentRouteName === 'place.new' ||
|
||||||
this.router.currentRouteName === 'search'
|
this.router.currentRouteName === 'search'
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
constructor() {
|
constructor() {
|
||||||
super(...arguments);
|
super(...arguments);
|
||||||
console.log('Application component constructed');
|
console.debug('Application component constructed');
|
||||||
// Access the service to ensure it is instantiated
|
// Access the service to ensure it is instantiated
|
||||||
this.storage;
|
this.storage;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -63,7 +63,7 @@ export default class PlaceTemplate extends Component {
|
|||||||
|
|
||||||
@action
|
@action
|
||||||
handleUpdate(newPlace) {
|
handleUpdate(newPlace) {
|
||||||
console.log('Updating local place state:', newPlace);
|
console.debug('Updating local place state:', newPlace);
|
||||||
this.localPlace = newPlace;
|
this.localPlace = newPlace;
|
||||||
this.storage.notifyChange();
|
this.storage.notifyChange();
|
||||||
}
|
}
|
||||||
@@ -77,11 +77,11 @@ export default class PlaceTemplate extends Component {
|
|||||||
navigateBack(place) {
|
navigateBack(place) {
|
||||||
// The sidebar calls this with null when "Back" is clicked.
|
// The sidebar calls this with null when "Back" is clicked.
|
||||||
if (place === null) {
|
if (place === null) {
|
||||||
// If we have history, go back (preserves search state)
|
// If we came from search results, go back in history
|
||||||
if (window.history.length > 1) {
|
if (this.mapUi.returnToSearch) {
|
||||||
window.history.back();
|
window.history.back();
|
||||||
} else {
|
} else {
|
||||||
// Fallback if opened directly
|
// Otherwise just close the sidebar (return to map index)
|
||||||
this.router.transitionTo('index');
|
this.router.transitionTo('index');
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
|
|||||||
83
app/templates/place/new.gjs
Normal file
83
app/templates/place/new.gjs
Normal file
@@ -0,0 +1,83 @@
|
|||||||
|
import Component from '@glimmer/component';
|
||||||
|
import { service } from '@ember/service';
|
||||||
|
import { action } from '@ember/object';
|
||||||
|
import { on } from '@ember/modifier';
|
||||||
|
import PlaceEditForm from '#components/place-edit-form';
|
||||||
|
import Icon from '#components/icon';
|
||||||
|
|
||||||
|
export default class PlaceNewTemplate extends Component {
|
||||||
|
@service router;
|
||||||
|
@service storage;
|
||||||
|
@service mapUi;
|
||||||
|
|
||||||
|
get initialPlace() {
|
||||||
|
return {
|
||||||
|
title: '',
|
||||||
|
description: '',
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
close() {
|
||||||
|
this.router.transitionTo('index');
|
||||||
|
}
|
||||||
|
|
||||||
|
@action
|
||||||
|
async savePlace(changes) {
|
||||||
|
try {
|
||||||
|
// Use coordinates from Map UI (which tracks the crosshair center)
|
||||||
|
// Fallback to URL params if map state isn't ready
|
||||||
|
const center = this.mapUi.creationCoordinates || {
|
||||||
|
lat: this.args.model.lat,
|
||||||
|
lon: this.args.model.lon,
|
||||||
|
};
|
||||||
|
|
||||||
|
const lat = parseFloat(center.lat.toFixed(6));
|
||||||
|
const lon = parseFloat(center.lon.toFixed(6));
|
||||||
|
|
||||||
|
const placeData = {
|
||||||
|
title: changes.title || 'Untitled Place',
|
||||||
|
description: changes.description,
|
||||||
|
lat: lat,
|
||||||
|
lon: lon,
|
||||||
|
tags: [],
|
||||||
|
osmTags: {},
|
||||||
|
};
|
||||||
|
|
||||||
|
const savedPlace = await this.storage.storePlace(placeData);
|
||||||
|
console.debug('Created private place:', savedPlace.title);
|
||||||
|
|
||||||
|
// Transition to the new place
|
||||||
|
this.router.replaceWith('place', savedPlace);
|
||||||
|
} catch (e) {
|
||||||
|
console.error('Failed to create place:', e);
|
||||||
|
alert('Failed to create place: ' + e.message);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
<template>
|
||||||
|
<div class="sidebar">
|
||||||
|
<div class="sidebar-header">
|
||||||
|
<h2><Icon @name="plus-circle" @size={{20}} @color="#ea4335" />
|
||||||
|
New Place</h2>
|
||||||
|
<button type="button" class="close-btn" {{on "click" this.close}}><Icon
|
||||||
|
@name="x"
|
||||||
|
@size={{20}}
|
||||||
|
@color="#333"
|
||||||
|
/></button>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<div class="sidebar-content">
|
||||||
|
<p class="helper-text">
|
||||||
|
Drag the map to position the crosshair.
|
||||||
|
</p>
|
||||||
|
|
||||||
|
<PlaceEditForm
|
||||||
|
@place={{this.initialPlace}}
|
||||||
|
@onSave={{this.savePlace}}
|
||||||
|
@onCancel={{this.close}}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</template>
|
||||||
|
}
|
||||||
@@ -5,10 +5,12 @@ import { action } from '@ember/object';
|
|||||||
|
|
||||||
export default class SearchTemplate extends Component {
|
export default class SearchTemplate extends Component {
|
||||||
@service router;
|
@service router;
|
||||||
|
@service mapUi;
|
||||||
|
|
||||||
@action
|
@action
|
||||||
selectPlace(place) {
|
selectPlace(place) {
|
||||||
if (place) {
|
if (place) {
|
||||||
|
this.mapUi.returnToSearch = true;
|
||||||
this.router.transitionTo('place', place);
|
this.router.transitionTo('place', place);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
32
app/utils/osm.js
Normal file
32
app/utils/osm.js
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
export function getLocalizedName(tags, defaultName = 'Untitled Place') {
|
||||||
|
if (!tags) return defaultName;
|
||||||
|
|
||||||
|
// 1. Get user's preferred languages
|
||||||
|
const languages = navigator.languages || [navigator.language || 'en'];
|
||||||
|
|
||||||
|
// 2. Try to find a match for each preferred language
|
||||||
|
for (const lang of languages) {
|
||||||
|
if (!lang) continue;
|
||||||
|
|
||||||
|
// Handle "en-US", "de-DE", etc. -> look for "name:en", "name:de"
|
||||||
|
const shortLang = lang.split('-')[0];
|
||||||
|
const tagKey = `name:${shortLang}`;
|
||||||
|
|
||||||
|
if (tags[tagKey]) {
|
||||||
|
return tags[tagKey];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 3. Fallback to standard "name"
|
||||||
|
if (tags.name) {
|
||||||
|
return tags.name;
|
||||||
|
}
|
||||||
|
|
||||||
|
// 4. Fallback to "name:en" (common in international places without local name)
|
||||||
|
if (tags['name:en']) {
|
||||||
|
return tags['name:en'];
|
||||||
|
}
|
||||||
|
|
||||||
|
// 5. Final fallback
|
||||||
|
return defaultName;
|
||||||
|
}
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "marco",
|
"name": "marco",
|
||||||
"version": "1.9.0",
|
"version": "1.11.4",
|
||||||
"private": true,
|
"private": true,
|
||||||
"description": "Unhosted maps app",
|
"description": "Unhosted maps app",
|
||||||
"repository": {
|
"repository": {
|
||||||
@@ -34,6 +34,7 @@
|
|||||||
"lint:js:fix": "eslint . --fix",
|
"lint:js:fix": "eslint . --fix",
|
||||||
"start": "vite",
|
"start": "vite",
|
||||||
"test": "vite build --mode development && testem ci --port 0",
|
"test": "vite build --mode development && testem ci --port 0",
|
||||||
|
"preversion": "pnpm test",
|
||||||
"version": "pnpm build && git add release/"
|
"version": "pnpm build && git add release/"
|
||||||
},
|
},
|
||||||
"devDependencies": {
|
"devDependencies": {
|
||||||
|
|||||||
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
1
release/assets/main-G8wPYi_P.css
Normal file
1
release/assets/main-G8wPYi_P.css
Normal file
File diff suppressed because one or more lines are too long
2
release/assets/main-ji2SNMnp.js
Normal file
2
release/assets/main-ji2SNMnp.js
Normal file
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
@@ -26,8 +26,8 @@
|
|||||||
<meta name="msapplication-TileColor" content="#F6E9A6">
|
<meta name="msapplication-TileColor" content="#F6E9A6">
|
||||||
<meta name="msapplication-TileImage" content="/icons/icon-144.png">
|
<meta name="msapplication-TileImage" content="/icons/icon-144.png">
|
||||||
|
|
||||||
<script type="module" crossorigin src="/assets/main-DwYp7tls.js"></script>
|
<script type="module" crossorigin src="/assets/main-ji2SNMnp.js"></script>
|
||||||
<link rel="stylesheet" crossorigin href="/assets/main-BZSIy5va.css">
|
<link rel="stylesheet" crossorigin href="/assets/main-G8wPYi_P.css">
|
||||||
</head>
|
</head>
|
||||||
<body>
|
<body>
|
||||||
</body>
|
</body>
|
||||||
|
|||||||
106
tests/acceptance/navigation-test.js
Normal file
106
tests/acceptance/navigation-test.js
Normal file
@@ -0,0 +1,106 @@
|
|||||||
|
import { module, test } from 'qunit';
|
||||||
|
import { visit, currentURL, click, settled } from '@ember/test-helpers';
|
||||||
|
import { setupApplicationTest } from 'marco/tests/helpers';
|
||||||
|
import Service from '@ember/service';
|
||||||
|
import sinon from 'sinon';
|
||||||
|
|
||||||
|
class MockOsmService extends Service {
|
||||||
|
async getNearbyPois() {
|
||||||
|
return [
|
||||||
|
{
|
||||||
|
osmId: '123',
|
||||||
|
lat: 1,
|
||||||
|
lon: 1,
|
||||||
|
osmTags: { name: 'Test Place', amenity: 'cafe' },
|
||||||
|
osmType: 'node',
|
||||||
|
},
|
||||||
|
];
|
||||||
|
}
|
||||||
|
async getPoiById() {
|
||||||
|
return {
|
||||||
|
osmId: '123',
|
||||||
|
lat: 1,
|
||||||
|
lon: 1,
|
||||||
|
osmTags: { name: 'Test Place', amenity: 'cafe' },
|
||||||
|
osmType: 'node',
|
||||||
|
};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
class MockStorageService extends Service {
|
||||||
|
savedPlaces = [];
|
||||||
|
findPlaceById() {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
loadPlacesInBounds() {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
get placesInView() {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
rs = {
|
||||||
|
on: () => {},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
module('Acceptance | navigation', function (hooks) {
|
||||||
|
setupApplicationTest(hooks);
|
||||||
|
|
||||||
|
hooks.beforeEach(function () {
|
||||||
|
this.owner.register('service:osm', MockOsmService);
|
||||||
|
this.owner.register('service:storage', MockStorageService);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('navigating from search results to place and back uses history', async function (assert) {
|
||||||
|
const mapUi = this.owner.lookup('service:map-ui');
|
||||||
|
const backStub = sinon.stub(window.history, 'back');
|
||||||
|
|
||||||
|
try {
|
||||||
|
await visit('/search?lat=1&lon=1');
|
||||||
|
assert.strictEqual(currentURL(), '/search?lat=1&lon=1');
|
||||||
|
|
||||||
|
await click('.place-item');
|
||||||
|
assert.ok(currentURL().includes('/place/'), 'Navigated to place');
|
||||||
|
assert.true(mapUi.returnToSearch, 'Flag returnToSearch is set');
|
||||||
|
|
||||||
|
// Click the back button in the sidebar
|
||||||
|
await click('.back-btn');
|
||||||
|
|
||||||
|
assert.true(backStub.calledOnce, 'window.history.back() was called');
|
||||||
|
} finally {
|
||||||
|
backStub.restore();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test('closing the sidebar resets the returnToSearch flag', async function (assert) {
|
||||||
|
const mapUi = this.owner.lookup('service:map-ui');
|
||||||
|
|
||||||
|
await visit('/search?lat=1&lon=1');
|
||||||
|
await click('.place-item'); // Sets returnToSearch = true
|
||||||
|
|
||||||
|
assert.true(mapUi.returnToSearch, 'Flag is set upon entering place');
|
||||||
|
|
||||||
|
// Click the Close (X) button
|
||||||
|
await click('.close-btn');
|
||||||
|
|
||||||
|
|
||||||
|
assert.strictEqual(currentURL(), '/', 'Returned to index');
|
||||||
|
assert.false(mapUi.returnToSearch, 'Flag is reset after closing sidebar');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('navigating directly to place and back closes sidebar', async function (assert) {
|
||||||
|
const backStub = sinon.stub(window.history, 'back');
|
||||||
|
try {
|
||||||
|
await visit('/place/osm:node:123');
|
||||||
|
assert.ok(currentURL().includes('/place/'), 'Visited place directly');
|
||||||
|
|
||||||
|
await click('.back-btn');
|
||||||
|
|
||||||
|
|
||||||
|
assert.strictEqual(currentURL(), '/', 'Returned to index/map');
|
||||||
|
assert.true(backStub.notCalled, 'window.history.back() was NOT called');
|
||||||
|
} finally {
|
||||||
|
backStub.restore();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in New Issue
Block a user