Don't load actual map tiles in tests

We don't need remote tiles for testing our functionality
1.24.0
2026-06-06 12:34:59 +04:00 · 2026-06-06 12:12:06 +04:00
7 changed files with 27 additions and 58 deletions
@@ -20,6 +20,7 @@ import { Style, Circle, Fill, Stroke, Icon } from 'ol/style.js';
 import { apply } from 'ol-mapbox-style';
 import { getIcon } from '../utils/icons';
 import { getIconNameForTags } from '../utils/osm-icons';
+import config from 'marco/config/environment';

 export default class MapComponent extends Component {
  @service osm;
@@ -286,9 +287,26 @@ export default class MapComponent extends Component {
    this.mapUi.updateCenter(initialCenter[1], initialCenter[0]);
    this.mapUi.updateZoom(view.getZoom());

-    apply(this.mapInstance, 'https://tiles.openfreemap.org/styles/liberty', {
-      webfonts: 'data:text/css,',
-    });
+    if (config.environment === 'test') {
+      apply(this.mapInstance, {
+        version: 8,
+        name: 'Test Style',
+        sources: {},
+        layers: [
+          {
+            id: 'background',
+            type: 'background',
+            paint: {
+              'background-color': '#f8f4f0',
+            },
+          },
+        ],
+      });
+    } else {
+      apply(this.mapInstance, 'https://tiles.openfreemap.org/styles/liberty', {
+        webfonts: 'data:text/css,',
+      });
+    }

    this.searchOverlayElement = document.createElement('div');
    this.searchOverlayElement.className = 'search-pulse';
@@ -1,6 +1,6 @@
 {
  "name": "marco",
-  "version": "1.23.0",
+  "version": "1.24.0",
  "private": true,
  "description": "Unhosted maps app",
  "repository": {
@@ -39,7 +39,7 @@
    <meta name="msapplication-TileColor" content="#F6E9A6">
    <meta name="msapplication-TileImage" content="/icons/icon-144.png">

-  <script type="module" crossorigin src="/assets/main-DSyq2vVy.js"></script>
+  <script type="module" crossorigin src="/assets/main-CLZV93ov.js"></script>
  <link rel="stylesheet" crossorigin href="/assets/main-COnSXoPt.css">
 </head>
  <body>
@@ -2,7 +2,6 @@ import { module, test } from 'qunit';
 import { visit, currentURL, waitFor, triggerEvent } from '@ember/test-helpers';
 import { setupApplicationTest } from 'marco/tests/helpers';
 import Service from '@ember/service';
-import sinon from 'sinon';

 module('Acceptance | map search reset', function (hooks) {
  setupApplicationTest(hooks);
@@ -17,58 +16,10 @@ module('Acceptance | map search reset', function (hooks) {
      'marco:map-view',
      JSON.stringify(highZoomState)
    );
-
-    // Stub window.fetch using Sinon
-    // We want to intercept map style requests and let everything else through
-    this.fetchStub = sinon.stub(window, 'fetch');
-
-    this.fetchStub.callsFake(async (input, init) => {
-      let url = input;
-      if (typeof input === 'object' && input !== null && 'url' in input) {
-        url = input.url;
-      }
-
-      if (
-        typeof url === 'string' &&
-        url.includes('tiles.openfreemap.org/styles/liberty')
-      ) {
-        return {
-          ok: true,
-          status: 200,
-          json: async () => ({
-            version: 8,
-            name: 'Liberty',
-            sources: {
-              openmaptiles: {
-                type: 'vector',
-                url: 'https://tiles.openfreemap.org/planet',
-              },
-            },
-            layers: [
-              {
-                id: 'background',
-                type: 'background',
-                paint: {
-                  'background-color': '#123456',
-                },
-              },
-            ],
-            glyphs:
-              'https://tiles.openfreemap.org/fonts/{fontstack}/{range}.pbf',
-            sprite: 'https://tiles.openfreemap.org/sprites/liberty',
-          }),
-        };
-      }
-
-      // Pass through to the original implementation
-      return this.fetchStub.wrappedMethod(input, init);
-    });
  });

  hooks.afterEach(function () {
    window.localStorage.removeItem('marco:map-view');
-    // Restore the original fetch
-    this.fetchStub.restore();
  });

  test('clicking the map clears the category search parameter', async function (assert) {
Author	SHA1	Message	Date
raucao	f0a19e30b8	Don't load actual map tiles in tests CI / Lint (pull_request) Successful in 31s Details CI / Test (pull_request) Failing after 1m6s Details Release Drafter / Update release notes draft (pull_request) Successful in 4s Details We don't need remote tiles for testing our functionality	2026-06-06 12:34:59 +04:00
raucao	59bc5ca046	1.24.0 CI / Lint (push) Successful in 31s Details CI / Test (push) Successful in 55s Details	2026-06-06 12:12:06 +04:00