6 Commits

Author SHA1 Message Date
43b2700465 Don't start nearby search when unfocusing search by clicking map 2026-02-20 19:48:41 +04:00
00454c8fab Integrate the menu button in the search box
Allows us to make the search box wider, too
2026-02-20 18:35:01 +04:00
bf12305600 Add full-text search
Add a search box with a quick results popover, as well full results in
the sidebar on pressing enter.
2026-02-20 12:39:04 +04:00
2734f08608 Formatting 2026-02-20 12:38:57 +04:00
2aa59f9384 Fetch place details from OSM API, support relations
* Much faster
* Has more place details, which allows us to locate relations, in
  addition to nodes and ways
2026-02-20 12:34:48 +04:00
bcf8ca4255 Add service for Photon requests 2026-02-19 16:28:07 +04:00
25 changed files with 1491 additions and 116 deletions

View File

@@ -5,6 +5,7 @@ import { action } from '@ember/object';
import { on } from '@ember/modifier'; import { on } from '@ember/modifier';
import Icon from '#components/icon'; import Icon from '#components/icon';
import UserMenu from '#components/user-menu'; import UserMenu from '#components/user-menu';
import SearchBox from '#components/search-box';
export default class AppHeaderComponent extends Component { export default class AppHeaderComponent extends Component {
@service storage; @service storage;
@@ -23,14 +24,7 @@ export default class AppHeaderComponent extends Component {
<template> <template>
<header class="app-header"> <header class="app-header">
<div class="header-left"> <div class="header-left">
<button <SearchBox @onToggleMenu={{@onToggleMenu}} />
class="menu-btn btn-press"
type="button"
aria-label="Menu"
{{on "click" @onToggleMenu}}
>
<Icon @name="menu" @size={{24}} @color="#333" />
</button>
</div> </div>
<div class="header-right"> <div class="header-right">

View File

@@ -17,6 +17,7 @@ import navigation from 'feather-icons/dist/icons/navigation.svg?raw';
import phone from 'feather-icons/dist/icons/phone.svg?raw'; import phone from 'feather-icons/dist/icons/phone.svg?raw';
import plus from 'feather-icons/dist/icons/plus.svg?raw'; import plus from 'feather-icons/dist/icons/plus.svg?raw';
import server from 'feather-icons/dist/icons/server.svg?raw'; import server from 'feather-icons/dist/icons/server.svg?raw';
import search from 'feather-icons/dist/icons/search.svg?raw';
import settings from 'feather-icons/dist/icons/settings.svg?raw'; import settings from 'feather-icons/dist/icons/settings.svg?raw';
import target from 'feather-icons/dist/icons/target.svg?raw'; import target from 'feather-icons/dist/icons/target.svg?raw';
import user from 'feather-icons/dist/icons/user.svg?raw'; import user from 'feather-icons/dist/icons/user.svg?raw';
@@ -40,6 +41,7 @@ const ICONS = {
phone, phone,
plus, plus,
server, server,
search,
settings, settings,
target, target,
user, user,

View File

@@ -33,6 +33,7 @@ export default class MapComponent extends Component {
selectedPinElement; selectedPinElement;
crosshairElement; crosshairElement;
crosshairOverlay; crosshairOverlay;
ignoreNextMapClick = false;
setupMap = modifier((element) => { setupMap = modifier((element) => {
if (this.mapInstance) return; if (this.mapInstance) return;
@@ -110,6 +111,10 @@ export default class MapComponent extends Component {
}), }),
}); });
// Initialize the UI service with the map center
const initialCenter = toLonLat(view.getCenter());
this.mapUi.updateCenter(initialCenter[1], initialCenter[0]);
apply(this.mapInstance, 'https://tiles.openfreemap.org/styles/liberty'); apply(this.mapInstance, 'https://tiles.openfreemap.org/styles/liberty');
this.searchOverlayElement = document.createElement('div'); this.searchOverlayElement = document.createElement('div');
@@ -155,9 +160,6 @@ export default class MapComponent extends Component {
`; `;
element.appendChild(this.crosshairElement); element.appendChild(this.crosshairElement);
// Geolocation Pulse Overlay // Geolocation Pulse Overlay
this.locationOverlayElement = document.createElement('div'); this.locationOverlayElement = document.createElement('div');
this.locationOverlayElement.className = 'search-pulse blue'; this.locationOverlayElement.className = 'search-pulse blue';
@@ -168,6 +170,18 @@ export default class MapComponent extends Component {
}); });
this.mapInstance.addOverlay(this.locationOverlay); this.mapInstance.addOverlay(this.locationOverlay);
// Track search box focus state on pointer down to handle race conditions
// The blur event fires before click, so we need to capture state here
element.addEventListener(
'pointerdown',
() => {
if (this.mapUi.searchBoxHasFocus) {
this.ignoreNextMapClick = true;
}
},
true
);
// Geolocation Setup // Geolocation Setup
const geolocation = new Geolocation({ const geolocation = new Geolocation({
trackingOptions: { trackingOptions: {
@@ -311,7 +325,7 @@ export default class MapComponent extends Component {
}; };
const startLocating = () => { const startLocating = () => {
console.debug('Getting current geolocation...') console.debug('Getting current geolocation...');
// 1. Clear any previous session // 1. Clear any previous session
stopLocating(); stopLocating();
@@ -374,7 +388,11 @@ export default class MapComponent extends Component {
if (!this.mapInstance) return; if (!this.mapInstance) return;
// Remove existing DragPan interactions // Remove existing DragPan interactions
this.mapInstance.getInteractions().getArray().slice().forEach((interaction) => { this.mapInstance
.getInteractions()
.getArray()
.slice()
.forEach((interaction) => {
if (interaction instanceof DragPan) { if (interaction instanceof DragPan) {
this.mapInstance.removeInteraction(interaction); this.mapInstance.removeInteraction(interaction);
} }
@@ -644,18 +662,29 @@ export default class MapComponent extends Component {
handleMapMove = async () => { handleMapMove = async () => {
if (!this.mapInstance) return; if (!this.mapInstance) return;
const view = this.mapInstance.getView();
const center = toLonLat(view.getCenter());
this.mapUi.updateCenter(center[1], center[0]);
// If in creation mode, update the coordinates in the service AND the URL // If in creation mode, update the coordinates in the service AND the URL
if (this.mapUi.isCreating) { if (this.mapUi.isCreating) {
// Calculate coordinates under the crosshair element // Calculate coordinates under the crosshair element
// We need the pixel position of the crosshair relative to the map viewport // We need the pixel position of the crosshair relative to the map viewport
// The crosshair is positioned via CSS, so we can use getBoundingClientRect // The crosshair is positioned via CSS, so we can use getBoundingClientRect
const mapRect = this.mapInstance.getTargetElement().getBoundingClientRect(); const mapRect = this.mapInstance
.getTargetElement()
.getBoundingClientRect();
const crosshairRect = this.crosshairElement.getBoundingClientRect(); const crosshairRect = this.crosshairElement.getBoundingClientRect();
const centerX = crosshairRect.left + crosshairRect.width / 2 - mapRect.left; const centerX =
const centerY = crosshairRect.top + crosshairRect.height / 2 - mapRect.top; crosshairRect.left + crosshairRect.width / 2 - mapRect.left;
const centerY =
crosshairRect.top + crosshairRect.height / 2 - mapRect.top;
const coordinate = this.mapInstance.getCoordinateFromPixel([centerX, centerY]); const coordinate = this.mapInstance.getCoordinateFromPixel([
centerX,
centerY,
]);
const center = toLonLat(coordinate); const center = toLonLat(coordinate);
const lat = parseFloat(center[1].toFixed(6)); const lat = parseFloat(center[1].toFixed(6));
@@ -695,6 +724,11 @@ export default class MapComponent extends Component {
}; };
handleMapClick = async (event) => { handleMapClick = async (event) => {
if (this.ignoreNextMapClick) {
this.ignoreNextMapClick = false;
return;
}
// Check if user clicked on a rendered feature (POI or Bookmark) FIRST // Check if user clicked on a rendered feature (POI or Bookmark) FIRST
const features = this.mapInstance.getFeaturesAtPixel(event.pixel, { const features = this.mapInstance.getFeaturesAtPixel(event.pixel, {
hitTolerance: 10, hitTolerance: 10,
@@ -780,10 +814,9 @@ export default class MapComponent extends Component {
const queryParams = { const queryParams = {
lat: lat.toFixed(6), lat: lat.toFixed(6),
lon: lon.toFixed(6), lon: lon.toFixed(6),
q: null, // Clear q to force spatial search
selected: selectedFeatureName || null,
}; };
if (selectedFeatureName) {
queryParams.q = selectedFeatureName;
}
this.router.transitionTo('search', { queryParams }); this.router.transitionTo('search', { queryParams });
}; };

View File

@@ -21,11 +21,7 @@ export default class PlaceDetails extends Component {
} }
get name() { get name() {
return ( return this.place.title || getLocalizedName(this.tags) || 'Unnamed Place';
this.place.title ||
getLocalizedName(this.tags) ||
'Unnamed Place'
);
} }
@action @action
@@ -129,7 +125,7 @@ export default class PlaceDetails extends Component {
const lat = this.place.lat; const lat = this.place.lat;
const lon = this.place.lon; const lon = this.place.lon;
if (!lat || !lon) return ''; if (!lat || !lon) return '';
return `${lat}, ${lon}`; return `${Number(lat).toFixed(6)}, ${Number(lon).toFixed(6)}`;
} }
get osmUrl() { get osmUrl() {
@@ -274,7 +270,11 @@ export default class PlaceDetails extends Component {
<p class="content-with-icon"> <p class="content-with-icon">
<Icon @name="map" /> <Icon @name="map" />
<span> <span>
<a href={{this.gmapsUrl}} target="_blank" rel="noopener noreferrer"> <a
href={{this.gmapsUrl}}
target="_blank"
rel="noopener noreferrer"
>
Google Maps Google Maps
</a> </a>
</span> </span>

View File

@@ -24,7 +24,9 @@ export default class PlacesSidebar extends Component {
this.router.transitionTo('place.new', { queryParams: { lat, lon } }); this.router.transitionTo('place.new', { queryParams: { lat, lon } });
} else { } else {
// Fallback (shouldn't happen in search context) // Fallback (shouldn't happen in search context)
this.router.transitionTo('place.new', { queryParams: { lat: 0, lon: 0 } }); this.router.transitionTo('place.new', {
queryParams: { lat: 0, lon: 0 },
});
} }
} }
@@ -184,14 +186,16 @@ export default class PlacesSidebar extends Component {
place.osmTags.name:en place.osmTags.name:en
"Unnamed Place" "Unnamed Place"
}}</div> }}</div>
<div class="place-type">{{humanizeOsmTag (or <div class="place-type">{{humanizeOsmTag
(or
place.osmTags.amenity place.osmTags.amenity
place.osmTags.shop place.osmTags.shop
place.osmTags.tourism place.osmTags.tourism
place.osmTags.leisure place.osmTags.leisure
place.osmTags.historic place.osmTags.historic
"Point of Interest" "Point of Interest"
)}}</div> )
}}</div>
</button> </button>
</li> </li>
{{/each}} {{/each}}

View File

@@ -0,0 +1,193 @@
import Component from '@glimmer/component';
import { service } from '@ember/service';
import { tracked } from '@glimmer/tracking';
import { action } from '@ember/object';
import { on } from '@ember/modifier';
import { fn } from '@ember/helper';
import { task, timeout } from 'ember-concurrency';
import Icon from '#components/icon';
export default class SearchBoxComponent extends Component {
@service photon;
@service router;
@service mapUi;
@service map; // Assuming we might need map context, but mostly we use router
@tracked query = '';
@tracked results = [];
@tracked isFocused = false;
@tracked isLoading = false;
get showPopover() {
return this.isFocused && this.results.length > 0;
}
@action
handleInput(event) {
this.query = event.target.value;
if (this.query.length < 2) {
this.results = [];
return;
}
this.searchTask.perform();
}
searchTask = task({ restartable: true }, async () => {
await timeout(300);
if (this.query.length < 2) return;
this.isLoading = true;
try {
// Use map center if available for location bias
let lat, lon;
if (this.mapUi.currentCenter) {
({ lat, lon } = this.mapUi.currentCenter);
}
const results = await this.photon.search(this.query, lat, lon);
this.results = results;
} catch (e) {
console.error('Search failed', e);
this.results = [];
} finally {
this.isLoading = false;
}
});
@action
handleFocus() {
this.isFocused = true;
this.mapUi.setSearchBoxFocus(true);
if (this.query.length >= 2 && this.results.length === 0) {
this.searchTask.perform();
}
}
@action
handleBlur() {
// Delay hiding so clicks on results can register
setTimeout(() => {
this.isFocused = false;
this.mapUi.setSearchBoxFocus(false);
}, 300);
}
@action
handleSubmit(event) {
event.preventDefault();
if (!this.query) return;
let queryParams = { q: this.query, selected: null };
if (this.mapUi.currentCenter) {
const { lat, lon } = this.mapUi.currentCenter;
queryParams.lat = parseFloat(lat).toFixed(4);
queryParams.lon = parseFloat(lon).toFixed(4);
}
this.router.transitionTo('search', { queryParams });
this.isFocused = false;
}
@action
selectResult(place) {
this.query = place.title;
this.results = []; // Hide popover
// If it has an OSM ID, go to place details
if (place.osmId) {
// Format: osm:node:123
// place.osmType is already normalized to 'node', 'way', or 'relation' by PhotonService
const id = `osm:${place.osmType}:${place.osmId}`;
this.router.transitionTo('place', id);
} else {
// Just a location (e.g. from Photon without OSM ID, though unlikely for Photon)
// Or we can treat it as a search query
this.router.transitionTo('search', {
queryParams: {
q: place.title,
lat: place.lat,
lon: place.lon,
selected: null,
},
});
}
}
@action
clear() {
this.query = '';
this.results = [];
this.router.transitionTo('index'); // Or stay on current page?
// Usually clear just clears the input.
}
<template>
<div class="search-box">
<form class="search-form" {{on "submit" this.handleSubmit}}>
<button
type="button"
class="menu-btn-integrated"
aria-label="Menu"
{{on "click" @onToggleMenu}}
>
<Icon @name="menu" @size={{24}} @color="#5f6368" />
</button>
<input
type="search"
class="search-input"
placeholder="Search places..."
aria-label="Search places"
value={{this.query}}
{{on "input" this.handleInput}}
{{on "focus" this.handleFocus}}
{{on "blur" this.handleBlur}}
autocomplete="off"
/>
<button type="submit" class="search-submit-btn" aria-label="Search">
<Icon @name="search" @size={{20}} @color="#5f6368" />
</button>
{{#if this.query}}
<button
type="button"
class="search-clear-btn"
{{on "click" this.clear}}
aria-label="Clear"
>
<Icon @name="x" @size={{16}} @color="#5f6368" />
</button>
{{/if}}
</form>
{{#if this.showPopover}}
<div class="search-results-popover">
<ul class="search-results-list">
{{#each this.results as |result|}}
<li>
<button
type="button"
class="search-result-item"
{{on "click" (fn this.selectResult result)}}
>
<div class="result-icon">
<Icon @name="map-pin" @size={{16}} @color="#666" />
</div>
<div class="result-info">
<span class="result-title">{{result.title}}</span>
{{#if result.description}}
<span class="result-desc">{{result.description}}</span>
{{/if}}
</div>
</button>
</li>
{{/each}}
</ul>
</div>
{{/if}}
</div>
</template>
}

View File

@@ -62,7 +62,10 @@ export default class SettingsPane extends Component {
{{#each this.settings.overpassApis as |api|}} {{#each this.settings.overpassApis as |api|}}
<option <option
value={{api.url}} value={{api.url}}
selected={{if (eq api.url this.settings.overpassApi) "selected"}} selected={{if
(eq api.url this.settings.overpassApi)
"selected"
}}
> >
{{api.name}} {{api.name}}
</option> </option>
@@ -73,24 +76,45 @@ export default class SettingsPane extends Component {
<section class="settings-section"> <section class="settings-section">
<h3>About</h3> <h3>About</h3>
<p> <p>
<strong>Marco</strong> (as in <a <strong>Marco</strong>
(as in
<a
href="https://en.wikipedia.org/wiki/Marco_Polo" href="https://en.wikipedia.org/wiki/Marco_Polo"
target="_blank" rel="noopener">Marco Polo</a>) is an unhosted maps application target="_blank"
that respects your privacy and choices. rel="noopener"
>Marco Polo</a>) is an unhosted maps application that respects your
privacy and choices.
</p> </p>
<p> <p>
Connect your own <a href="https://remotestorage.io/" Connect your own
target="_blank" rel="noopener">remote storage</a> to sync place bookmarks across <a
apps and devices. href="https://remotestorage.io/"
target="_blank"
rel="noopener"
>remote storage</a>
to sync place bookmarks across apps and devices.
</p> </p>
<ul class="link-list"> <ul class="link-list">
<li> <li>
<a href="https://gitea.kosmos.org/raucao/marco" target="_blank" rel="noopener"> <a
href="https://gitea.kosmos.org/raucao/marco"
target="_blank"
rel="noopener"
>
Source Code Source Code
</a> (<a href="https://en.wikipedia.org/wiki/GNU_Affero_General_Public_License" target="_blank" rel="noopener">AGPL</a>) </a>
(<a
href="https://en.wikipedia.org/wiki/GNU_Affero_General_Public_License"
target="_blank"
rel="noopener"
>AGPL</a>)
</li> </li>
<li> <li>
<a href="https://openstreetmap.org/copyright" target="_blank" rel="noopener"> <a
href="https://openstreetmap.org/copyright"
target="_blank"
rel="noopener"
>
Map Data © OpenStreetMap Map Data © OpenStreetMap
</a> </a>
</li> </li>

10
app/controllers/search.js Normal file
View File

@@ -0,0 +1,10 @@
import Controller from '@ember/controller';
export default class SearchController extends Controller {
queryParams = ['lat', 'lon', 'q', 'selected'];
lat = null;
lon = null;
q = null;
selected = null;
}

View File

@@ -9,7 +9,11 @@ export default class PlaceRoute extends Route {
async model(params) { async model(params) {
const id = params.place_id; const id = params.place_id;
if (id.startsWith('osm:node:') || id.startsWith('osm:way:')) { if (
id.startsWith('osm:node:') ||
id.startsWith('osm:way:') ||
id.startsWith('osm:relation:')
) {
const [, type, osmId] = id.split(':'); const [, type, osmId] = id.split(':');
console.debug(`Fetching explicit OSM ${type}:`, osmId); console.debug(`Fetching explicit OSM ${type}:`, osmId);
return this.loadOsmPlace(osmId, type); return this.loadOsmPlace(osmId, type);
@@ -62,7 +66,8 @@ export default class PlaceRoute extends Route {
async loadOsmPlace(id, type = null) { async loadOsmPlace(id, type = null) {
try { try {
const poi = await this.osm.getPoiById(id, type); // Use the direct OSM API fetch instead of Overpass for single object lookups
const poi = await this.osm.fetchOsmObject(id, type);
if (poi) { if (poi) {
console.debug('Found OSM POI:', poi); console.debug('Found OSM POI:', poi);
return poi; return poi;

View File

@@ -5,6 +5,7 @@ import { getDistance } from '../utils/geo';
export default class SearchRoute extends Route { export default class SearchRoute extends Route {
@service osm; @service osm;
@service photon;
@service mapUi; @service mapUi;
@service storage; @service storage;
@service router; @service router;
@@ -13,20 +14,46 @@ export default class SearchRoute extends Route {
lat: { refreshModel: true }, lat: { refreshModel: true },
lon: { refreshModel: true }, lon: { refreshModel: true },
q: { refreshModel: true }, q: { refreshModel: true },
selected: { refreshModel: true },
}; };
async model(params) { async model(params) {
// If no coordinates, we can't search const lat = params.lat ? parseFloat(params.lat) : null;
if (!params.lat || !params.lon) { const lon = params.lon ? parseFloat(params.lon) : null;
return []; let pois = [];
// Case 1: Text Search (q parameter present)
if (params.q) {
// Search with Photon (using lat/lon for bias if available)
pois = await this.photon.search(params.q, lat, lon);
// Search local bookmarks by name
const queryLower = params.q.toLowerCase();
const localMatches = this.storage.savedPlaces.filter((p) => {
return (
p.title?.toLowerCase().includes(queryLower) ||
p.description?.toLowerCase().includes(queryLower)
);
});
// Merge local matches
localMatches.forEach((local) => {
const exists = pois.find(
(poi) =>
(local.osmId && poi.osmId === local.osmId) ||
(poi.id && poi.id === local.id)
);
if (!exists) {
pois.push(local);
} }
});
}
// Case 2: Nearby Search (lat/lon present, no q)
else if (lat && lon) {
const searchRadius = 50; // Default radius
const lat = parseFloat(params.lat); // Fetch POIs from Overpass
const lon = parseFloat(params.lon); pois = await this.osm.getNearbyPois(lat, lon, searchRadius);
const searchRadius = params.q ? 30 : 50;
// Fetch POIs
let pois = await this.osm.getNearbyPois(lat, lon, searchRadius);
// Get cached/saved places in search radius // Get cached/saved places in search radius
const localMatches = this.storage.savedPlaces.filter((p) => { const localMatches = this.storage.savedPlaces.filter((p) => {
@@ -34,8 +61,7 @@ export default class SearchRoute extends Route {
return dist <= searchRadius; return dist <= searchRadius;
}); });
// Add local matches to the list if they aren't already there // Merge local matches
// We use osmId to deduplicate if possible
localMatches.forEach((local) => { localMatches.forEach((local) => {
const exists = pois.find( const exists = pois.find(
(poi) => (poi) =>
@@ -57,6 +83,7 @@ export default class SearchRoute extends Route {
}; };
}) })
.sort((a, b) => a._distance - b._distance); .sort((a, b) => a._distance - b._distance);
}
// Check if any of these are already bookmarked // Check if any of these are already bookmarked
// We resolve them to the bookmark version if they exist // We resolve them to the bookmark version if they exist
@@ -69,18 +96,24 @@ export default class SearchRoute extends Route {
} }
afterModel(model, transition) { afterModel(model, transition) {
const { q } = transition.to.queryParams; const { q, selected } = transition.to.queryParams;
// Heuristic Match Logic (ported from MapComponent) // Heuristic Match Logic (ported from MapComponent)
if (q && model.length > 0) { // If 'selected' is provided (from map click), try to find that specific feature.
// If 'q' is provided (from text search), try to find an exact match to auto-select.
const targetName = selected || q;
if (targetName && model.length > 0) {
let matchedPlace = null; let matchedPlace = null;
// 1. Exact Name Match // 1. Exact Name Match
matchedPlace = model.find( matchedPlace = model.find(
(p) => p.osmTags && (p.osmTags.name === q || p.osmTags['name:en'] === q) (p) =>
p.osmTags &&
(p.osmTags.name === targetName || p.osmTags['name:en'] === targetName)
); );
// 2. High Proximity Match (<= 10m) // 2. High Proximity Match (<= 10m) - Only if we don't have a name match
// Note: MapComponent had logic for <=20m + type match. // Note: MapComponent had logic for <=20m + type match.
// We might want to pass the 'type' in queryParams if we want to be that precise. // We might want to pass the 'type' in queryParams if we want to be that precise.
// For now, let's stick to name or very close proximity. // For now, let's stick to name or very close proximity.

View File

@@ -7,6 +7,8 @@ export default class MapUiService extends Service {
@tracked isCreating = false; @tracked isCreating = false;
@tracked creationCoordinates = null; @tracked creationCoordinates = null;
@tracked returnToSearch = false; @tracked returnToSearch = false;
@tracked currentCenter = null;
@tracked searchBoxHasFocus = false;
selectPlace(place) { selectPlace(place) {
this.selectedPlace = place; this.selectedPlace = place;
@@ -38,4 +40,12 @@ export default class MapUiService extends Service {
updateCreationCoordinates(lat, lon) { updateCreationCoordinates(lat, lon) {
this.creationCoordinates = { lat, lon }; this.creationCoordinates = { lat, lon };
} }
setSearchBoxFocus(isFocused) {
this.searchBoxHasFocus = isFocused;
}
updateCenter(lat, lon) {
this.currentCenter = { lat, lon };
}
} }

View File

@@ -124,4 +124,115 @@ out center;
if (!data.elements[0]) return null; if (!data.elements[0]) return null;
return this.normalizePoi(data.elements[0]); return this.normalizePoi(data.elements[0]);
} }
async fetchOsmObject(osmId, osmType) {
if (!osmId || !osmType) return null;
let url;
if (osmType === 'node') {
url = `https://www.openstreetmap.org/api/0.6/node/${osmId}.json`;
} else if (osmType === 'way') {
url = `https://www.openstreetmap.org/api/0.6/way/${osmId}/full.json`;
} else if (osmType === 'relation') {
url = `https://www.openstreetmap.org/api/0.6/relation/${osmId}/full.json`;
} else {
console.error('Unknown OSM type:', osmType);
return null;
}
try {
const res = await this.fetchWithRetry(url);
if (!res.ok) {
if (res.status === 410) {
console.warn('OSM object has been deleted');
return null;
}
throw new Error(`OSM API request failed: ${res.status}`);
}
const data = await res.json();
return this.normalizeOsmApiData(data.elements, osmId, osmType);
} catch (e) {
console.error('Failed to fetch OSM object:', e);
return null;
}
}
normalizeOsmApiData(elements, targetId, targetType) {
if (!elements || elements.length === 0) return null;
const mainElement = elements.find(
(el) => String(el.id) === String(targetId) && el.type === targetType
);
if (!mainElement) return null;
let lat = mainElement.lat;
let lon = mainElement.lon;
// If it's a way, calculate center from nodes
if (targetType === 'way' && mainElement.nodes) {
const nodeMap = new Map();
elements.forEach((el) => {
if (el.type === 'node') {
nodeMap.set(el.id, [el.lon, el.lat]);
}
});
const coords = mainElement.nodes
.map((id) => nodeMap.get(id))
.filter(Boolean);
if (coords.length > 0) {
// Simple average center
const sumLat = coords.reduce((sum, c) => sum + c[1], 0);
const sumLon = coords.reduce((sum, c) => sum + c[0], 0);
lat = sumLat / coords.length;
lon = sumLon / coords.length;
}
} else if (targetType === 'relation' && mainElement.members) {
// Find all nodes that are part of this relation (directly or via ways)
const allNodes = [];
const nodeMap = new Map();
elements.forEach((el) => {
if (el.type === 'node') {
nodeMap.set(el.id, el);
}
});
mainElement.members.forEach((member) => {
if (member.type === 'node') {
const node = nodeMap.get(member.ref);
if (node) allNodes.push(node);
} else if (member.type === 'way') {
const way = elements.find(
(el) => el.type === 'way' && el.id === member.ref
);
if (way && way.nodes) {
way.nodes.forEach((nodeId) => {
const node = nodeMap.get(nodeId);
if (node) allNodes.push(node);
});
}
}
});
if (allNodes.length > 0) {
const sumLat = allNodes.reduce((sum, n) => sum + n.lat, 0);
const sumLon = allNodes.reduce((sum, n) => sum + n.lon, 0);
lat = sumLat / allNodes.length;
lon = sumLon / allNodes.length;
}
}
return {
title: getLocalizedName(mainElement.tags),
lat,
lon,
url: mainElement.tags?.website,
osmId: String(mainElement.id),
osmType: mainElement.type,
osmTags: mainElement.tags || {},
description: mainElement.tags?.description,
};
}
} }

108
app/services/photon.js Normal file
View File

@@ -0,0 +1,108 @@
import Service from '@ember/service';
export default class PhotonService extends Service {
baseUrl = 'https://photon.komoot.io/api/';
async search(query, lat, lon, limit = 10) {
if (!query || query.length < 2) return [];
const params = new URLSearchParams({
q: query,
limit: String(limit),
});
if (lat && lon) {
params.append('lat', parseFloat(lat).toFixed(4));
params.append('lon', parseFloat(lon).toFixed(4));
}
const url = `${this.baseUrl}?${params.toString()}`;
try {
const res = await this.fetchWithRetry(url);
if (!res.ok) {
throw new Error(`Photon request failed with status ${res.status}`);
}
const data = await res.json();
if (!data.features) return [];
return data.features.map((f) => this.normalizeFeature(f));
} catch (e) {
console.error('Photon search error:', e);
// Return empty array on error so UI doesn't break
return [];
}
}
normalizeFeature(feature) {
const props = feature.properties || {};
const geom = feature.geometry || {};
const coords = geom.coordinates || [];
// Photon returns [lon, lat] for Point geometries
const lon = coords[0];
const lat = coords[1];
// Construct a description from address fields
// Priority: name -> street -> city -> state -> country
const addressParts = [];
if (props.street)
addressParts.push(
props.housenumber
? `${props.street} ${props.housenumber}`
: props.street
);
if (props.city && props.city !== props.name) addressParts.push(props.city);
if (props.state && props.state !== props.city)
addressParts.push(props.state);
if (props.country) addressParts.push(props.country);
const description = addressParts.join(', ');
const title = props.name || description || 'Unknown Place';
const osmTypeMap = {
N: 'node',
W: 'way',
R: 'relation',
};
return {
title,
lat,
lon,
osmId: props.osm_id,
osmType: osmTypeMap[props.osm_type] || props.osm_type, // 'node', 'way', 'relation'
osmTags: props, // Keep all properties as tags for now
description: props.name ? description : addressParts.slice(1).join(', '),
source: 'photon',
};
}
async fetchWithRetry(url, options = {}, retries = 3) {
try {
// eslint-disable-next-line warp-drive/no-external-request-patterns
const res = await fetch(url, options);
// Retry on 5xx errors or 429 Too Many Requests
if (!res.ok && retries > 0 && [502, 503, 504, 429].includes(res.status)) {
console.warn(
`Photon request failed with ${res.status}. Retrying... (${retries} left)`
);
// Exponential backoff or fixed delay? Let's do 1s fixed delay for simplicity
await new Promise((r) => setTimeout(r, 1000));
return this.fetchWithRetry(url, options, retries - 1);
}
return res;
} catch (e) {
// Retry on network errors (fetch throws) except AbortError
if (retries > 0 && e.name !== 'AbortError') {
console.debug(`Retrying Photon request... (${retries} left)`, e);
await new Promise((r) => setTimeout(r, 1000));
return this.fetchWithRetry(url, options, retries - 1);
}
throw e;
}
}
}

View File

@@ -74,6 +74,11 @@ body {
pointer-events: auto; /* Re-enable clicks for buttons */ pointer-events: auto; /* Re-enable clicks for buttons */
} }
.header-left {
display: flex;
align-items: center;
}
.btn-press { .btn-press {
transition: transform 0.1s; transition: transform 0.1s;
} }
@@ -82,19 +87,6 @@ body {
transform: scale(0.95); transform: scale(0.95);
} }
.menu-btn {
background: white;
border: none;
border-radius: 50%;
width: 40px;
height: 40px;
display: flex;
align-items: center;
justify-content: center;
box-shadow: 0 2px 5px rgb(0 0 0 / 20%);
cursor: pointer;
}
.user-btn { .user-btn {
background: none; background: none;
border: none; border: none;
@@ -750,3 +742,216 @@ button.create-place {
padding-bottom: env(safe-area-inset-bottom, 20px); padding-bottom: env(safe-area-inset-bottom, 20px);
} }
} }
/* Search Box Component */
.search-box {
position: relative;
width: 100%;
max-width: 400px;
margin-left: 0;
z-index: 3002; /* Higher than menu button to be safe */
}
@media (max-width: 768px) {
.search-box {
max-width: calc(100vw - 80px); /* Smaller on mobile but wider than before */
margin-left: 0.5rem;
}
}
.search-form {
display: flex;
align-items: center;
background: white;
border-radius: 24px; /* Pill shape */
box-shadow: 0 2px 5px rgba(0, 0, 0, 0.15);
padding: 0 0.5rem;
height: 48px; /* Slightly taller for touch targets */
transition: box-shadow 0.2s;
}
.search-form:focus-within {
box-shadow: 0 4px 12px rgba(0, 0, 0, 0.15);
}
/* Integrated Menu Button */
.menu-btn-integrated {
background: transparent;
border: none;
padding: 8px;
margin-right: 4px;
cursor: pointer;
display: flex;
align-items: center;
justify-content: center;
border-radius: 50%;
color: #5f6368;
}
.menu-btn-integrated:hover {
background: rgba(0, 0, 0, 0.05);
}
/* Fallback Search Icon (Left) */
.search-icon {
display: flex;
align-items: center;
justify-content: center;
color: #5f6368;
margin-right: 0.5rem;
padding: 8px; /* Match button size */
}
.search-input {
border: none;
background: transparent;
flex: 1;
min-width: 0;
height: 100%;
font-size: 1rem;
color: #333;
outline: none;
width: 100%;
padding: 0 4px;
/* Remove native search cancel button in WebKit */
-webkit-appearance: none;
}
/* Remove 'x' from search input in Chrome/Safari */
.search-input::-webkit-search-cancel-button {
-webkit-appearance: none;
}
/* Submit Button (Right) */
.search-submit-btn {
background: transparent;
border: none;
padding: 8px;
cursor: pointer;
display: flex;
align-items: center;
justify-content: center;
color: #5f6368;
border-radius: 50%;
margin-left: 4px;
border-left: 1px solid #ddd; /* Separator like Google Maps */
padding-left: 12px;
border-radius: 0; /* Reset for separator look */
}
.search-submit-btn:hover {
/* No background on hover if we use separator style, or maybe just change icon color */
color: #1a73e8; /* Blue on hover */
}
/* If we want the separator style, we need to adjust border-radius carefully or use a pseudo element */
/* Let's stick to a simple button for now, maybe without the separator if it looks cleaner */
.search-submit-btn {
border-left: none; /* Remove separator for cleaner look */
padding-left: 8px;
border-radius: 50%;
}
.search-submit-btn:hover {
background: rgba(0, 0, 0, 0.05);
color: #333;
}
.search-clear-btn {
background: none;
border: none;
padding: 8px;
cursor: pointer;
display: flex;
align-items: center;
justify-content: center;
color: #5f6368;
border-radius: 50%;
margin-left: 2px;
}
.search-clear-btn:hover {
background: rgba(0, 0, 0, 0.05);
color: #333;
}
/* Search Results Popover */
.search-results-popover {
position: absolute;
top: 100%;
left: 0;
right: 0;
margin-top: 8px;
background: white;
border-radius: 8px;
box-shadow: 0 4px 12px rgba(0, 0, 0, 0.15);
overflow: hidden;
max-height: 400px;
overflow-y: auto;
z-index: 3002;
}
.search-results-list {
list-style: none;
padding: 0;
margin: 0;
}
.search-result-item {
width: 100%;
display: flex;
align-items: center; /* Vertical center alignment */
gap: 0.75rem;
padding: 0.75rem 1rem;
border: none;
background: white;
text-align: left;
cursor: pointer;
transition: background 0.1s;
border-bottom: 1px solid #f0f0f0;
}
.search-result-item:last-child {
border-bottom: none;
}
.search-result-item:hover,
.search-result-item:focus {
background: #f5f5f5;
outline: none;
}
.result-icon {
display: flex;
align-items: center;
justify-content: center;
width: 32px;
height: 32px;
background: #f0f0f0;
border-radius: 50%;
flex-shrink: 0;
color: #666;
}
.result-info {
display: flex;
flex-direction: column;
overflow: hidden; /* For text truncation if needed */
}
.result-title {
font-weight: 500;
color: #333;
font-size: 0.95rem;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
.result-desc {
font-size: 0.8rem;
color: #777;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
margin-top: 2px;
}

View File

@@ -2,6 +2,9 @@ import { dirname } from 'node:path';
import { fileURLToPath } from 'node:url'; import { fileURLToPath } from 'node:url';
import { setConfig } from '@warp-drive/core/build-config'; import { setConfig } from '@warp-drive/core/build-config';
import { buildMacros } from '@embroider/macros/babel'; import { buildMacros } from '@embroider/macros/babel';
import asyncArrowTaskTransform from 'ember-concurrency/async-arrow-task-transform';
console.log('Babel config loading, plugin:', typeof asyncArrowTaskTransform);
const macros = buildMacros({ const macros = buildMacros({
configure: (config) => { configure: (config) => {
@@ -14,6 +17,7 @@ const macros = buildMacros({
export default { export default {
plugins: [ plugins: [
asyncArrowTaskTransform,
[ [
'babel-plugin-ember-template-compilation', 'babel-plugin-ember-template-compilation',
{ {

View File

@@ -101,6 +101,7 @@
"edition": "octane" "edition": "octane"
}, },
"dependencies": { "dependencies": {
"ember-concurrency": "^5.2.0",
"ember-lifeline": "^7.0.0" "ember-lifeline": "^7.0.0"
} }
} }

46
pnpm-lock.yaml generated
View File

@@ -8,6 +8,9 @@ importers:
.: .:
dependencies: dependencies:
ember-concurrency:
specifier: ^5.2.0
version: 5.2.0(@babel/core@7.28.6)
ember-lifeline: ember-lifeline:
specifier: ^7.0.0 specifier: ^7.0.0
version: 7.0.0(@ember/test-helpers@5.4.1(@babel/core@7.28.6)) version: 7.0.0(@ember/test-helpers@5.4.1(@babel/core@7.28.6))
@@ -1436,66 +1439,79 @@ packages:
resolution: {integrity: sha512-Rn3n+FUk2J5VWx+ywrG/HGPTD9jXNbicRtTM11e/uorplArnXZYsVifnPPqNNP5BsO3roI4n8332ukpY/zN7rQ==} resolution: {integrity: sha512-Rn3n+FUk2J5VWx+ywrG/HGPTD9jXNbicRtTM11e/uorplArnXZYsVifnPPqNNP5BsO3roI4n8332ukpY/zN7rQ==}
cpu: [arm] cpu: [arm]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-arm-musleabihf@4.55.1': '@rollup/rollup-linux-arm-musleabihf@4.55.1':
resolution: {integrity: sha512-grPNWydeKtc1aEdrJDWk4opD7nFtQbMmV7769hiAaYyUKCT1faPRm2av8CX1YJsZ4TLAZcg9gTR1KvEzoLjXkg==} resolution: {integrity: sha512-grPNWydeKtc1aEdrJDWk4opD7nFtQbMmV7769hiAaYyUKCT1faPRm2av8CX1YJsZ4TLAZcg9gTR1KvEzoLjXkg==}
cpu: [arm] cpu: [arm]
os: [linux] os: [linux]
libc: [musl]
'@rollup/rollup-linux-arm64-gnu@4.55.1': '@rollup/rollup-linux-arm64-gnu@4.55.1':
resolution: {integrity: sha512-a59mwd1k6x8tXKcUxSyISiquLwB5pX+fJW9TkWU46lCqD/GRDe9uDN31jrMmVP3feI3mhAdvcCClhV8V5MhJFQ==} resolution: {integrity: sha512-a59mwd1k6x8tXKcUxSyISiquLwB5pX+fJW9TkWU46lCqD/GRDe9uDN31jrMmVP3feI3mhAdvcCClhV8V5MhJFQ==}
cpu: [arm64] cpu: [arm64]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-arm64-musl@4.55.1': '@rollup/rollup-linux-arm64-musl@4.55.1':
resolution: {integrity: sha512-puS1MEgWX5GsHSoiAsF0TYrpomdvkaXm0CofIMG5uVkP6IBV+ZO9xhC5YEN49nsgYo1DuuMquF9+7EDBVYu4uA==} resolution: {integrity: sha512-puS1MEgWX5GsHSoiAsF0TYrpomdvkaXm0CofIMG5uVkP6IBV+ZO9xhC5YEN49nsgYo1DuuMquF9+7EDBVYu4uA==}
cpu: [arm64] cpu: [arm64]
os: [linux] os: [linux]
libc: [musl]
'@rollup/rollup-linux-loong64-gnu@4.55.1': '@rollup/rollup-linux-loong64-gnu@4.55.1':
resolution: {integrity: sha512-r3Wv40in+lTsULSb6nnoudVbARdOwb2u5fpeoOAZjFLznp6tDU8kd+GTHmJoqZ9lt6/Sys33KdIHUaQihFcu7g==} resolution: {integrity: sha512-r3Wv40in+lTsULSb6nnoudVbARdOwb2u5fpeoOAZjFLznp6tDU8kd+GTHmJoqZ9lt6/Sys33KdIHUaQihFcu7g==}
cpu: [loong64] cpu: [loong64]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-loong64-musl@4.55.1': '@rollup/rollup-linux-loong64-musl@4.55.1':
resolution: {integrity: sha512-MR8c0+UxAlB22Fq4R+aQSPBayvYa3+9DrwG/i1TKQXFYEaoW3B5b/rkSRIypcZDdWjWnpcvxbNaAJDcSbJU3Lw==} resolution: {integrity: sha512-MR8c0+UxAlB22Fq4R+aQSPBayvYa3+9DrwG/i1TKQXFYEaoW3B5b/rkSRIypcZDdWjWnpcvxbNaAJDcSbJU3Lw==}
cpu: [loong64] cpu: [loong64]
os: [linux] os: [linux]
libc: [musl]
'@rollup/rollup-linux-ppc64-gnu@4.55.1': '@rollup/rollup-linux-ppc64-gnu@4.55.1':
resolution: {integrity: sha512-3KhoECe1BRlSYpMTeVrD4sh2Pw2xgt4jzNSZIIPLFEsnQn9gAnZagW9+VqDqAHgm1Xc77LzJOo2LdigS5qZ+gw==} resolution: {integrity: sha512-3KhoECe1BRlSYpMTeVrD4sh2Pw2xgt4jzNSZIIPLFEsnQn9gAnZagW9+VqDqAHgm1Xc77LzJOo2LdigS5qZ+gw==}
cpu: [ppc64] cpu: [ppc64]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-ppc64-musl@4.55.1': '@rollup/rollup-linux-ppc64-musl@4.55.1':
resolution: {integrity: sha512-ziR1OuZx0vdYZZ30vueNZTg73alF59DicYrPViG0NEgDVN8/Jl87zkAPu4u6VjZST2llgEUjaiNl9JM6HH1Vdw==} resolution: {integrity: sha512-ziR1OuZx0vdYZZ30vueNZTg73alF59DicYrPViG0NEgDVN8/Jl87zkAPu4u6VjZST2llgEUjaiNl9JM6HH1Vdw==}
cpu: [ppc64] cpu: [ppc64]
os: [linux] os: [linux]
libc: [musl]
'@rollup/rollup-linux-riscv64-gnu@4.55.1': '@rollup/rollup-linux-riscv64-gnu@4.55.1':
resolution: {integrity: sha512-uW0Y12ih2XJRERZ4jAfKamTyIHVMPQnTZcQjme2HMVDAHY4amf5u414OqNYC+x+LzRdRcnIG1YodLrrtA8xsxw==} resolution: {integrity: sha512-uW0Y12ih2XJRERZ4jAfKamTyIHVMPQnTZcQjme2HMVDAHY4amf5u414OqNYC+x+LzRdRcnIG1YodLrrtA8xsxw==}
cpu: [riscv64] cpu: [riscv64]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-riscv64-musl@4.55.1': '@rollup/rollup-linux-riscv64-musl@4.55.1':
resolution: {integrity: sha512-u9yZ0jUkOED1BFrqu3BwMQoixvGHGZ+JhJNkNKY/hyoEgOwlqKb62qu+7UjbPSHYjiVy8kKJHvXKv5coH4wDeg==} resolution: {integrity: sha512-u9yZ0jUkOED1BFrqu3BwMQoixvGHGZ+JhJNkNKY/hyoEgOwlqKb62qu+7UjbPSHYjiVy8kKJHvXKv5coH4wDeg==}
cpu: [riscv64] cpu: [riscv64]
os: [linux] os: [linux]
libc: [musl]
'@rollup/rollup-linux-s390x-gnu@4.55.1': '@rollup/rollup-linux-s390x-gnu@4.55.1':
resolution: {integrity: sha512-/0PenBCmqM4ZUd0190j7J0UsQ/1nsi735iPRakO8iPciE7BQ495Y6msPzaOmvx0/pn+eJVVlZrNrSh4WSYLxNg==} resolution: {integrity: sha512-/0PenBCmqM4ZUd0190j7J0UsQ/1nsi735iPRakO8iPciE7BQ495Y6msPzaOmvx0/pn+eJVVlZrNrSh4WSYLxNg==}
cpu: [s390x] cpu: [s390x]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-x64-gnu@4.55.1': '@rollup/rollup-linux-x64-gnu@4.55.1':
resolution: {integrity: sha512-a8G4wiQxQG2BAvo+gU6XrReRRqj+pLS2NGXKm8io19goR+K8lw269eTrPkSdDTALwMmJp4th2Uh0D8J9bEV1vg==} resolution: {integrity: sha512-a8G4wiQxQG2BAvo+gU6XrReRRqj+pLS2NGXKm8io19goR+K8lw269eTrPkSdDTALwMmJp4th2Uh0D8J9bEV1vg==}
cpu: [x64] cpu: [x64]
os: [linux] os: [linux]
libc: [glibc]
'@rollup/rollup-linux-x64-musl@4.55.1': '@rollup/rollup-linux-x64-musl@4.55.1':
resolution: {integrity: sha512-bD+zjpFrMpP/hqkfEcnjXWHMw5BIghGisOKPj+2NaNDuVT+8Ds4mPf3XcPHuat1tz89WRL+1wbcxKY3WSbiT7w==} resolution: {integrity: sha512-bD+zjpFrMpP/hqkfEcnjXWHMw5BIghGisOKPj+2NaNDuVT+8Ds4mPf3XcPHuat1tz89WRL+1wbcxKY3WSbiT7w==}
cpu: [x64] cpu: [x64]
os: [linux] os: [linux]
libc: [musl]
'@rollup/rollup-openbsd-x64@4.55.1': '@rollup/rollup-openbsd-x64@4.55.1':
resolution: {integrity: sha512-eLXw0dOiqE4QmvikfQ6yjgkg/xDM+MdU9YJuP4ySTibXU0oAvnEWXt7UDJmD4UkYialMfOGFPJnIHSe/kdzPxg==} resolution: {integrity: sha512-eLXw0dOiqE4QmvikfQ6yjgkg/xDM+MdU9YJuP4ySTibXU0oAvnEWXt7UDJmD4UkYialMfOGFPJnIHSe/kdzPxg==}
@@ -2519,6 +2535,9 @@ packages:
decimal.js@10.6.0: decimal.js@10.6.0:
resolution: {integrity: sha512-YpgQiITW3JXGntzdUmyUR1V812Hn8T1YVXhCu+wO3OpS4eU9l4YdD3qjyiKdV6mvV29zapkMeD390UVEf2lkUg==} resolution: {integrity: sha512-YpgQiITW3JXGntzdUmyUR1V812Hn8T1YVXhCu+wO3OpS4eU9l4YdD3qjyiKdV6mvV29zapkMeD390UVEf2lkUg==}
decorator-transforms@1.2.1:
resolution: {integrity: sha512-UUtmyfdlHvYoX3VSG1w5rbvBQ2r5TX1JsE4hmKU9snleFymadA3VACjl6SRfi9YgBCSjBbfQvR1bs9PRW9yBKw==}
decorator-transforms@2.3.1: decorator-transforms@2.3.1:
resolution: {integrity: sha512-PDOk74Zqqy0946Lx4ckXxbgG6uhPScOICtrxL/pXmfznxchqNee0TaJISClGJQe6FeT8ohGqsOgdjfahm4FwEw==} resolution: {integrity: sha512-PDOk74Zqqy0946Lx4ckXxbgG6uhPScOICtrxL/pXmfznxchqNee0TaJISClGJQe6FeT8ohGqsOgdjfahm4FwEw==}
@@ -2669,6 +2688,15 @@ packages:
engines: {node: '>= 20.19.0'} engines: {node: '>= 20.19.0'}
hasBin: true hasBin: true
ember-concurrency@5.2.0:
resolution: {integrity: sha512-NUptPzaxaF2XWqn3VQ5KqiLSRqPFIZhWXH3UkOMhiedmiolxGYjUV96maoHWdd5msxNgQBC0UkZ28m7pV7A0sQ==}
engines: {node: 16.* || >= 18}
peerDependencies:
'@glint/template': '>= 1.0.0'
peerDependenciesMeta:
'@glint/template':
optional: true
ember-eslint-parser@0.5.13: ember-eslint-parser@0.5.13:
resolution: {integrity: sha512-b6ALDaxs9Bb4v0uagWud/5lECb78qpXHFv7M340dUHFW4Y0RuhlsfA4Rb+765X1+6KHp8G7TaAs0UgggWUqD3g==} resolution: {integrity: sha512-b6ALDaxs9Bb4v0uagWud/5lECb78qpXHFv7M340dUHFW4Y0RuhlsfA4Rb+765X1+6KHp8G7TaAs0UgggWUqD3g==}
engines: {node: '>=16.0.0'} engines: {node: '>=16.0.0'}
@@ -8110,6 +8138,13 @@ snapshots:
decimal.js@10.6.0: {} decimal.js@10.6.0: {}
decorator-transforms@1.2.1(@babel/core@7.28.6):
dependencies:
'@babel/plugin-syntax-decorators': 7.28.6(@babel/core@7.28.6)
babel-import-util: 2.1.1
transitivePeerDependencies:
- '@babel/core'
decorator-transforms@2.3.1(@babel/core@7.28.6): decorator-transforms@2.3.1(@babel/core@7.28.6):
dependencies: dependencies:
'@babel/plugin-syntax-decorators': 7.28.6(@babel/core@7.28.6) '@babel/plugin-syntax-decorators': 7.28.6(@babel/core@7.28.6)
@@ -8462,6 +8497,17 @@ snapshots:
- walrus - walrus
- whiskers - whiskers
ember-concurrency@5.2.0(@babel/core@7.28.6):
dependencies:
'@babel/helper-module-imports': 7.28.6
'@babel/helper-plugin-utils': 7.28.6
'@babel/types': 7.28.6
'@embroider/addon-shim': 1.10.2
decorator-transforms: 1.2.1(@babel/core@7.28.6)
transitivePeerDependencies:
- '@babel/core'
- supports-color
ember-eslint-parser@0.5.13(@babel/core@7.28.6)(eslint@9.39.2)(typescript@5.9.3): ember-eslint-parser@0.5.13(@babel/core@7.28.6)(eslint@9.39.2)(typescript@5.9.3):
dependencies: dependencies:
'@babel/core': 7.28.6 '@babel/core': 7.28.6

View File

@@ -25,6 +25,16 @@ class MockOsmService extends Service {
osmType: 'node', osmType: 'node',
}; };
} }
async fetchOsmObject(id, type) {
return {
osmId: id,
osmType: type,
lat: 1,
lon: 1,
osmTags: { name: 'Test Place', amenity: 'cafe' },
title: 'Test Place',
};
}
} }
class MockStorageService extends Service { class MockStorageService extends Service {
@@ -83,7 +93,6 @@ module('Acceptance | navigation', function (hooks) {
// Click the Close (X) button // Click the Close (X) button
await click('.close-btn'); await click('.close-btn');
assert.strictEqual(currentURL(), '/', 'Returned to index'); assert.strictEqual(currentURL(), '/', 'Returned to index');
assert.false(mapUi.returnToSearch, 'Flag is reset after closing sidebar'); assert.false(mapUi.returnToSearch, 'Flag is reset after closing sidebar');
}); });
@@ -96,7 +105,6 @@ module('Acceptance | navigation', function (hooks) {
await click('.back-btn'); await click('.back-btn');
assert.strictEqual(currentURL(), '/', 'Returned to index/map'); assert.strictEqual(currentURL(), '/', 'Returned to index/map');
assert.true(backStub.notCalled, 'window.history.back() was NOT called'); assert.true(backStub.notCalled, 'window.history.back() was NOT called');
} finally { } finally {

View File

@@ -0,0 +1,147 @@
import { module, test } from 'qunit';
import { visit, currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'marco/tests/helpers';
import Service from '@ember/service';
module('Acceptance | search', function (hooks) {
setupApplicationTest(hooks);
test('visiting /search with q parameter performs text search', async function (assert) {
// Mock Photon Service
class MockPhotonService extends Service {
async search(query) {
if (query === 'Berlin') {
return [
{
title: 'Berlin',
lat: 52.52,
lon: 13.405,
osmId: '123',
osmType: 'R',
description: 'City in Germany',
},
{
title: 'Berlin Alexanderplatz',
lat: 52.521,
lon: 13.41,
osmId: '456',
osmType: 'N',
description: 'Square in Berlin',
},
];
}
return [];
}
}
this.owner.register('service:photon', MockPhotonService);
// Mock Storage Service (empty)
class MockStorageService extends Service {
savedPlaces = [];
findPlaceById() {
return null;
}
rs = {
on: () => {},
};
// Add placesInView since map component accesses it
placesInView = [];
loadPlacesInBounds() {
return Promise.resolve();
}
}
this.owner.register('service:storage', MockStorageService);
await visit('/search?q=Berlin');
assert.strictEqual(currentURL(), '/search?q=Berlin');
assert.dom('.places-list li').exists({ count: 2 });
assert.dom('.places-list li:first-child .place-name').hasText('Berlin');
});
test('visiting /search with lat/lon performs nearby search', async function (assert) {
// Mock Osm Service
class MockOsmService extends Service {
async getNearbyPois() {
return [
{
title: 'Nearby Cafe',
lat: 52.521,
lon: 13.406,
osmId: '789',
osmType: 'N',
_distance: 100, // Pre-calculated or ignored if mocked
},
];
}
}
this.owner.register('service:osm', MockOsmService);
// Mock Storage Service (empty)
class MockStorageService extends Service {
savedPlaces = [];
findPlaceById() {
return null;
}
rs = {
on: () => {},
};
// Add placesInView since map component accesses it
placesInView = [];
loadPlacesInBounds() {
return Promise.resolve();
}
}
this.owner.register('service:storage', MockStorageService);
await visit('/search?lat=52.52&lon=13.405');
assert.strictEqual(currentURL(), '/search?lat=52.52&lon=13.405');
assert.dom('.places-list li').exists({ count: 1 });
assert.dom('.places-list li .place-name').hasText('Nearby Cafe');
});
test('local bookmarks are merged into search results', async function (assert) {
// Mock Photon Service
class MockPhotonService extends Service {
async search() {
return [];
}
}
this.owner.register('service:photon', MockPhotonService);
// Mock Storage Service with a bookmark
class MockStorageService extends Service {
savedPlaces = [
{
title: 'My Secret Base',
lat: 50.0,
lon: 10.0,
osmId: '999',
osmType: 'N',
description: 'Top Secret',
},
];
findPlaceById(id) {
if (id === '999') return this.savedPlaces[0];
return null;
}
rs = {
on: () => {},
};
placesInView = [];
loadPlacesInBounds() {
return Promise.resolve();
}
}
this.owner.register('service:storage', MockStorageService);
await visit('/search?q=Secret');
assert.strictEqual(currentURL(), '/search?q=Secret');
assert.dom('.places-list li').exists({ count: 1 });
assert.dom('.places-list li .place-name').hasText('My Secret Base');
});
});

View File

@@ -0,0 +1,19 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'marco/tests/helpers';
import { render } from '@ember/test-helpers';
import AppHeader from 'marco/components/app-header';
module('Integration | Component | app-header', function (hooks) {
setupRenderingTest(hooks);
test('it renders the search box', async function (assert) {
this.noop = () => {};
await render(
<template><AppHeader @onToggleMenu={{this.noop}} /></template>
);
assert.dom('header.app-header').exists();
assert.dom('.search-box').exists('Search box is present in the header');
assert.dom('.menu-btn-integrated').exists('Menu button is integrated');
});
});

View File

@@ -0,0 +1,37 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'marco/tests/helpers';
import { render } from '@ember/test-helpers';
import PlaceDetails from 'marco/components/place-details';
module('Integration | Component | place-details', function (hooks) {
setupRenderingTest(hooks);
test('it formats coordinates correctly', async function (assert) {
const place = {
title: 'Test Place',
lat: 52.520006789,
lon: 13.404954123,
description: 'A place for testing.',
};
await render(<template><PlaceDetails @place={{place}} /></template>);
assert.dom('.place-details').exists();
assert.dom('.place-details h3').hasText('Test Place');
// Check for the formatted coordinates link text
// "52.520007, 13.404954" (rounded)
assert.dom('.meta-info a[href*="geo:"]').hasText('52.520007, 13.404954');
});
test('it handles missing coordinates gracefully', async function (assert) {
const place = {
title: 'Place without Coords',
};
await render(<template><PlaceDetails @place={{place}} /></template>);
assert.dom('.place-details h3').hasText('Place without Coords');
assert.dom('.meta-info a[href*="geo:"]').doesNotExist();
});
});

View File

@@ -0,0 +1,131 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'marco/tests/helpers';
import { render, fillIn, click, waitFor } from '@ember/test-helpers';
import SearchBox from 'marco/components/search-box';
import Service from '@ember/service';
module('Integration | Component | search-box', function (hooks) {
setupRenderingTest(hooks);
test('it renders and handles search input', async function (assert) {
// Mock Photon Service
class MockPhotonService extends Service {
async search(query) {
if (query === 'test') {
return [
{
title: 'Test Place',
description: 'A test description',
lat: 10,
lon: 20,
osmId: '123',
osmType: 'node',
},
];
}
return [];
}
}
this.owner.register('service:photon', MockPhotonService);
// Mock Router Service
class MockRouterService extends Service {
transitionTo(routeName, ...args) {
assert.step(`transitionTo: ${routeName} ${JSON.stringify(args)}`);
}
}
this.owner.register('service:router', MockRouterService);
this.noop = () => {};
await render(<template><SearchBox @onToggleMenu={{this.noop}} /></template>);
assert.dom('.search-input').exists();
assert.dom('.search-results-popover').doesNotExist();
// Type 'test'
await fillIn('.search-input', 'test');
// Wait for debounce and async search
await waitFor('.search-results-popover', { timeout: 2000 });
assert.dom('.search-result-item').exists({ count: 1 });
assert.dom('.result-title').hasText('Test Place');
assert.dom('.result-desc').hasText('A test description');
// Click result
await click('.search-result-item');
assert.verifySteps(['transitionTo: place ["osm:node:123"]']);
assert
.dom('.search-results-popover')
.doesNotExist('Popover closes after selection');
});
test('it handles submit for full search', async function (assert) {
// Mock Photon Service
class MockPhotonService extends Service {
async search() {
return [];
}
}
this.owner.register('service:photon', MockPhotonService);
// Mock MapUi Service
class MockMapUiService extends Service {
currentCenter = { lat: 52.52, lon: 13.405 };
setSearchBoxFocus() {}
}
this.owner.register('service:map-ui', MockMapUiService);
// Mock Router Service
class MockRouterService extends Service {
transitionTo(routeName, options) {
assert.step(`transitionTo: ${routeName} ${JSON.stringify(options)}`);
}
}
this.owner.register('service:router', MockRouterService);
this.noop = () => {};
await render(<template><SearchBox @onToggleMenu={{this.noop}} /></template>);
await fillIn('.search-input', 'berlin');
await click('.search-input'); // Focus
// Trigger submit event on the form
await this.element
.querySelector('form')
.dispatchEvent(new Event('submit', { bubbles: true, cancelable: true }));
assert.verifySteps([
'transitionTo: search {"queryParams":{"q":"berlin","selected":null,"lat":"52.5200","lon":"13.4050"}}',
]);
});
test('it uses map center for biased search', async function (assert) {
// Mock MapUi Service
class MockMapUiService extends Service {
currentCenter = { lat: 52.52, lon: 13.405 };
setSearchBoxFocus() {}
}
this.owner.register('service:map-ui', MockMapUiService);
// Mock Photon Service
class MockPhotonService extends Service {
async search(query, lat, lon) {
assert.step(`search: ${query}, ${lat}, ${lon}`);
return [];
}
}
this.owner.register('service:photon', MockPhotonService);
this.noop = () => {};
await render(<template><SearchBox @onToggleMenu={{this.noop}} /></template>);
await fillIn('.search-input', 'cafe');
// Wait for debounce (300ms) + execution
const delay = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
await delay(400);
assert.verifySteps(['search: cafe, 52.52, 13.405']);
});
});

View File

@@ -0,0 +1,113 @@
import { module, test } from 'qunit';
import { setupTest } from 'marco/tests/helpers';
module('Unit | Service | osm', function (hooks) {
setupTest(hooks);
test('it exists', function (assert) {
let service = this.owner.lookup('service:osm');
assert.ok(service);
});
test('normalizeOsmApiData handles nodes correctly', function (assert) {
let service = this.owner.lookup('service:osm');
const elements = [
{
id: 123,
type: 'node',
lat: 52.5,
lon: 13.4,
tags: { name: 'Test Node' },
},
];
const result = service.normalizeOsmApiData(elements, 123, 'node');
assert.strictEqual(result.title, 'Test Node');
assert.strictEqual(result.lat, 52.5);
assert.strictEqual(result.lon, 13.4);
assert.strictEqual(result.osmId, '123');
assert.strictEqual(result.osmType, 'node');
});
test('normalizeOsmApiData calculates centroid for ways', function (assert) {
let service = this.owner.lookup('service:osm');
const elements = [
{
id: 456,
type: 'way',
nodes: [1, 2],
tags: { name: 'Test Way' },
},
{ id: 1, type: 'node', lat: 10, lon: 10 },
{ id: 2, type: 'node', lat: 20, lon: 20 },
];
const result = service.normalizeOsmApiData(elements, 456, 'way');
assert.strictEqual(result.title, 'Test Way');
assert.strictEqual(result.lat, 15); // (10+20)/2
assert.strictEqual(result.lon, 15); // (10+20)/2
assert.strictEqual(result.osmId, '456');
assert.strictEqual(result.osmType, 'way');
});
test('normalizeOsmApiData calculates centroid for relations with member nodes', function (assert) {
let service = this.owner.lookup('service:osm');
const elements = [
{
id: 789,
type: 'relation',
members: [
{ type: 'node', ref: 1, role: 'admin_centre' },
{ type: 'node', ref: 2, role: 'label' },
],
tags: { name: 'Test Relation' },
},
{ id: 1, type: 'node', lat: 10, lon: 10 },
{ id: 2, type: 'node', lat: 30, lon: 30 },
];
const result = service.normalizeOsmApiData(elements, 789, 'relation');
assert.strictEqual(result.title, 'Test Relation');
assert.strictEqual(result.lat, 20); // (10+30)/2
assert.strictEqual(result.lon, 20); // (10+30)/2
assert.strictEqual(result.osmId, '789');
assert.strictEqual(result.osmType, 'relation');
});
test('normalizeOsmApiData calculates centroid for relations with member ways', function (assert) {
let service = this.owner.lookup('service:osm');
/*
Relation 999
-> Way 888
-> Node 1 (10, 10)
-> Node 2 (20, 20)
*/
const elements = [
{
id: 999,
type: 'relation',
members: [{ type: 'way', ref: 888, role: 'outer' }],
tags: { name: 'Complex Relation' },
},
{
id: 888,
type: 'way',
nodes: [1, 2],
},
{ id: 1, type: 'node', lat: 10, lon: 10 },
{ id: 2, type: 'node', lat: 20, lon: 20 },
];
const result = service.normalizeOsmApiData(elements, 999, 'relation');
assert.strictEqual(result.title, 'Complex Relation');
// It averages all nodes found. In this case, Node 1 and Node 2.
assert.strictEqual(result.lat, 15); // (10+20)/2
assert.strictEqual(result.lon, 15); // (10+20)/2
assert.strictEqual(result.osmId, '999');
assert.strictEqual(result.osmType, 'relation');
});
});

View File

@@ -0,0 +1,137 @@
import { module, test } from 'qunit';
import { setupTest } from 'marco/tests/helpers';
module('Unit | Service | photon', function (hooks) {
setupTest(hooks);
test('it exists', function (assert) {
let service = this.owner.lookup('service:photon');
assert.ok(service);
});
test('search truncates coordinates to 4 decimal places', async function (assert) {
let service = this.owner.lookup('service:photon');
const originalFetch = window.fetch;
let capturedUrl;
window.fetch = async (url) => {
capturedUrl = url;
return {
ok: true,
json: async () => ({ features: [] }),
};
};
try {
await service.search('Test', 52.123456, 13.987654);
assert.ok(
capturedUrl.includes('lat=52.1235'),
'lat is rounded to 4 decimals'
);
assert.ok(
capturedUrl.includes('lon=13.9877'),
'lon is rounded to 4 decimals'
);
} finally {
window.fetch = originalFetch;
}
});
test('search handles successful response', async function (assert) {
let service = this.owner.lookup('service:photon');
// Mock fetch
const originalFetch = window.fetch;
window.fetch = async () => {
return {
ok: true,
json: async () => ({
features: [
{
properties: {
name: 'Test Place',
osm_id: 123,
osm_type: 'N',
city: 'Test City',
country: 'Test Country',
},
geometry: {
coordinates: [13.4, 52.5], // lon, lat
},
},
],
}),
};
};
try {
const results = await service.search('Test', 52.5, 13.4);
assert.strictEqual(results.length, 1);
assert.strictEqual(results[0].title, 'Test Place');
assert.strictEqual(results[0].lat, 52.5);
assert.strictEqual(results[0].lon, 13.4);
assert.strictEqual(results[0].description, 'Test City, Test Country');
assert.strictEqual(results[0].osmType, 'node', 'Normalizes N to node');
} finally {
window.fetch = originalFetch;
}
});
test('search handles empty response', async function (assert) {
let service = this.owner.lookup('service:photon');
// Mock fetch
const originalFetch = window.fetch;
window.fetch = async () => {
return {
ok: true,
json: async () => ({ features: [] }),
};
};
try {
const results = await service.search('Nonexistent', 52.5, 13.4);
assert.strictEqual(results.length, 0);
} finally {
window.fetch = originalFetch;
}
});
test('normalizeFeature handles missing properties', function (assert) {
let service = this.owner.lookup('service:photon');
const feature = {
properties: {
street: 'Main St',
housenumber: '123',
city: 'Metropolis',
},
geometry: {
coordinates: [10, 20],
},
};
const result = service.normalizeFeature(feature);
assert.strictEqual(result.title, 'Main St 123, Metropolis'); // Fallback to address description
assert.strictEqual(result.lat, 20);
assert.strictEqual(result.lon, 10);
});
test('normalizeFeature normalizes OSM types correctly', function (assert) {
let service = this.owner.lookup('service:photon');
const checkType = (input, expected) => {
const feature = {
properties: { osm_type: input, name: 'Test' },
geometry: { coordinates: [0, 0] },
};
const result = service.normalizeFeature(feature);
assert.strictEqual(result.osmType, expected, `${input} -> ${expected}`);
};
checkType('N', 'node');
checkType('W', 'way');
checkType('R', 'relation');
checkType('unknown', 'unknown'); // Fallback
});
});