kosmos/akkounts
kosmos
/
akkounts
8
1
Fork 0
Code Issues 21 Pull Requests 1 Actions Packages Releases 11 Activity

Fetch/store Web App metadata and icons, finish RS integration #153

Merged
raucao merged 39 commits from feature/142-webapp_database into master 2024-01-01 13:18:48 +00:00
Conversation 6 Commits 39 Files Changed 57 +1113 -382
raucao commented 2023-11-01 21:06:27 +00:00
Owner
Copy Link

Not entirely done yet, but almost there. You can already authorize any RS apps against your local account (username@localhost:3000).

How to run/test

There are instructions in the README for adding a bucket to Minio. The LC Dockerfile is available in this branch, so you can also use build instead of image to build LC locally from that: 5apps/liquor-cabinet#2

To do

  • Create Web App model, integrate Manifique for fetching app metadata and icons
  • Add admin page for inspecting indexed Web Apps
  • Add Docker Compose services for S3 (Minio) and Liquor Cabinet (RS API)
  • Only use the primary domain/ou for RS (except for the user address in dev)
  • Fix bug in Liquor Cabinet signature generation (fails in the new LC Docker container for some reason)
  • Finish storage dashboard (add more info to auths, allow revocation)
  • Add missing specs (mostly just Web App related)

closes #94
closes #142

Not entirely done yet, but almost there. You can already authorize any RS apps against your local account (`username@localhost:3000`). ### How to run/test There are instructions in the README for adding a bucket to Minio. The LC Dockerfile is available in this branch, so you can also use `build` instead of `image` to build LC locally from that: https://gitea.kosmos.org/5apps/liquor-cabinet/pulls/2 ### To do * [x] Create Web App model, integrate Manifique for fetching app metadata and icons * [x] Add admin page for inspecting indexed Web Apps * [x] Add Docker Compose services for S3 (Minio) and Liquor Cabinet (RS API) * [x] Only use the primary domain/ou for RS (except for the user address in dev) * [x] Fix bug in Liquor Cabinet signature generation (fails in the new LC Docker container for some reason) * [x] Finish storage dashboard (add more info to auths, allow revocation) * [x] Add missing specs (mostly just Web App related) closes #94 closes #142
Screenshot from 2023-11-19 19-12-25.png
850 KiB
Screenshot from 2023-11-19 19-12-25.png
raucao added the
feature
 label 2023-11-01 21:06:27 +00:00
raucao added 21 commits 2023-11-01 21:06:28 +00:00
continuous-integration/drone/push Build is passing Details
2b8bfaaca8
Add admin page for web apps
continuous-integration/drone/push Build is failing Details
5075fef616
Only show avatar when available on admin user page
56c127ca0c
Only allow primary domain for RS 
Replace user addresses with usernames in the respective URLs
92310d434a
Remove rs namespace from Redis keys 
Superfluous, since the whole db should be RS only
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
00049f3743
Add info for running Minio/RS to README
raucao requested review from galfert 2023-11-02 10:57:33 +00:00
raucao commented 2023-11-15 16:29:25 +00:00
Author
Owner
Copy Link

@galfert I actually get the same signature issue we talked about when running Liquor Cabinet on the host directly. Going to forgo further debugging in favor of 5apps/liquor-cabinet#3

@galfert I actually get the same signature issue we talked about when running Liquor Cabinet on the host directly. Going to forgo further debugging in favor of https://gitea.kosmos.org/5apps/liquor-cabinet/issues/3
raucao added 2 commits 2023-11-16 11:44:31 +00:00
continuous-integration/drone/push Build is running Details
continuous-integration/drone/pr Build is failing Details
157d7efeb6
Fix RS OAuth URL in Webfinger record
raucao force-pushed feature/142-webapp_database from 157d7efeb6 to 1995e6dda2 2023-11-16 11:45:16 +00:00 Compare
raucao added 3 commits 2023-11-16 11:46:51 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
27bb7d1bfe
Finish working liquor-cabinet setup for Docker Compose
raucao commented 2023-11-16 11:49:01 +00:00
Author
Owner
Copy Link

Update: Liquor Cabinet now works (without any changes) with Docker Compose, and also supports v4 signatures now. So the RS integration now works entirely in dev and should also be compatible with Garage.

Update: Liquor Cabinet now works (without any changes) with Docker Compose, and also supports v4 signatures now. So the RS integration now works entirely in dev and should also be compatible with Garage.
raucao added 3 commits 2023-11-18 16:36:27 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
4fdf8accd6
Add note
raucao added 3 commits 2023-11-19 17:49:35 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
713e91a720
Implement RS auth revocation
raucao added 1 commit 2023-11-19 18:10:44 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
aa399b862a
Allow to launch RS apps from dashboard
raucao changed title from WIP: Fetch/store Web App metadata and icons, finish RS integration to Fetch/store Web App metadata and icons, finish RS integration 2023-11-19 18:11:08 +00:00
raucao commented 2023-11-19 18:11:43 +00:00
Author
Owner
Copy Link

Update: MVP of the dashboard is fully working now, allowing to revoke authorizations and launch apps with storage-first flow.

Update: MVP of the dashboard is fully working now, allowing to revoke authorizations and launch apps with storage-first flow.
raucao added 1 commit 2023-11-20 11:22:18 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
bdf5a18ad4
Re-add more specs
raucao added 1 commit 2023-11-20 12:30:43 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
1960f39073
Respect "start_url" from manifest when launching web apps
raucao force-pushed feature/142-webapp_database from 1960f39073 to 9a9947f9ad 2023-11-20 12:32:46 +00:00 Compare
raucao added 1 commit 2023-11-20 12:41:11 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
2a70bf2fb9
Small refactoring
raucao added 3 commits 2023-11-20 17:33:19 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
Release Drafter / Update release notes draft (pull_request) Successful in 3s Details
aab6793b86
Improve permission list in RS emails
raucao added the
kredits-3
 label 2023-11-20 17:33:37 +00:00
raucao commented 2023-11-20 17:36:00 +00:00
Author
Owner
Copy Link

More updates:

  • Respect start_url from Web App Manifest when launching apps from the Storage dashboard
  • Add (configurable) notifications for new authorizations
More updates: * Respect `start_url` from Web App Manifest when launching apps from the Storage dashboard * Add (configurable) notifications for new authorizations
galfert approved these changes 2023-12-05 03:58:04 +00:00
galfert left a comment
Owner
Copy Link

Changes look all good. Great job 🙌

So far I wasn't able to test it though.

When running docker compose up, I get the following error from the accounts-ldap-1 instance:

ERR - createprlistensockets - PR_Bind() on address conversion failed file /data/run/slapd-localhost.socket failed: Netscape Portable Runtime error -5968 (TCP-specific function attempted on a non-TCP file descriptor.)

I deleted all my old containers and images, but that didn't help.

Changes look all good. Great job 🙌 So far I wasn't able to test it though. When running `docker compose up`, I get the following error from the `accounts-ldap-1` instance: ``` ERR - createprlistensockets - PR_Bind() on address conversion failed file /data/run/slapd-localhost.socket failed: Netscape Portable Runtime error -5968 (TCP-specific function attempted on a non-TCP file descriptor.) ``` I deleted all my old containers and images, but that didn't help.
app/components/rs_auth_component.html.erb
@ -0,0 +4,4 @@
</div>
<div class="flex-grow">
<h4 class="mb-1 text-lg font-bold">
<%= @web_app.name %>
galfert commented 2023-11-28 13:15:34 +00:00
Owner
Copy Link

Maybe it might be nice to also link the name or the client_id field directly to the launch URL? Just to easier open the app without having to go via the dropdown.

Maybe it might be nice to also link the name or the client_id field directly to the launch URL? Just to easier open the app without having to go via the dropdown.
raucao commented 2023-12-05 08:21:20 +00:00
Author
Owner
Copy Link

When running docker compose up, I get the following error from the accounts-ldap-1 instance:

If you want to start with a fresh LDAP container (or Rails, after switching from running it on the host), you also have to delete the files in ./tmp first.

However, if the documented quick start commands are not working on a fresh repo checkout, please file an issue for that, and I'll check it out asap!

> When running docker compose up, I get the following error from the accounts-ldap-1 instance: If you want to start with a fresh LDAP container (or Rails, after switching from running it on the host), you also have to delete the files in `./tmp` first. However, if the documented quick start commands are not working on a fresh repo checkout, please file an issue for that, and I'll check it out asap!
raucao commented 2023-12-16 18:26:27 +00:00
Author
Owner
Copy Link

@galfert Were you able to run it in the meantime?

@galfert Were you able to run it in the meantime?
raucao merged commit 4e566a0607 into master 2024-01-01 13:18:48 +00:00
raucao deleted branch feature/142-webapp_database 2024-01-01 13:18:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
galfert
Labels
Clear labels   
integration
discourse

  
integration
ejabberd

  
integration
ldap

  
integration
lndhub

  
integration
nostr

  
bug

Something is not working

  
design

Graphic/visual design

  
dev environment

Config, builds, CI, deployment, etc.

  
docs

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

Improving existing functionality

  
feature

New functionality

  
good first issue

Dive in, and start contributing

  
idea

Something to consider

  
invalid

Not a bug

  
kredits-1

Small contribution

  
kredits-2

Medium contribution

  
kredits-3

Large contribution

  
on hold

Currently not actionable

  
ops

Manual IT ops activities

  
question

Looking for an answer

  
release
major

  
release
minor

  
release
patch

  
security

All your base are belong to us

  
ui/ux

User interface, process design, etc.

  
wontfix

This won't be fixed

No Label
integration
discourse
integration
ejabberd
integration
ldap
integration
lndhub
integration
nostr
bug
design
dev environment
docs
duplicate
enhancement
feature
good first issue
idea
invalid
kredits-1
kredits-2
kredits-3
on hold
ops
question
release
major
release
minor
release
patch
security
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#153
No description provided.
Delete Branch "feature/142-webapp_database"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?