Fetch/store Web App metadata and icons, finish RS integration #153

2023-11-01T21:06:27Z

raucao commented

2023-11-01 21:06:27 +00:00

Not entirely done yet, but almost there. You can already authorize any RS apps against your local account (username@localhost:3000).

How to run/test

There are instructions in the README for adding a bucket to Minio. The LC Dockerfile is available in this branch, so you can also use build instead of image to build LC locally from that: 5apps/liquor-cabinet#2

To do

Create Web App model, integrate Manifique for fetching app metadata and icons
Add admin page for inspecting indexed Web Apps
Add Docker Compose services for S3 (Minio) and Liquor Cabinet (RS API)
Only use the primary domain/ou for RS (except for the user address in dev)
Fix bug in Liquor Cabinet signature generation (fails in the new LC Docker container for some reason)
Finish storage dashboard (add more info to auths, allow revocation)
Add missing specs (mostly just Web App related)

closes #94
closes #142

Not entirely done yet, but almost there. You can already authorize any RS apps against your local account (`username@localhost:3000`). ### How to run/test There are instructions in the README for adding a bucket to Minio. The LC Dockerfile is available in this branch, so you can also use `build` instead of `image` to build LC locally from that: https://gitea.kosmos.org/5apps/liquor-cabinet/pulls/2 ### To do * [x] Create Web App model, integrate Manifique for fetching app metadata and icons * [x] Add admin page for inspecting indexed Web Apps * [x] Add Docker Compose services for S3 (Minio) and Liquor Cabinet (RS API) * [x] Only use the primary domain/ou for RS (except for the user address in dev) * [x] Fix bug in Liquor Cabinet signature generation (fails in the new LC Docker container for some reason) * [x] Finish storage dashboard (add more info to auths, allow revocation) * [x] Add missing specs (mostly just Web App related) closes #94 closes #142

Screenshot from 2023-11-19 19-12-25.png

850 KiB

raucao added the feature label 2023-11-01 21:06:27 +00:00

raucao added 21 commits 2023-11-01 21:06:28 +00:00

Add optional S3 config/backend for ActiveStorage 1056ffd08e

Update dependencies, add manifique e1b7e1b2ef

Add web app model, service to fetch metadata e56c9bd0d5

Download and attach icons for web apps d4f71e98ed

Update web app metadata when first creating a record 0a69603643

Store web app icons with proper folder paths bec827acb1

Remove debug statement e508407df4

Save web app metadata explicitly e964e7e52c

Only complete icon URLs when given relative or absolute paths 261a782963

Associate RS authorizations with web apps fcea11f0e5

Remove (long) obsolete edge case 3e9a08a266

Add admin page for web apps

continuous-integration/drone/push Build is passing

Details

2b8bfaaca8

WIP Add RS auths/apps to Storage dashboard 00ec7fa21c

Remove variants from attachment def87a1621

Fetch web app metadata when creating RS auth 8e090daa9c

Only show avatar when available on admin user page

continuous-integration/drone/push Build is failing

Details

5075fef616

Only allow primary domain for RS 56c127ca0c

Replace user addresses with usernames in the respective URLs

Remove rs namespace from Redis keys 92310d434a

Superfluous, since the whole db should be RS only

Adjust specs for web app metadata fetching 0c1b1b4afe

Add minio to Docker Compose setup, configure Liquor Cabinet 60c0a43f33

Add info for running Minio/RS to README

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

00049f3743

raucao requested review from galfert 2023-11-02 10:57:33 +00:00

raucao commented

2023-11-15 16:29:25 +00:00

@galfert I actually get the same signature issue we talked about when running Liquor Cabinet on the host directly. Going to forgo further debugging in favor of 5apps/liquor-cabinet#3

@galfert I actually get the same signature issue we talked about when running Liquor Cabinet on the host directly. Going to forgo further debugging in favor of https://gitea.kosmos.org/5apps/liquor-cabinet/issues/3

raucao added 1 commit 2023-11-16 11:44:31 +00:00

Update lockfile 600cfe0f78

raucao force-pushed feature/142-webapp_database from 157d7efeb6 to 1995e6dda2

2023-11-16 11:45:16 +00:00

Compare

raucao added 3 commits 2023-11-16 11:46:51 +00:00

Fail gracefully and log error when token missing in Redis de67f59d5c

Wording 1d44181fb5

Finish working liquor-cabinet setup for Docker Compose

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

27bb7d1bfe

raucao commented

2023-11-16 11:49:01 +00:00

Update: Liquor Cabinet now works (without any changes) with Docker Compose, and also supports v4 signatures now. So the RS integration now works entirely in dev and should also be compatible with Garage.

raucao added 3 commits 2023-11-18 16:36:27 +00:00

Add dropdown components, menus for RS auth items 721dccb499

Try smaller icons if 256px not available f451adcb53

Add note

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

4fdf8accd6

raucao added 3 commits 2023-11-19 17:49:35 +00:00

Improve app list 4ecf2c4246

Remove obsolete spec file 8ec2a6d7e4

Implement RS auth revocation

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

713e91a720

raucao added 1 commit 2023-11-19 18:10:44 +00:00

Allow to launch RS apps from dashboard

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

aa399b862a

raucao marked the pull request as ready for review 2023-11-19 18:11:08 +00:00

raucao commented

2023-11-19 18:11:43 +00:00

Update: MVP of the dashboard is fully working now, allowing to revoke authorizations and launch apps with storage-first flow.

raucao added 1 commit 2023-11-20 11:22:18 +00:00

Re-add more specs

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

bdf5a18ad4

raucao force-pushed feature/142-webapp_database from 1960f39073 to 9a9947f9ad

2023-11-20 12:32:46 +00:00

Compare

raucao added 1 commit 2023-11-20 12:41:11 +00:00

Small refactoring

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

2a70bf2fb9

raucao added 3 commits 2023-11-20 17:33:19 +00:00

Add settings page for Storage, add notification prefs c2dae105ff

Notify user about new RS authorizations cfd0935bdc

Improve permission list in RS emails

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

Release Drafter / Update release notes draft (pull_request) Successful in 3s

Details

aab6793b86

raucao added the kredits-3 label 2023-11-20 17:33:37 +00:00

raucao commented

2023-11-20 17:36:00 +00:00

More updates:

Respect start_url from Web App Manifest when launching apps from the Storage dashboard
Add (configurable) notifications for new authorizations

More updates: * Respect `start_url` from Web App Manifest when launching apps from the Storage dashboard * Add (configurable) notifications for new authorizations

galfert approved these changes 2023-12-05 03:58:04 +00:00

galfert left a comment

Changes look all good. Great job 🙌

So far I wasn't able to test it though.

When running docker compose up, I get the following error from the accounts-ldap-1 instance:

ERR - createprlistensockets - PR_Bind() on address conversion failed file /data/run/slapd-localhost.socket failed: Netscape Portable Runtime error -5968 (TCP-specific function attempted on a non-TCP file descriptor.)

I deleted all my old containers and images, but that didn't help.

Changes look all good. Great job 🙌 So far I wasn't able to test it though. When running `docker compose up`, I get the following error from the `accounts-ldap-1` instance: ``` ERR - createprlistensockets - PR_Bind() on address conversion failed file /data/run/slapd-localhost.socket failed: Netscape Portable Runtime error -5968 (TCP-specific function attempted on a non-TCP file descriptor.) ``` I deleted all my old containers and images, but that didn't help.

app/components/rs_auth_component.html.erb

						
				@@ -0,0 +4,4 @@

				  </div>

				  <div class="flex-grow">

				    <h4 class="mb-1 text-lg font-bold">

				      <%= @web_app.name %>

galfert commented

2023-11-28 13:15:34 +00:00

Maybe it might be nice to also link the name or the client_id field directly to the launch URL? Just to easier open the app without having to go via the dropdown.

raucao commented

2023-12-05 08:21:20 +00:00

When running docker compose up, I get the following error from the accounts-ldap-1 instance:

If you want to start with a fresh LDAP container (or Rails, after switching from running it on the host), you also have to delete the files in ./tmp first.

However, if the documented quick start commands are not working on a fresh repo checkout, please file an issue for that, and I'll check it out asap!

> When running docker compose up, I get the following error from the accounts-ldap-1 instance: If you want to start with a fresh LDAP container (or Rails, after switching from running it on the host), you also have to delete the files in `./tmp` first. However, if the documented quick start commands are not working on a fresh repo checkout, please file an issue for that, and I'll check it out asap!

raucao commented

2023-12-16 18:26:27 +00:00

@galfert Were you able to run it in the meantime?

raucao merged commit 4e566a0607 into master

2024-01-01 13:18:48 +00:00

raucao deleted branch feature/142-webapp_database

2024-01-01 13:18:48 +00:00

raucao referenced this issue from a commit

2024-01-01 13:18:49 +00:00

Merge pull request 'Fetch/store Web App metadata and icons, finish RS integration' (#153) from feature/142-webapp_database into master

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#153