kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Add user avatars to LDAP, upload on profile settings page #148

Merged
raucao merged 11 commits from feature/123-user_avatars into master 2023-09-13 13:01:25 +00:00
Conversation 3 Commits 11 Files Changed 27 +328 -41
raucao commented 2023-09-07 09:49:41 +00:00
Owner
Copy Link

Allow users to upload avatars, resized to 512px square and stored as jpegPhoto in LDAP, where it can be used from Gitea, ejabberd, etc..

I started implementing this using ActiveStorage, but then realized it's much nicer to not require any separate file storage in addition to LDAP for this, because everything will be fast enough to just retrieve the avatar from there and re-process it if necessary. However, I left in the ActiveStorage configs (all local disk for now), so we can use it for other things, like e.g. the app icons in #142.

The avatar is also shown on the admin user page, but no fancy layout there as of now.

closes #123

Allow users to upload avatars, resized to 512px square and stored as `jpegPhoto` in LDAP, where it can be used from Gitea, ejabberd, etc.. I started implementing this using ActiveStorage, but then realized it's much nicer to not require any separate file storage in addition to LDAP for this, because everything will be fast enough to just retrieve the avatar from there and re-process it if necessary. However, I left in the ActiveStorage configs (all local disk for now), so we can use it for other things, like e.g. the app icons in #142. The avatar is also shown on the admin user page, but no fancy layout there as of now. closes #123
Screenshot from 2023-09-07 11-48-49.png
337 KiB
Screenshot from 2023-09-07 11-48-49.png
raucao added the
feature
kredits-2
 labels 2023-09-07 09:49:41 +00:00
raucao added 8 commits 2023-09-07 09:49:42 +00:00
Comments
All checks were successful
continuous-integration/drone/push Build is passing
Details
def44618ef
Store and retrieve avatars in/from LDAP exclusively
Some checks failed
continuous-integration/drone/push Build is failing
Details
d5ab532947 
No need to keep them in two places at the same time. We can fetch them
from LDAP whenever we want to do something with them.
Add specs for avatar upload
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
dfcdbec0dd
raucao commented 2023-09-07 09:54:52 +00:00
Author
Owner
Copy Link

We'll need to create a custom Docker image on top of guildeducation/rails, in order to install the libvips package. Out of time just now, but will look at it later. We can host it directly on this Gitea's Docker registry.

We'll need to create a custom Docker image on top of `guildeducation/rails`, in order to install the `libvips` package. Out of time just now, but will look at it later. We can host it directly on this Gitea's Docker registry.
raucao added 1 commit 2023-09-07 21:35:51 +00:00
Use custom docker image with libvips installed in CI
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
b810e27480
raucao requested review from Core 2023-09-08 07:09:25 +00:00
galfert approved these changes 2023-09-13 11:45:34 +00:00
galfert left a comment
Owner
Copy Link

Overall the changes look good to me. I find the name jpegPhoto a bit odd. Did you choose that deliberately or is that something LDAP specific?

Overall the changes look good to me. I find the name `jpegPhoto` a bit odd. Did you choose that deliberately or is that something LDAP specific?
app/services/ldap_manager/fetch_avatar.rb
@ -0,0 +7,4 @@
def call
treebase = @ou ? "ou=#{@ou},cn=users,#{suffix}" : ldap_config["base"]
puts treebase.inspect
galfert commented 2023-09-13 11:37:59 +00:00
Owner
Copy Link

✂️

✂️
raucao marked this conversation as resolved
app/views/admin/users/show.html.erb Outdated
@ -65,1 +65,4 @@
<section class="sm:flex-1 sm:pt-0">
<h3>LDAP<h3>
<p>
<img src="data:image/png;base64,<%= @avatar %>" class="h-48 w-48" />
galfert commented 2023-09-13 11:42:20 +00:00
Owner
Copy Link

Shouldn't this be image/jpeg?

Shouldn't this be `image/jpeg`?
raucao commented 2023-09-13 12:46:33 +00:00
Author
Owner
Copy Link

Yes! Thanks.

Yes! Thanks.
raucao marked this conversation as resolved
raucao added 2 commits 2023-09-13 12:49:32 +00:00
Use correct content type for image
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
Release Drafter / Update release notes draft (pull_request) Successful in 3s
Details
9c4c5c2553
raucao merged commit 7a5fd46835 into master 2023-09-13 13:01:25 +00:00
raucao deleted branch feature/123-user_avatars 2023-09-13 13:01:25 +00:00
raucao commented 2023-09-13 13:38:00 +00:00
Author
Owner
Copy Link

I find the name jpegPhoto a bit odd. Did you choose that deliberately or is that something LDAP specific?

Yes, it's a standardized property name: https://www.rfc-editor.org/rfc/rfc2798#section-2.6

> I find the name `jpegPhoto` a bit odd. Did you choose that deliberately or is that something LDAP specific? Yes, it's a standardized property name: https://www.rfc-editor.org/rfc/rfc2798#section-2.6
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
feature
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#148
No description provided.
Delete Branch "feature/123-user_avatars"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?