kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Let users donate sats via BTCPay Server #176

Merged
raucao merged 9 commits from feature/donations_btcpay into master 2024-03-13 16:31:54 +00:00
Conversation 5 Commits 9 Files Changed 54 +1315 -180
raucao commented 2024-03-02 13:56:16 +00:00
Owner
Copy Link

Introducing the first option for accepting donations in akkounts: one-time donations via BTCPay.

Supports both on-chain and Lightning options. For on-chain donations, the donation is shown as pending until confirmed, while Lightning donations are confirmed instantly, of course. There is also an email notification once on-chain donations have been confirmed, so you don't have to remember to follow up on it.

Furthermore, you can choose the amount either in EUR, USD, or sats. When choosing an amount in sats, the exchange rate will be fetched after receiving the payment notification from BTCPay and added to the donation record then. When choosing a fiat amount, the conversion is already done by BTCPay, so we just add the amount of sats we see from the payment notification already.

In order to test the functionality directly against https://btcpay.kosmos.org, please DM me for a testing API key.

(This PR already includes a small refactoring commit that will make it easier to integrate the next option, which is sats directly from one's Kosmos LndHub account, which can then also be done as a monthly subscription that is automatically debited.)

refs #31

Introducing the first option for accepting donations in akkounts: one-time donations via BTCPay. Supports both on-chain and Lightning options. For on-chain donations, the donation is shown as pending until confirmed, while Lightning donations are confirmed instantly, of course. There is also an email notification once on-chain donations have been confirmed, so you don't have to remember to follow up on it. Furthermore, you can choose the amount either in EUR, USD, or sats. When choosing an amount in sats, the exchange rate will be fetched after receiving the payment notification from BTCPay and added to the donation record then. When choosing a fiat amount, the conversion is already done by BTCPay, so we just add the amount of sats we see from the payment notification already. In order to test the functionality directly against https://btcpay.kosmos.org, please DM me for a testing API key. (This PR already includes a small refactoring commit that will make it easier to integrate the next option, which is sats directly from one's Kosmos LndHub account, which can then also be done as a monthly subscription that is automatically debited.) refs #31
Screenshot from 2024-03-02 14-59-42.png
386 KiB
Screenshot from 2024-03-02 15-00-56.png
527 KiB
Screenshot from 2024-03-02 14-59-12.png
748 KiB
Screenshot from 2024-03-02 14-59-42.png Screenshot from 2024-03-02 15-00-56.png Screenshot from 2024-03-02 14-59-12.png
raucao added the
kredits-2
 label 2024-03-02 13:56:16 +00:00
raucao added 5 commits 2024-03-02 13:56:17 +00:00 
Removing initialize methods from the main/manager class also allows for
different iniitalizers in specific task services
Send email confirmation when BTC payment is confirmed
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
54220019bb
raucao added 1 commit 2024-03-02 14:07:45 +00:00
Merge branch 'master' into feature/donations_btcpay
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
c36cf5eee6
raucao added 1 commit 2024-03-03 11:50:28 +00:00
Merge branch 'master' into feature/donations_btcpay
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
e3b96d5cff
raucao added the
feature
 label 2024-03-03 17:10:06 +00:00
galfert reviewed 2024-03-05 21:31:31 +00:00
app/controllers/contributions/donations_controller.rb
@ -10,0 +27,4 @@
def create
if params[:currency] == "sats"
fiat_amount = nil
fiat_currency = nil
galfert commented 2024-03-05 20:49:42 +00:00
Owner
Copy Link

Isn't a amount_sats = params[:amount_sats] missing here?

I couldn't see the amount_sats being assigned anywhere other than to nil when a different currency is selected, but it is being used further down in this action.

Isn't a `amount_sats = params[:amount_sats]` missing here? I couldn't see the `amount_sats` being assigned anywhere other than to `nil` when a different currency is selected, but it is being used further down in this action.
raucao commented 2024-03-06 10:27:17 +00:00
Author
Owner
Copy Link

Good catch! Since I did actual donations using sats for the amount, it must have gotten lost for the commit somehow. Added a spec to catch that, since that spec was missing in the first place.

Good catch! Since I did actual donations using sats for the amount, it must have gotten lost for the commit somehow. Added a spec to catch that, since that spec was missing in the first place.
raucao marked this conversation as resolved
raucao added 1 commit 2024-03-06 10:21:21 +00:00
Add spec for reported regression
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
da22a9d448
raucao added 1 commit 2024-03-06 10:24:09 +00:00
Fix donation record for amounts given in sats
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
Release Drafter / Update release notes draft (pull_request) Successful in 4s
Details
7f2df3b025
raucao commented 2024-03-07 13:16:14 +00:00
Author
Owner
Copy Link

@galfert Want to give it your stamp of approval?

@galfert Want to give it your stamp of approval?
galfert commented 2024-03-08 12:07:34 +00:00
Owner
Copy Link

When trying to create a contribution I'm getting an error (see screenshot).

I'm in the Zerotier network and when I GET http://10.1.1.163:23001/api/v1/health from my computer directly, I get a correct response of

{
  "synchronized": true
}

When I do the same from within the web container, the request times out.

When trying to create a contribution I'm getting an error (see screenshot). I'm in the Zerotier network and when I GET `http://10.1.1.163:23001/api/v1/health` from my computer directly, I get a correct response of ```json { "synchronized": true } ``` When I do the same from within the web container, the request times out.
Screenshot 2024-03-08 at 12.50.22.png
116 KiB
Screenshot 2024-03-08 at 12.50.22.png
galfert approved these changes 2024-03-09 12:11:23 +00:00
galfert left a comment
Owner
Copy Link

Code looks alright. Wasn't able to test it yet, because of the error I commented above.

Code looks alright. Wasn't able to test it yet, because of the error I commented above.
🚀 1
raucao commented 2024-03-13 16:31:42 +00:00
Author
Owner
Copy Link

As discussed during the last call, we'll merge this and test in production, since I am unable to debug macOS Docker issues and connecting to our private network in dev should not be a prerequisite.

As discussed during the last call, we'll merge this and test in production, since I am unable to debug macOS Docker issues and connecting to our private network in dev should not be a prerequisite.
raucao merged commit 8b897168cc into master 2024-03-13 16:31:54 +00:00
raucao deleted branch feature/donations_btcpay 2024-03-13 16:31:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
feature
kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#176
No description provided.
Delete Branch "feature/donations_btcpay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?