kosmos/chef
kosmos/chef
8
3
Fork 0
Code Issues 26 Pull Requests 2 Projects 2 Activity

Configure/deploy new akkounts Rails app #242

Merged
greg merged 3 commits from feature/akkounts into master 2020-11-23 09:52:16 +00:00
Conversation 4 Commits 3 Files Changed 11 +264 -133
raucao commented 2020-11-21 14:13:44 +00:00
Owner
Copy Link

Running on https://accounts.kosmos.org now.

closes #238

Running on https://accounts.kosmos.org now. closes #238
raucao added the
kredits-2
 label 2020-11-21 14:13:44 +00:00
raucao requested review from greg 2020-11-22 17:40:01 +00:00
greg requested changes 2020-11-22 18:15:59 +00:00
greg left a comment
Owner
Copy Link

LGTM apart from my comment about the unsed resource!

LGTM apart from my comment about the unsed resource!
site-cookbooks/kosmos-akkounts/recipes/default.rb
@ -45,0 +49,4 @@
bundle_path = "/opt/ruby_build/builds/#{ruby_version}/bin/bundle"
rails_env = node.chef_environment == "development" ? "development" : "production"
execute "systemctl daemon-reload" do
greg commented 2020-11-22 18:14:17 +00:00
Owner
Copy Link

This resource isn't used, you can delete it. It isn't needed since we're using a systemd_unit resource

This resource isn't used, you can delete it. It isn't needed since we're using a `systemd_unit` resource
raucao commented 2020-11-22 19:28:01 +00:00
Author
Owner
Copy Link

Thanks! That's a leftover from the Mastodon recipe, and the systemd resource didn't exist when I wrote that.

Thanks! That's a leftover from the Mastodon recipe, and the systemd resource didn't exist when I wrote that.
raucao marked this conversation as resolved
greg commented 2020-11-22 18:17:05 +00:00
Owner
Copy Link

unused, not unsed. Can't find a way to edit that comment since it's a review

unused, not unsed. Can't find a way to edit that comment since it's a review
raucao commented 2020-11-22 18:42:55 +00:00
Author
Owner
Copy Link

Can’t find a way to edit that comment since it’s a review

Yeah, I hope they fix that (if it's even still the case in the latest release).

> Can’t find a way to edit that comment since it’s a review Yeah, I hope they fix that (if it's even still the case in the latest release).
raucao requested review from greg 2020-11-22 19:28:13 +00:00
greg approved these changes 2020-11-23 09:52:03 +00:00
greg left a comment
Owner
Copy Link

👍

👍
greg merged commit 89f5a81952 into master 2020-11-23 09:52:16 +00:00
raucao deleted branch feature/akkounts 2020-11-23 10:31:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
greg
Labels
Clear labels
service
accounts
Kosmos Accounts
service
discourse
Kosmos Community Forums
service
drone-ci
Kosmos Drone CI
service
email
mail.kosmos.org
service
garage
S3-compatible object storage
service
gitea
Kosmos Gitea
service
ipfs
Kosmos IPFS
service
mastodon
kosmos.social
service
postgres
Database cluster
service
remotestorage
Portable data storage for the Web
service
wiki
Kosmos Wiki
service
xmpp
Kosmos Chat
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
kredits-2
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/chef#242
No description provided.
Delete Branch "feature/akkounts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?