Configure/deploy new akkounts Rails app #242

Merged
greg merged 3 commits from feature/akkounts into master 2020-11-23 09:52:16 +00:00
Owner

Running on https://accounts.kosmos.org now.

closes #238

Running on https://accounts.kosmos.org now. closes #238
raucao added the
kredits-2
label 2020-11-21 14:13:44 +00:00
raucao requested review from greg 2020-11-22 17:40:01 +00:00
greg requested changes 2020-11-22 18:15:59 +00:00
greg left a comment
Owner

LGTM apart from my comment about the unsed resource!

LGTM apart from my comment about the unsed resource!
@ -45,0 +49,4 @@
bundle_path = "/opt/ruby_build/builds/#{ruby_version}/bin/bundle"
rails_env = node.chef_environment == "development" ? "development" : "production"
execute "systemctl daemon-reload" do
Owner

This resource isn't used, you can delete it. It isn't needed since we're using a systemd_unit resource

This resource isn't used, you can delete it. It isn't needed since we're using a `systemd_unit` resource
Author
Owner

Thanks! That's a leftover from the Mastodon recipe, and the systemd resource didn't exist when I wrote that.

Thanks! That's a leftover from the Mastodon recipe, and the systemd resource didn't exist when I wrote that.
raucao marked this conversation as resolved
Owner

unused, not unsed. Can't find a way to edit that comment since it's a review

unused, not unsed. Can't find a way to edit that comment since it's a review
Author
Owner

Can’t find a way to edit that comment since it’s a review

Yeah, I hope they fix that (if it's even still the case in the latest release).

> Can’t find a way to edit that comment since it’s a review Yeah, I hope they fix that (if it's even still the case in the latest release).
raucao requested review from greg 2020-11-22 19:28:13 +00:00
greg approved these changes 2020-11-23 09:52:03 +00:00
greg left a comment
Owner

👍

👍
greg merged commit 89f5a81952 into master 2020-11-23 09:52:16 +00:00
raucao deleted branch feature/akkounts 2020-11-23 10:31:02 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/chef#242
No description provided.