Add/store channel archive metadata document #8

2021-11-08T11:58:15Z

raucao commented

2021-11-08 11:58:15 +00:00

In order to be able to easily retrieve the last archive date and document, this adds a '/meta' doc, which contains both the first and last archive dates/IDs, to a channel's root directory.

Caveat: I have encountered what looks like a bug with non-explicit caching turned on in the remoteStorage client. So this requires instantiating RS clients with the cache: false option for now.

closes #7

In order to be able to easily retrieve the last archive date and document, this adds a '/meta' doc, which contains both the first and last archive dates/IDs, to a channel's root directory. Caveat: I have encountered what looks like a bug with non-explicit caching turned on in the remoteStorage client. So this requires instantiating RS clients with the `cache: false` option for now. closes #7

raucao added the kredits-2 label 2021-11-08 11:58:15 +00:00

raucao added 2 commits 2021-11-08 11:58:16 +00:00

Add archive metadata schema, RS type cd93cd4167

Store meta document with first/last archive ID 54352e09e8

raucao requested review from galfert 2021-11-08 11:58:20 +00:00

raucao changed title from ~~Add/store chat archive metadata document~~ to Add/store channel archive metadata document

2021-11-08 11:58:28 +00:00

galfert approved these changes 2021-11-10 10:45:58 +00:00

galfert left a comment

utACK

src/chat-messages.js Outdated

						
				@@ -15,0 +18,4 @@

				  const sortedNumbers = Object.keys(items)

				                              .map(i => parseInt(i))

				                              .filter(i => !Number.isNaN(i))

				                              .sort(function(a, b) { return a - b });

galfert commented

2021-11-10 09:32:21 +00:00

.sort() is enough, as it's the default sort order.

`.sort()` is enough, as it's the default sort order.

raucao added 1 commit 2021-11-13 20:55:34 +00:00

Remove superfluous sort function f83ef92adc

#8 (comment)

Co-authored-by: Garret Alfert <alfert@wevelop.de>

raucao merged commit 84613ed3a3 into master

2021-11-13 20:56:18 +00:00

raucao referenced this issue from a commit

2021-11-13 20:56:18 +00:00

Merge pull request 'Add/store channel archive metadata document' (#8) from feature/7-archive_metadata into master

raucao deleted branch feature/7-archive_metadata

2021-11-13 20:56:25 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/rs-module-chat-messages#8