fail #226

Closed

hueso wants to merge 1 commits from feature/undivisible into master

pull from: feature/undivisible

merge into: kredits:master

kredits:master

kredits:new-final-deploy

kredits:new-final-deploy-2

kredits:reimbursement-export

kredits:staging

kredits:legacy

kredits:addresses/rsk-testnet-raucao-1

kredits:ipfs-defaults

kredits:deletemewhendone

kredits:feature/184-improve_withdrawal

kredits:tests/contracts-contribution

kredits:tests/contracts-kit

kredits:kit/add-vault-app

kredits:feature/ipfs_hash_in_add_response

kredits:chore/bootstrap-on-travis

kredits:chore/remove-direct-aragon-cli-dependency

kredits:chore/update-dependencies-1

kredits:fix/ipfs-config

kredits:apm-hack

kredits:wtf/package-lock

kredits:feature/contributor-balance

kredits:feature/constructor-options

Conversation 0 Commits 1 Files Changed 1 +1192 -225

hueso commented 2022-09-02 01:15:22 +00:00

Member

Copy Link

No description provided.

hueso added 23 commits 2022-09-02 01:15:23 +00:00

Added export/import function for contributors 2fca436fa8

Improve console output 550bc2b9f4

Fix ignored contributions not resolving their promise 883f9adb96

Also export vetoed contributions 990e2a9649

Finish contributor import script 1521e272f9

Add mocha, chai, and test for Contribution 59bda71f97

Formatting 55877897be

CI 0fc4eed09a

Allow deployer to set a migration-done flag ... de1574155c

* Save deployer's address on contract initialization
* Add modifier for requiring tx sender to be deployer
* Add migrationDone flag and function to set it to finished status

Add test for setting deployer address 90172071fa

Revert core flag change cd07313679

Add tests for Contribution#add() 67add71a22

Allow setting confirmedAtBlock and vetoed during migration 9dd9d298cc

Move contract test to its own subdirectory d72413eb66

Add first Contributor contract test 796ccebd84

Add tests for Contributor#add() dc2c8130f3

WIP Remove claims, add withdrawals 2b3fd1241d

Make test complete, add FIXME note e99184b83f

Use uint32 for kreditsWithdrawn ... 5da710cc14

Same as the properties and functions in the Contribution contract

Merge pull request 'Remove claims, add withdrawals' (#225) from feature/184-remove_kredits_claims into feature/export-import ... fd012d5359

Reviewed-on: #225

Add script for importing contributions f29054bc0b

Use ethers from correct parent object 258c1cc755

make KS undivisible b01ffed0b2

hueso closed this pull request 2022-09-02 01:17:59 +00:00

hueso changed title from Make Kredits undivisible to fail 2022-09-02 01:45:50 +00:00

Some checks failed

Hide all checks

continuous-integration/drone/push Build is failing

Details

continuous-integration/drone/pr Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

good first issue

Good for newcomers

ipfs

rsk

scaling

bug

Something is not working

dev environment

Config, builds, CI, deployment, etc.

docs

Documentation

duplicate

This issue or pull request already exists

enhancement

Improving existing functionality

feature

New functionality

idea

Something to consider

invalid

Not a bug

kredits-1

Small contribution

kredits-2

Medium contribution

kredits-3

Large contribution

question

Looking for an answer

release

major

release

minor

release

patch

security

All your base are belong to us

ui/ux

User interface, process design, etc.

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/contracts#226

No description provided.