kredits/contracts
kredits/contracts
9
1
Fork 0
Code Issues 21 Pull Requests Actions Projects 1 Releases 8 Activity

Rename ipfsHash to hashDigest in Contributor #80

Merged
bumi merged 2 commits from chore/rename-ipfshash-1 into master 2019-04-06 13:55:20 +00:00
Conversation 7 Commits 2 Files Changed 3 +11 -16
bumi commented 2019-04-06 13:26:26 +00:00 (Migrated from github.com)
Copy Link

naming should be consistent with the other contracts and digest is more correct.

rebased version of #79
closes #75 - do you see anything missing @fsmanuel?

naming should be consistent with the other contracts and digest is more correct. rebased version of #79 closes #75 - do you see anything missing @fsmanuel?
fsmanuel (Migrated from github.com) reviewed 2019-04-06 13:37:42 +00:00
apps/contributor/contracts/Contributor.sol
fsmanuel (Migrated from github.com) commented 2019-04-06 13:37:42 +00:00
Copy Link

Why do we need that? If we need it I would rename it to updateContributorProfile like the event.

Why do we need that? If we need it I would rename it to `updateContributorProfile` like the event.
bumi (Migrated from github.com) reviewed 2019-04-06 13:39:28 +00:00
apps/contributor/contracts/Contributor.sol
bumi (Migrated from github.com) commented 2019-04-06 13:39:28 +00:00
Copy Link

very true.
I think we need it to be able to update the user's details - like profile picture or whatever.

very true. I think we need it to be able to update the user's details - like profile picture or whatever.
raucao (Migrated from github.com) reviewed 2019-04-06 13:40:16 +00:00
apps/contributor/contracts/Contributor.sol
raucao (Migrated from github.com) commented 2019-04-06 13:40:16 +00:00
Copy Link

Any and all user details actually. Everything except the Ethereum account/address.

Any and all user details actually. Everything except the Ethereum account/address.
fsmanuel (Migrated from github.com) reviewed 2019-04-06 13:40:54 +00:00
apps/contributor/contracts/Contributor.sol
fsmanuel (Migrated from github.com) commented 2019-04-06 13:40:54 +00:00
Copy Link

General question: When do you need to use emit for an event?

General question: When do you need to use `emit` for an event?
bumi (Migrated from github.com) reviewed 2019-04-06 13:43:34 +00:00
apps/contributor/contracts/Contributor.sol
bumi (Migrated from github.com) commented 2019-04-06 13:43:34 +00:00
Copy Link

always in newer solidity version. events without emit is deprecated - so we must update that soon.

always in newer solidity version. events without emit is deprecated - so we must update that soon.
fsmanuel (Migrated from github.com) reviewed 2019-04-06 13:50:37 +00:00
apps/contributor/contracts/Contributor.sol
fsmanuel (Migrated from github.com) commented 2019-04-06 13:50:37 +00:00
Copy Link

Thanks!

Thanks!
fsmanuel commented 2019-04-06 13:51:53 +00:00 (Migrated from github.com)
Copy Link

👍

👍
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
good first issue
Good for newcomers
ipfs
rsk
scaling
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg haythem hueso raucao slvrbckt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/contracts#80
No description provided.
Delete Branch "chore/rename-ipfshash-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?