kredits/hubot-kredits
9
0 Fork 0
Code Issues 8 Pull Requests Releases 9 Activity

Create contributions for PR reviews #66

Merged
galfert merged 1 commits from feature/49-create_review_contributions into master 2021-03-29 08:43:22 +00:00
Conversation 4 Commits 1 Files Changed 1
+34 -5
galfert commented 2021-01-29 11:38:13 +00:00 (Migrated from github.com)
Copy link
Copy source

Refs #49

This should create the actual Contribution transactions for the PR reviews.

I could not test this myself, because I don't have a local devchain running.

Refs #49 This should create the actual Contribution transactions for the PR reviews. I could not test this myself, because I don't have a local devchain running.
raucao (Migrated from github.com) reviewed 2021-01-29 11:38:13 +00:00
bumi (Migrated from github.com) approved these changes 2021-02-15 12:34:27 +00:00
bumi (Migrated from github.com) left a comment
Copy link
Copy source

looks good to me!
I still have local issues running the aragon dependency here, but it looks good to me. and I guess with the reviews we have to test that on live anyway.
👍

looks good to me! I still have local issues running the aragon dependency here, but it looks good to me. and I guess with the reviews we have to test that on live anyway. 👍
scripts/review-kredits.js
bumi (Migrated from github.com) commented 2021-02-15 12:31:02 +00:00
Copy link
Copy source

why do you pass in Contribution here and not use kredits.Contribution from the global variable?

why do you pass in `Contribution` here and not use `kredits.Contribution` from the global variable?
galfert (Migrated from github.com) reviewed 2021-02-15 13:24:22 +00:00
scripts/review-kredits.js
galfert (Migrated from github.com) commented 2021-02-15 13:24:22 +00:00
Copy link
Copy source

kredits is not global.

`kredits` is not global.
bumi (Migrated from github.com) reviewed 2021-02-15 13:36:16 +00:00
scripts/review-kredits.js
bumi (Migrated from github.com) commented 2021-02-15 13:36:16 +00:00
Copy link
Copy source

oh true.
though I guess it could be?

oh true. though I guess it could be?
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
galfert
bumi
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
 security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
release
major
release
minor
release
patch
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/hubot-kredits#66